From: Wojciech Drewek <wojciech.drewek@intel.com>
To: Jakub Kicinski <kuba@kernel.org>
Cc: Michael Chan <michael.chan@broadcom.com>, <davem@davemloft.net>,
<netdev@vger.kernel.org>, <edumazet@google.com>,
<pabeni@redhat.com>, <gospo@broadcom.com>,
Ajit Khaparde <ajit.khaparde@broadcom.com>
Subject: Re: [PATCH net-next] bnxt_en: Fix 2 stray ethtool -S counters
Date: Thu, 26 Oct 2023 16:35:54 +0200 [thread overview]
Message-ID: <082150a7-f2f1-40bf-aa4d-81d4b6f5ce40@intel.com> (raw)
In-Reply-To: <20231026072830.1202cccc@kernel.org>
On 26.10.2023 16:28, Jakub Kicinski wrote:
> On Thu, 26 Oct 2023 12:36:37 +0200 Wojciech Drewek wrote:
>>> Fixes: 754fbf604ff6 ("bnxt_en: Update firmware interface to 1.10.2.171")
>>
>> If this is a fix than the target should be "net" not "net-next".
>
> The commit in question hasn't reached net yet, this is the second time
> you're going this incorrect feedback:
>
> https://lore.kernel.org/all/20231023093256.0dd8f145@kernel.org/
Sorry, I somehow missed your comment.
>
>> You don't need "len" var.
>> Why not just:
>> num_stats += min_t(int, bp->fw_rx_stats_ext_size,
>> ARRAY_SIZE(bnxt_port_stats_ext_arr));
>
> I think it's needed to make sure lines don't go over 80 chars.
Makes sense
next prev parent reply other threads:[~2023-10-26 14:37 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-26 1:32 [PATCH net-next] bnxt_en: Fix 2 stray ethtool -S counters Michael Chan
2023-10-26 10:36 ` Wojciech Drewek
2023-10-26 14:28 ` Jakub Kicinski
2023-10-26 14:35 ` Wojciech Drewek [this message]
2023-10-27 3:10 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=082150a7-f2f1-40bf-aa4d-81d4b6f5ce40@intel.com \
--to=wojciech.drewek@intel.com \
--cc=ajit.khaparde@broadcom.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=gospo@broadcom.com \
--cc=kuba@kernel.org \
--cc=michael.chan@broadcom.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.