From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D4C46C43603 for ; Fri, 20 Dec 2019 11:42:19 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id ADE7E24683 for ; Fri, 20 Dec 2019 11:42:19 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727177AbfLTLmS (ORCPT ); Fri, 20 Dec 2019 06:42:18 -0500 Received: from mx2.suse.de ([195.135.220.15]:45494 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727205AbfLTLmS (ORCPT ); Fri, 20 Dec 2019 06:42:18 -0500 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.220.254]) by mx2.suse.de (Postfix) with ESMTP id C3F17ACA3; Fri, 20 Dec 2019 11:42:16 +0000 (UTC) Subject: Re: [PATCH v13 2/5] xenbus/backend: Protect xenbus callback with lock To: SeongJae Park , axboe@kernel.dk, konrad.wilk@oracle.com, roger.pau@citrix.com Cc: SeongJae Park , pdurrant@amazon.com, sj38.park@gmail.com, xen-devel@lists.xenproject.org, linux-block@vger.kernel.org, linux-kernel@vger.kernel.org References: <20191218183718.31719-1-sjpark@amazon.com> <20191218183718.31719-3-sjpark@amazon.com> From: =?UTF-8?B?SsO8cmdlbiBHcm/Dnw==?= Message-ID: <08256095-3b19-8041-9ceb-e9caa77ed4c5@suse.com> Date: Fri, 20 Dec 2019 12:42:11 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.2.1 MIME-Version: 1.0 In-Reply-To: <20191218183718.31719-3-sjpark@amazon.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-block-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-block@vger.kernel.org On 18.12.19 19:37, SeongJae Park wrote: > From: SeongJae Park > > A driver's 'reclaim_memory' callback can race with 'probe' or 'remove' > because it will be called whenever memory pressure is detected. To > avoid such race, this commit embeds a spinlock in each 'xenbus_device' > and make 'xenbus' to hold the lock while the corresponded callbacks are > running. > > Signed-off-by: SeongJae Park Reviewed-by: Juergen Gross Juergen From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BDE9CC43603 for ; Fri, 20 Dec 2019 11:42:41 +0000 (UTC) Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 974FD2467F for ; Fri, 20 Dec 2019 11:42:41 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 974FD2467F Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=suse.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=xen-devel-bounces@lists.xenproject.org Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1iiGfk-0004XZ-3s; Fri, 20 Dec 2019 11:42:20 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1iiGfi-0004XU-Vi for xen-devel@lists.xenproject.org; Fri, 20 Dec 2019 11:42:19 +0000 X-Inumbo-ID: c618d722-231d-11ea-9339-12813bfff9fa Received: from mx2.suse.de (unknown [195.135.220.15]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id c618d722-231d-11ea-9339-12813bfff9fa; Fri, 20 Dec 2019 11:42:17 +0000 (UTC) X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.220.254]) by mx2.suse.de (Postfix) with ESMTP id C3F17ACA3; Fri, 20 Dec 2019 11:42:16 +0000 (UTC) To: SeongJae Park , axboe@kernel.dk, konrad.wilk@oracle.com, roger.pau@citrix.com References: <20191218183718.31719-1-sjpark@amazon.com> <20191218183718.31719-3-sjpark@amazon.com> From: =?UTF-8?B?SsO8cmdlbiBHcm/Dnw==?= Message-ID: <08256095-3b19-8041-9ceb-e9caa77ed4c5@suse.com> Date: Fri, 20 Dec 2019 12:42:11 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.2.1 MIME-Version: 1.0 In-Reply-To: <20191218183718.31719-3-sjpark@amazon.com> Content-Language: en-US Subject: Re: [Xen-devel] [PATCH v13 2/5] xenbus/backend: Protect xenbus callback with lock X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Cc: linux-block@vger.kernel.org, pdurrant@amazon.com, SeongJae Park , linux-kernel@vger.kernel.org, sj38.park@gmail.com, xen-devel@lists.xenproject.org Content-Transfer-Encoding: base64 Content-Type: text/plain; charset="utf-8"; Format="flowed" Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" T24gMTguMTIuMTkgMTk6MzcsIFNlb25nSmFlIFBhcmsgd3JvdGU6Cj4gRnJvbTogU2VvbmdKYWUg UGFyayA8c2pwYXJrQGFtYXpvbi5kZT4KPiAKPiBBIGRyaXZlcidzICdyZWNsYWltX21lbW9yeScg Y2FsbGJhY2sgY2FuIHJhY2Ugd2l0aCAncHJvYmUnIG9yICdyZW1vdmUnCj4gYmVjYXVzZSBpdCB3 aWxsIGJlIGNhbGxlZCB3aGVuZXZlciBtZW1vcnkgcHJlc3N1cmUgaXMgZGV0ZWN0ZWQuICBUbwo+ IGF2b2lkIHN1Y2ggcmFjZSwgdGhpcyBjb21taXQgZW1iZWRzIGEgc3BpbmxvY2sgaW4gZWFjaCAn eGVuYnVzX2RldmljZScKPiBhbmQgbWFrZSAneGVuYnVzJyB0byBob2xkIHRoZSBsb2NrIHdoaWxl IHRoZSBjb3JyZXNwb25kZWQgY2FsbGJhY2tzIGFyZQo+IHJ1bm5pbmcuCj4gCj4gU2lnbmVkLW9m Zi1ieTogU2VvbmdKYWUgUGFyayA8c2pwYXJrQGFtYXpvbi5kZT4KClJldmlld2VkLWJ5OiBKdWVy Z2VuIEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+CgoKSnVlcmdlbgoKX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX18KWGVuLWRldmVsIG1haWxpbmcgbGlzdApYZW4t ZGV2ZWxAbGlzdHMueGVucHJvamVjdC5vcmcKaHR0cHM6Ly9saXN0cy54ZW5wcm9qZWN0Lm9yZy9t YWlsbWFuL2xpc3RpbmZvL3hlbi1kZXZlbA==