From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.1 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2AE41C433F5 for ; Fri, 3 Sep 2021 06:01:09 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 0F925610E5 for ; Fri, 3 Sep 2021 06:01:09 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S242759AbhICGCH (ORCPT ); Fri, 3 Sep 2021 02:02:07 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34856 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S238297AbhICGCD (ORCPT ); Fri, 3 Sep 2021 02:02:03 -0400 Received: from mail-lf1-x130.google.com (mail-lf1-x130.google.com [IPv6:2a00:1450:4864:20::130]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 51D5AC061760; Thu, 2 Sep 2021 23:01:03 -0700 (PDT) Received: by mail-lf1-x130.google.com with SMTP id p38so9660910lfa.0; Thu, 02 Sep 2021 23:01:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=pgs3kLLPKzcjFcrSbgZkVPLdLHwMQc7gUvwcn4k6Fwk=; b=fKqBIrEaXQgsLWgf0iZOXlQ0VJkZkUKWbEEtRyL7rfK9FATg3lmTYsUT3s2cF2NEjb Bt7vCRe3CFwn5bTK8AF7jNWT3D/eo2DGNCTnoy5y3l0vTmqhtJYnOcaOBUAefoSo7Nak SYYV/DYrCUJ0ukcD2yPs725IGwep8AfidmGJh+wFSTS4VTQ05f7k7ijU0269echC8FaU gTo2fQ3ShgW49KnOrWSZH6hL4XKEaPQYfIGw534uRwBTiJKN9N55eOZHNZ+SRoxV/fi7 5nb6hGxaqqJJcPgnZPlCZZtQFdyLhWJkEgrDI2BMULg4ZbEqzCVFK3bCKBsoOHLZKTYe BI2A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=pgs3kLLPKzcjFcrSbgZkVPLdLHwMQc7gUvwcn4k6Fwk=; b=oGxci/E6m3GgtdPqfN5ary+Ztyghtlmk9/SQVhAH2R5J8wjfruLwPkTXBff0eygPfw yIjEo0AoKvFHt++7rXJvb1Nxi/EiNKwxZXD8f6fHI1gAkV9xXIR+AHt8FxlehOeDxCAD EaFxeqBri8/Uwt/p8B6j1N76oSg0Ac0JVkhbuzJeMb9pMjY2AkX9M/et/5T6aHkb0xJj /k3vUz7FCdd48Nv0H6a990EBqt4a17onJl9x33wOot6Ho318QP9nLiK6x8BBBD6iwPtP 494r5q5+Iy2r3htHKA443n4UCnh0YDxNHZ97gAwpr423YlxpYfYzVhsO+yqbnzZWArM+ Fs9w== X-Gm-Message-State: AOAM532HIsNME9keoANrXA6xltMyG3NoQMr1zxaGI/xfc+HwAFokSPhY 2ofMWH0fcIljJLBZQxE/t0HnDZ/fDoM= X-Google-Smtp-Source: ABdhPJxN+4FC6fCSw3slkr+iUqZZHmtD/YEMsm+izm8dyAttXrN/XDOUHbpAJwY1Y1aOh1ewHzNvbg== X-Received: by 2002:a05:6512:3503:: with SMTP id h3mr1462072lfs.564.1630648861576; Thu, 02 Sep 2021 23:01:01 -0700 (PDT) Received: from [192.168.2.145] (46-138-26-37.dynamic.spd-mgts.ru. [46.138.26.37]) by smtp.googlemail.com with ESMTPSA id w3sm473175ljm.13.2021.09.02.23.01.00 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 02 Sep 2021 23:01:01 -0700 (PDT) Subject: Re: [PATCH 1/3] PM: domains: Drop the performance state vote for a device at detach To: Ulf Hansson , "Rafael J . Wysocki" , Viresh Kumar , linux-pm@vger.kernel.org Cc: Dmitry Baryshkov , Jonathan Hunter , Thierry Reding , Rajendra Nayak , Stephan Gerhold , Bjorn Andersson , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org References: <20210902101634.827187-1-ulf.hansson@linaro.org> <20210902101634.827187-2-ulf.hansson@linaro.org> From: Dmitry Osipenko Message-ID: <08335cd4-7dc8-3b8b-d63f-374585ffa373@gmail.com> Date: Fri, 3 Sep 2021 09:01:00 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 MIME-Version: 1.0 In-Reply-To: <20210902101634.827187-2-ulf.hansson@linaro.org> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-pm@vger.kernel.org 02.09.2021 13:16, Ulf Hansson пишет: > When a device is detached from its genpd, genpd loses track of the device, > including its performance state vote that may have been requested for it. > > Rather than relying on the consumer driver to drop the performance state > vote for its device, let's do it internally in genpd when the device is > getting detached. In this way, we makes sure that the aggregation of the > votes in genpd becomes correct. This is a dangerous behaviour in a case where performance state represents voltage. If hardware is kept active on detachment, say it's always-on, then it may be a disaster to drop the voltage for the active hardware. It's safe to drop performance state only if you assume that there is a firmware behind kernel which has its own layer of performance management and it will prevent the disaster by saying 'nope, I'm not doing this'. The performance state should be persistent for a device and it should be controlled in a conjunction with runtime PM. If platform wants to drop performance state to zero on detachment, then this behaviour should be specific to that platform. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.1 required=3.0 tests=BAYES_00,DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED,DKIM_VALID,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8BD1EC433EF for ; Fri, 3 Sep 2021 06:05:02 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 5694960FA0 for ; Fri, 3 Sep 2021 06:05:02 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 5694960FA0 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date: Message-ID:From:References:Cc:To:Subject:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Owner; bh=imMYlY1BvRo6zQr+HQpYy8T67tNjpHGBOOTg0J+CFO0=; b=H/hwgqwFFtgZ/hLaDuE29dahvG qw40Hu19i1ohVCC/nnAxvUP46bsUH7rbfCh4W4cn/WDtufDguPhJWPWjP4E4UtyYP9E0ABbRushWX 2KJQGqe63QcFI+Vg4OAQcC3vbyc4NzeWve7bJPX8BrHZYaAXS/QCkA5ytnr7xm9h1kH4bkMkNK5bK xsdpKzVGGQdSc8m7SF/Y7d6/u9z4XFRxcSeDNXUzKzwtEcPnvlDyyVHKjK9Sswlkgz/fEUSbZdOr4 OAko0uORli/Rq/gb0gXG9EmZv175ZADdg5o+ebkvrEJMrdjQ40MPesCRkZprkFEzPVg1iqEavTsnX k9WgiPPA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mM2Gh-00B1NC-Nd; Fri, 03 Sep 2021 06:01:39 +0000 Received: from mail-lf1-x12f.google.com ([2a00:1450:4864:20::12f]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mM2G7-00B1En-4z for linux-arm-kernel@lists.infradead.org; Fri, 03 Sep 2021 06:01:06 +0000 Received: by mail-lf1-x12f.google.com with SMTP id l10so9565797lfg.4 for ; Thu, 02 Sep 2021 23:01:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=pgs3kLLPKzcjFcrSbgZkVPLdLHwMQc7gUvwcn4k6Fwk=; b=fKqBIrEaXQgsLWgf0iZOXlQ0VJkZkUKWbEEtRyL7rfK9FATg3lmTYsUT3s2cF2NEjb Bt7vCRe3CFwn5bTK8AF7jNWT3D/eo2DGNCTnoy5y3l0vTmqhtJYnOcaOBUAefoSo7Nak SYYV/DYrCUJ0ukcD2yPs725IGwep8AfidmGJh+wFSTS4VTQ05f7k7ijU0269echC8FaU gTo2fQ3ShgW49KnOrWSZH6hL4XKEaPQYfIGw534uRwBTiJKN9N55eOZHNZ+SRoxV/fi7 5nb6hGxaqqJJcPgnZPlCZZtQFdyLhWJkEgrDI2BMULg4ZbEqzCVFK3bCKBsoOHLZKTYe BI2A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=pgs3kLLPKzcjFcrSbgZkVPLdLHwMQc7gUvwcn4k6Fwk=; b=W4ZUlcd7YQYELLv1xkOj6SgZLE/qJAAftMfQudSzVXY9Riw9ytPHFGZncS5Bd9C7kS hMliJySVU+YicxxcnfcpFtahOm95TFHnRsSM3P+1W8GqIZjIqQ09GPl1SPOHFs9jV2LP yKcqL2BoeRIPWxkePi5dxssTc3NYJgCX8r7K91nP3pCp/GFTC61Tp/Pyx/CKd82qEf7D K2GjF1dJA1ckW/dQf5rn0YA88uKgft9BffgWfvanMbIHQL9Q0ANTrurkYgoQqtbUcEpA pxoeY1ArNM8oP7PWU4VPl8u9OG1TiBHfpLOvY+3mJFz8BMC1kR5BMNMJZsTPF9x8o4BJ ULmw== X-Gm-Message-State: AOAM533++o6CeehsWvUzrCfhFMn45mRFIMZZuUbeoeuaHW2mvhWz9BL9 uFKt4kFN8RMaG+RCU2NpOt/pM9yNo0o= X-Google-Smtp-Source: ABdhPJxN+4FC6fCSw3slkr+iUqZZHmtD/YEMsm+izm8dyAttXrN/XDOUHbpAJwY1Y1aOh1ewHzNvbg== X-Received: by 2002:a05:6512:3503:: with SMTP id h3mr1462072lfs.564.1630648861576; Thu, 02 Sep 2021 23:01:01 -0700 (PDT) Received: from [192.168.2.145] (46-138-26-37.dynamic.spd-mgts.ru. [46.138.26.37]) by smtp.googlemail.com with ESMTPSA id w3sm473175ljm.13.2021.09.02.23.01.00 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 02 Sep 2021 23:01:01 -0700 (PDT) Subject: Re: [PATCH 1/3] PM: domains: Drop the performance state vote for a device at detach To: Ulf Hansson , "Rafael J . Wysocki" , Viresh Kumar , linux-pm@vger.kernel.org Cc: Dmitry Baryshkov , Jonathan Hunter , Thierry Reding , Rajendra Nayak , Stephan Gerhold , Bjorn Andersson , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org References: <20210902101634.827187-1-ulf.hansson@linaro.org> <20210902101634.827187-2-ulf.hansson@linaro.org> From: Dmitry Osipenko Message-ID: <08335cd4-7dc8-3b8b-d63f-374585ffa373@gmail.com> Date: Fri, 3 Sep 2021 09:01:00 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 MIME-Version: 1.0 In-Reply-To: <20210902101634.827187-2-ulf.hansson@linaro.org> Content-Language: en-US X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210902_230105_363980_8F32D646 X-CRM114-Status: GOOD ( 16.18 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org MDIuMDkuMjAyMSAxMzoxNiwgVWxmIEhhbnNzb24g0L/QuNGI0LXRgjoKPiBXaGVuIGEgZGV2aWNl IGlzIGRldGFjaGVkIGZyb20gaXRzIGdlbnBkLCBnZW5wZCBsb3NlcyB0cmFjayBvZiB0aGUgZGV2 aWNlLAo+IGluY2x1ZGluZyBpdHMgcGVyZm9ybWFuY2Ugc3RhdGUgdm90ZSB0aGF0IG1heSBoYXZl IGJlZW4gcmVxdWVzdGVkIGZvciBpdC4KPiAKPiBSYXRoZXIgdGhhbiByZWx5aW5nIG9uIHRoZSBj b25zdW1lciBkcml2ZXIgdG8gZHJvcCB0aGUgcGVyZm9ybWFuY2Ugc3RhdGUKPiB2b3RlIGZvciBp dHMgZGV2aWNlLCBsZXQncyBkbyBpdCBpbnRlcm5hbGx5IGluIGdlbnBkIHdoZW4gdGhlIGRldmlj ZSBpcwo+IGdldHRpbmcgZGV0YWNoZWQuIEluIHRoaXMgd2F5LCB3ZSBtYWtlcyBzdXJlIHRoYXQg dGhlIGFnZ3JlZ2F0aW9uIG9mIHRoZQo+IHZvdGVzIGluIGdlbnBkIGJlY29tZXMgY29ycmVjdC4K ClRoaXMgaXMgYSBkYW5nZXJvdXMgYmVoYXZpb3VyIGluIGEgY2FzZSB3aGVyZSBwZXJmb3JtYW5j ZSBzdGF0ZQpyZXByZXNlbnRzIHZvbHRhZ2UuIElmIGhhcmR3YXJlIGlzIGtlcHQgYWN0aXZlIG9u IGRldGFjaG1lbnQsIHNheSBpdCdzCmFsd2F5cy1vbiwgdGhlbiBpdCBtYXkgYmUgYSBkaXNhc3Rl ciB0byBkcm9wIHRoZSB2b2x0YWdlIGZvciB0aGUgYWN0aXZlCmhhcmR3YXJlLgoKSXQncyBzYWZl IHRvIGRyb3AgcGVyZm9ybWFuY2Ugc3RhdGUgb25seSBpZiB5b3UgYXNzdW1lIHRoYXQgdGhlcmUg aXMgYQpmaXJtd2FyZSBiZWhpbmQga2VybmVsIHdoaWNoIGhhcyBpdHMgb3duIGxheWVyIG9mIHBl cmZvcm1hbmNlIG1hbmFnZW1lbnQKYW5kIGl0IHdpbGwgcHJldmVudCB0aGUgZGlzYXN0ZXIgYnkg c2F5aW5nICdub3BlLCBJJ20gbm90IGRvaW5nIHRoaXMnLgoKVGhlIHBlcmZvcm1hbmNlIHN0YXRl IHNob3VsZCBiZSBwZXJzaXN0ZW50IGZvciBhIGRldmljZSBhbmQgaXQgc2hvdWxkIGJlCmNvbnRy b2xsZWQgaW4gYSBjb25qdW5jdGlvbiB3aXRoIHJ1bnRpbWUgUE0uIElmIHBsYXRmb3JtIHdhbnRz IHRvIGRyb3AKcGVyZm9ybWFuY2Ugc3RhdGUgdG8gemVybyBvbiBkZXRhY2htZW50LCB0aGVuIHRo aXMgYmVoYXZpb3VyIHNob3VsZCBiZQpzcGVjaWZpYyB0byB0aGF0IHBsYXRmb3JtLgoKX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KbGludXgtYXJtLWtlcm5l bCBtYWlsaW5nIGxpc3QKbGludXgtYXJtLWtlcm5lbEBsaXN0cy5pbmZyYWRlYWQub3JnCmh0dHA6 Ly9saXN0cy5pbmZyYWRlYWQub3JnL21haWxtYW4vbGlzdGluZm8vbGludXgtYXJtLWtlcm5lbAo=