From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 23B10C4332F for ; Wed, 14 Dec 2022 14:07:44 +0000 (UTC) Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id 5E5DF2A21; Wed, 14 Dec 2022 15:06:52 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz 5E5DF2A21 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1671026862; bh=kRnzKDaifLMzk91f4ryWfcXJa4yv7M4AXVG0yIWndXw=; h=Date:Subject:To:References:From:In-Reply-To:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: Cc:From; b=hguY4Hc4nyWDI5s6oOI52oLLuMMUdeEF7GUPUGerHTXGiv9iRPLSJ3B+lNm9VskoR wG61KJUJHjif0PoZcJe+F7tME44AQVq5TdqRuKG1apUJFRQanb0ruPlji64ojfIDO8 llkon4WiaDGZp6Ne0ex/HJecaWhA+I+P9iRLjF/g= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id 0F534F804D0; Wed, 14 Dec 2022 15:06:52 +0100 (CET) Received: by alsa1.perex.cz (Postfix, from userid 50401) id D8B37F804E0; Wed, 14 Dec 2022 15:06:50 +0100 (CET) Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id BBF14F80141 for ; Wed, 14 Dec 2022 15:06:48 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz BBF14F80141 Authentication-Results: alsa1.perex.cz; dkim=pass (2048-bit key, unprotected) header.d=intel.com header.i=@intel.com header.a=rsa-sha256 header.s=Intel header.b=QyDhqFDs DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1671026810; x=1702562810; h=message-id:date:mime-version:subject:to:cc:references: from:in-reply-to:content-transfer-encoding; bh=kRnzKDaifLMzk91f4ryWfcXJa4yv7M4AXVG0yIWndXw=; b=QyDhqFDsU16Cr8eFZElAVMkD9P/SPo4IlU24o28Nmq9tR0/AlS86XDbn ZPqGalkYNaZ7D59Ep2CjuodW/wubDTwvPiTOt9lEtSZUPthtdna2BFNKd MCiPzMHNUo6wwX7hGAT5lH9JTm2/aWuOJ3hjQpeCVlWdEij3y2NYE22Gn xeNnr05EYIXcubd8iDfO6hn17msDEITtRkcvGuDUM6QKetVG9WzVSm58h ZeFsAc5ScB1Zne49Zk9Zr7LyBFVrwdnwNbdUAXWHtbGqzxVqD0C7nBIVr inV/NiybKEsPswttLhziYIxtob13rd/UHMb4pJDuEwwokQqt3/Ma96hB5 Q==; X-IronPort-AV: E=McAfee;i="6500,9779,10560"; a="318452720" X-IronPort-AV: E=Sophos;i="5.96,244,1665471600"; d="scan'208";a="318452720" Received: from orsmga001.jf.intel.com ([10.7.209.18]) by fmsmga103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 14 Dec 2022 06:06:30 -0800 X-IronPort-AV: E=McAfee;i="6500,9779,10560"; a="681517232" X-IronPort-AV: E=Sophos;i="5.96,244,1665471600"; d="scan'208";a="681517232" Received: from gajular-mobl1.amr.corp.intel.com (HELO [10.213.160.14]) ([10.213.160.14]) by orsmga001-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 14 Dec 2022 06:06:28 -0800 Message-ID: <08403fff-359b-b5f4-d039-18eeef660637@linux.intel.com> Date: Tue, 13 Dec 2022 13:04:41 -0600 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Firefox/102.0 Thunderbird/102.4.2 Subject: Re: [PATCH] Add HP Stream 8 to bytcr_rt5640.c Content-Language: en-US To: Moises Cardona , cezary.rojewski@intel.com References: <20221213173550.1567875-1-moisesmcardona@gmail.com> From: Pierre-Louis Bossart In-Reply-To: <20221213173550.1567875-1-moisesmcardona@gmail.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: oder_chiou@realtek.com, alsa-devel@alsa-project.org, kai.vehmanen@linux.intel.com, peter.ujfalusi@linux.intel.com, tiwai@suse.com, ranjani.sridharan@linux.intel.com, liam.r.girdwood@linux.intel.com, hdegoede@redhat.com, broonie@kernel.org, akihiko.odaki@gmail.com, yung-chuan.liao@linux.intel.com, linux-kernel@vger.kernel.org Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" On 12/13/22 11:35, Moises Cardona wrote: > The HP Stream 8 tablet is identical to the HP Stream 7 in terms of the PCB, > with the exception of the added SIM Card Slot. > Therefore, I'm submitting this patch which properly initializes the audio > and enables the headphone jack to work, just like it does in the > HP Stream 7. > > Signed-off-by: Moises Cardona Acked-by: Pierre-Louis Bossart > --- > sound/soc/intel/boards/bytcr_rt5640.c | 11 +++++++++++ > 1 file changed, 11 insertions(+) > > diff --git a/sound/soc/intel/boards/bytcr_rt5640.c b/sound/soc/intel/boards/bytcr_rt5640.c > index fb9d9e271845..1d964b1ceff4 100644 > --- a/sound/soc/intel/boards/bytcr_rt5640.c > +++ b/sound/soc/intel/boards/bytcr_rt5640.c > @@ -796,6 +796,17 @@ static const struct dmi_system_id byt_rt5640_quirk_table[] = { > BYT_RT5640_SSP0_AIF1 | > BYT_RT5640_MCLK_EN), > }, > + { /* HP Stream 8 */ > + .matches = { > + DMI_EXACT_MATCH(DMI_SYS_VENDOR, "Hewlett-Packard"), > + DMI_EXACT_MATCH(DMI_PRODUCT_NAME, "HP Stream 8 Tablet"), > + }, > + .driver_data = (void *)(BYTCR_INPUT_DEFAULTS | > + BYT_RT5640_MONO_SPEAKER | > + BYT_RT5640_JD_NOT_INV | > + BYT_RT5640_SSP0_AIF1 | > + BYT_RT5640_MCLK_EN), > + }, > { /* I.T.Works TW891 */ > .matches = { > DMI_EXACT_MATCH(DMI_SYS_VENDOR, "To be filled by O.E.M."), From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7287DC4332F for ; Wed, 14 Dec 2022 14:07:00 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S238211AbiLNOGw (ORCPT ); Wed, 14 Dec 2022 09:06:52 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36836 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229867AbiLNOGs (ORCPT ); Wed, 14 Dec 2022 09:06:48 -0500 Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7CC0D1E3EC for ; Wed, 14 Dec 2022 06:06:47 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1671026807; x=1702562807; h=message-id:date:mime-version:subject:to:cc:references: from:in-reply-to:content-transfer-encoding; bh=kRnzKDaifLMzk91f4ryWfcXJa4yv7M4AXVG0yIWndXw=; b=nUVE+tJrLi+MEBmCSnfHxzjjAMKKzFawzpDuz20KAF9S3+DSfLqhj0DL CaSllQO0NieFOK3JbuNkvlWMxkrE5ZcA3YUlnmaDli/VbAEZ6tDKaLMXu hDunpaDlBu4q+JANsnITYY3ii9qGzb9fRPbywrRI5G+AP8P5pCQeAlDVt EbwW/5aYHar53FX3T1HheTs4GvbltSn/42VplupUAe+Umk+Cv4/ScPN10 XCCrjWU9AdN6de3bJL6CxXIQA5WUhaLlNESYdn9njEV/HHbSeS9tRscWZ Eg+cPYLtkqtiWwzJq0fUUu6BS9jwx0z/YiqL2FMym4ZeQDHaEkdE98wwf A==; X-IronPort-AV: E=McAfee;i="6500,9779,10560"; a="318452723" X-IronPort-AV: E=Sophos;i="5.96,244,1665471600"; d="scan'208";a="318452723" Received: from orsmga001.jf.intel.com ([10.7.209.18]) by fmsmga103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 14 Dec 2022 06:06:31 -0800 X-IronPort-AV: E=McAfee;i="6500,9779,10560"; a="681517232" X-IronPort-AV: E=Sophos;i="5.96,244,1665471600"; d="scan'208";a="681517232" Received: from gajular-mobl1.amr.corp.intel.com (HELO [10.213.160.14]) ([10.213.160.14]) by orsmga001-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 14 Dec 2022 06:06:28 -0800 Message-ID: <08403fff-359b-b5f4-d039-18eeef660637@linux.intel.com> Date: Tue, 13 Dec 2022 13:04:41 -0600 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Firefox/102.0 Thunderbird/102.4.2 Subject: Re: [PATCH] Add HP Stream 8 to bytcr_rt5640.c Content-Language: en-US To: Moises Cardona , cezary.rojewski@intel.com Cc: liam.r.girdwood@linux.intel.com, peter.ujfalusi@linux.intel.com, yung-chuan.liao@linux.intel.com, ranjani.sridharan@linux.intel.com, kai.vehmanen@linux.intel.com, broonie@kernel.org, perex@perex.cz, tiwai@suse.com, hdegoede@redhat.com, oder_chiou@realtek.com, akihiko.odaki@gmail.com, alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org References: <20221213173550.1567875-1-moisesmcardona@gmail.com> From: Pierre-Louis Bossart In-Reply-To: <20221213173550.1567875-1-moisesmcardona@gmail.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 12/13/22 11:35, Moises Cardona wrote: > The HP Stream 8 tablet is identical to the HP Stream 7 in terms of the PCB, > with the exception of the added SIM Card Slot. > Therefore, I'm submitting this patch which properly initializes the audio > and enables the headphone jack to work, just like it does in the > HP Stream 7. > > Signed-off-by: Moises Cardona Acked-by: Pierre-Louis Bossart > --- > sound/soc/intel/boards/bytcr_rt5640.c | 11 +++++++++++ > 1 file changed, 11 insertions(+) > > diff --git a/sound/soc/intel/boards/bytcr_rt5640.c b/sound/soc/intel/boards/bytcr_rt5640.c > index fb9d9e271845..1d964b1ceff4 100644 > --- a/sound/soc/intel/boards/bytcr_rt5640.c > +++ b/sound/soc/intel/boards/bytcr_rt5640.c > @@ -796,6 +796,17 @@ static const struct dmi_system_id byt_rt5640_quirk_table[] = { > BYT_RT5640_SSP0_AIF1 | > BYT_RT5640_MCLK_EN), > }, > + { /* HP Stream 8 */ > + .matches = { > + DMI_EXACT_MATCH(DMI_SYS_VENDOR, "Hewlett-Packard"), > + DMI_EXACT_MATCH(DMI_PRODUCT_NAME, "HP Stream 8 Tablet"), > + }, > + .driver_data = (void *)(BYTCR_INPUT_DEFAULTS | > + BYT_RT5640_MONO_SPEAKER | > + BYT_RT5640_JD_NOT_INV | > + BYT_RT5640_SSP0_AIF1 | > + BYT_RT5640_MCLK_EN), > + }, > { /* I.T.Works TW891 */ > .matches = { > DMI_EXACT_MATCH(DMI_SYS_VENDOR, "To be filled by O.E.M."),