All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Hai Li" <hali@codeaurora.org>
To: 'David Binderman' <dcb314@hotmail.com>,
	airlied@linux.ie, dri-devel@lists.freedesktop.org
Subject: RE: linux-4.1-rc1/drivers/gpu/drm/msm/dsi/dsi_host.c:1799: possible missing break ?
Date: Wed, 29 Apr 2015 11:43:45 -0400	[thread overview]
Message-ID: <084501d08293$48b9e490$da2dadb0$@codeaurora.org> (raw)
In-Reply-To: <DUB128-W139E97C9EEA279B0989E769CE90@phx.gbl>

Yes, this is a bug in DSI driver. I have sent a patch to fix it.
http://lists.freedesktop.org/archives/dri-devel/2015-April/081893.html

Sorry for any inconvenience it caused.

Hai


-----Original Message-----
From: dri-devel [mailto:dri-devel-bounces@lists.freedesktop.org] On Behalf Of David Binderman
Sent: Monday, April 27, 2015 1:59 AM
To: airlied@linux.ie; dri-devel@lists.freedesktop.org
Subject: linux-4.1-rc1/drivers/gpu/drm/msm/dsi/dsi_host.c:1799: possible missing break ?

Hello there,

[linux-4.1-rc1/drivers/gpu/drm/msm/dsi/dsi_host.c:1799] -> [linux-4.1-rc1/drivers/gpu/drm/msm/dsi/dsi_host.c:1802]: (warning) Variable 'ret' is reassigned a value before the old one has been used. 'break;' missing?

    switch (cmd) {
    case MIPI_DSI_RX_ACKNOWLEDGE_AND_ERROR_REPORT:
        pr_err("%s: rx ACK_ERR_PACLAGE\n", __func__);
        ret = 0;
    case MIPI_DSI_RX_GENERIC_SHORT_READ_RESPONSE_1BYTE:
    case MIPI_DSI_RX_DCS_SHORT_READ_RESPONSE_1BYTE:
        ret = dsi_short_read1_resp(buf, msg);
        break;

Regards

David Binderman

 		 	   		  
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel

      reply	other threads:[~2015-04-29 15:43 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-04-27  5:58 linux-4.1-rc1/drivers/gpu/drm/msm/dsi/dsi_host.c:1799: possible missing break ? David Binderman
2015-04-29 15:43 ` Hai Li [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='084501d08293$48b9e490$da2dadb0$@codeaurora.org' \
    --to=hali@codeaurora.org \
    --cc=airlied@linux.ie \
    --cc=dcb314@hotmail.com \
    --cc=dri-devel@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.