From: Matthieu Baerts <matttbe@kernel.org>
To: Willem de Bruijn <willemdebruijn.kernel@gmail.com>,
netdev@vger.kernel.org
Cc: davem@davemloft.net, kuba@kernel.org, edumazet@google.com,
pabeni@redhat.com, sdf@fomichev.me,
linux-kselftest@vger.kernel.org,
Willem de Bruijn <willemb@google.com>
Subject: Re: [PATCH net] selftests/net: packetdrill: increase timing tolerance in debug mode
Date: Fri, 20 Sep 2024 00:03:11 +0200 [thread overview]
Message-ID: <0849977a-e772-4778-9130-c8ac0539bbdc@kernel.org> (raw)
In-Reply-To: <20240919124412.3014326-1-willemdebruijn.kernel@gmail.com>
Hi Willem,
On 19/09/2024 14:43, Willem de Bruijn wrote:
> From: Willem de Bruijn <willemb@google.com>
>
> Some packetdrill tests are flaky in debug mode. As discussed, increase
> tolerance.
Thank you for the patch!
> We have been doing this for debug builds outside ksft too.
>
> Previous setting was 10000. A manual 50 runs in virtme-ng showed two
> failures that needed 12000. To be on the safe side, Increase to 14000.
So far (in 3 runs), it looks like 14000 is enough. But I guess it is
still a bit too early to conclude that.
https://netdev.bots.linux.dev/contest.html?executor=vmksft-packetdrill-dbg
(Your patch has been introduced in the net-next-2024-09-19--15-00 branch.)
Personally, I would not be chocked if the tolerance was even 10x higher
to cope with this very slow environment where we care less about timing
I think. But if less works, that's good:
Acked-by: Matthieu Baerts (NGI0) <matttbe@kernel.org>
Just one question for later: in the GitHub repo, some tests set the
tolerance in the .pkt file, will it be OK for these tests? I guess yes,
because the max they set is 10k, but I just want to double-check.
(Note that it is now easier to spot other errors :) e.g.)
https://netdev-3.bots.linux.dev/vmksft-packetdrill-dbg/results/779660/22-tcp-zerocopy-epoll-exclusive-pkt/stdout
Cheers,
Matt
--
Sponsored by the NGI0 Core fund.
next prev parent reply other threads:[~2024-09-19 22:03 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-19 12:43 [PATCH net] selftests/net: packetdrill: increase timing tolerance in debug mode Willem de Bruijn
2024-09-19 13:55 ` Simon Horman
2024-09-19 21:04 ` Stanislav Fomichev
2024-09-26 9:03 ` Paolo Abeni
2024-09-19 22:03 ` Matthieu Baerts [this message]
2024-09-26 9:12 ` Matthieu Baerts
2024-09-26 9:28 ` Willem de Bruijn
2024-09-26 9:10 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0849977a-e772-4778-9130-c8ac0539bbdc@kernel.org \
--to=matttbe@kernel.org \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=kuba@kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=sdf@fomichev.me \
--cc=willemb@google.com \
--cc=willemdebruijn.kernel@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.