Re: [PATCH v2 1/1] uapi:io_uring.h: allow linux/time_types.h to be skipped

[Ammar Faizi <ammarfaizi2@gnuweeb.org>]

On 11/17/22 3:25 AM, Stefan Metzmacher wrote:
> diff --git a/include/uapi/linux/io_uring.h b/include/uapi/linux/io_uring.h
> index 551e75908f33..082020257f19 100644
> --- a/include/uapi/linux/io_uring.h
> +++ b/include/uapi/linux/io_uring.h
> @@ -10,7 +10,15 @@
>   
>   #include <linux/fs.h>
>   #include <linux/types.h>
> +/*
> + * this file is shared with liburing and that has to autodetect
> + * if linux/time_types.h is available or not, it can
> + * define UAPI_LINUX_IO_URING_H_SKIP_LINUX_TIME_TYPES_H
> + * if linux/time_types.h is not available
> + */
> +#ifndef UAPI_LINUX_IO_URING_H_SKIP_LINUX_TIME_TYPES_H
>   #include <linux/time_types.h>
> +#endif
>   
>   #ifdef __cplusplus
>   extern "C" {

I admit the v1 was a stupid mistake. Sorry for that. Now this change
should not have any effect on the kernel code.

Only apps that use io_uring.h and put:

   #define UAPI_LINUX_IO_URING_H_SKIP_LINUX_TIME_TYPES_H

before the #include will get the effect, which Stefan will do in
liburing once this one gets accepted.

Reviewed-by: Ammar Faizi <ammarfaizi2@gnuweeb.org>

-- 
Ammar Faizi