From mboxrd@z Thu Jan 1 00:00:00 1970 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Subject: [v1,1/4] ACPI / bus: Remove checks in acpi_get_match_data() From: Sinan Kaya Message-Id: <0858321da222e203fe71269df6b384b9@codeaurora.org> Date: Thu, 01 Feb 2018 07:58:07 -0500 To: Andy Shevchenko Cc: "Rafael J. Wysocki" , dmaengine , "Rafael J. Wysocki" , ACPI Devel Maling List , Sakari Ailus , Vinod Koul , dmaengine-owner@vger.kernel.org List-ID: T24gMjAxOC0wMi0wMSAwNzoyNCwgQW5keSBTaGV2Y2hlbmtvIHdyb3RlOgo+IE9uIFRodSwgMjAx OC0wMi0wMSBhdCAwODoyNyArMDEwMCwgUmFmYWVsIEouIFd5c29ja2kgd3JvdGU6Cj4+IE9uIFdl ZCwgSmFuIDMxLCAyMDE4IGF0IDExOjE3IFBNLCBTaW5hbiBLYXlhIDxva2F5YUBjb2RlYXVyb3Jh Lm9yZz4KPj4gd3JvdGU6Cj4+ID4gT24gMS8zMS8yMDE4IDQ6MjkgUE0sIEFuZHkgU2hldmNoZW5r byB3cm90ZToKPj4gPiA+IEFzIHdlbGwgYXMgaXRzIHNpYmxpbmcgb2ZfZGV2aWNlX2dldF9tYXRj aF9kYXRhKCkgaGFzIG5vIHN1Y2gKPj4gPiA+IGNoZWNrcywKPj4gPiA+IG5vIG5lZWQgdG8gZG8g aXQgaW4gYWNwaV9nZXRfbWF0Y2hfZGF0YSgpLgo+PiA+ID4KPj4gPiA+IEZpcnN0IG9mIGFsbCwg d2UgYXJlIG5vdCBzdXBwb3NlZCB0byBjYWxsIGZ3bm9kZSBBUEkgbGlrZSB0aGlzCj4+ID4gPiB3 aXRob3V0Cj4+ID4gPiBkcml2ZXIgYXR0YWNoZWQuCj4+ID4gPgo+PiA+ID4gU2Vjb25kLCBpZiBw dXJlIE9GIGRyaXZlciBjYWxscyB0aGlzIGZ1bmN0aW9uLCBpdCdzIHdlaXJkIHRvIGhhdmUKPj4g PiA+IEFDUEkKPj4gPiA+IGNvbXBhbmlvbiB3aXRob3V0IEFDUEkgSUQgaW4gdGhpcyBjYXNlLgo+ PiA+Cj4+ID4gV2UgdGFsa2VkIGFib3V0IHRoaXMgZHVyaW5nIHJldmlldy4KPj4gPgo+PiA+IG9m X21hdGNoX2RldmljZSgpIGRvZXMgYWxsIHRoZSBjaGVja2luZyBmb3IgdGhlIE9GIHBhcnQuIEFD UEkKPj4gPiBkb2Vzbid0IGhhdmUKPj4gPiBhbnkgY2hlY2tzLgo+PiAKPj4gWWVhaCwgdGhpcyBw YXRjaCBpcyBqdXN0IHBsYWluIGluY29ycmVjdCBBRkFJQ1MuCj4gCj4gSSBkb24ndCBzZWUgaG93 IGNoZWNrIGRldi0+ZHJpdmVyIGlzIGltcGxlbWVudGVkIG9uIE9GIHNpZGUgdGhlbgo+IAo+IAo+ IG9mX2RldmljZV9nZXRfbWF0Y2hfZGF0YSgpIHdoaWNoIGlzIGNhbGxlZCBieQo+IG9mX2Z3bm9k ZV9kZXZpY2VfZ2V0X21hdGNoX2RhdGEoKSBoYXMgZGVyZWZlcmVuY2VkIGRldi0+ZHJpdmVyIHcv byBhbnkKPiBjaGVjay4KPiAKPiBJIGNhbid0IGFncmVlIHRoYXQgdGhlIHBhdGNoIGlzIHBsYWlu IGluY29ycmVjdCwgaWYgSSBkaWRuJ3QgbWlzcwo+IGFueXRoaW5nLgoKClNvcnJ5LCBpIHNob3Vs ZCBoYXZlIGJlZW4gbW9yZSBzcGVjaWZpYy4gSSB3YXMgdGFsa2ltZyBhYm91dCBtYXRjaF9kYXRh IApub3QgZHJpdmVyLgoKSSBhZ3JlZSB0aGF0IGRyaXZlciBjaGVjayBpcyByZWR1bmRhbnQuCi0t LQpUbyB1bnN1YnNjcmliZSBmcm9tIHRoaXMgbGlzdDogc2VuZCB0aGUgbGluZSAidW5zdWJzY3Jp YmUgZG1hZW5naW5lIiBpbgp0aGUgYm9keSBvZiBhIG1lc3NhZ2UgdG8gbWFqb3Jkb21vQHZnZXIu a2VybmVsLm9yZwpNb3JlIG1ham9yZG9tbyBpbmZvIGF0ICBodHRwOi8vdmdlci5rZXJuZWwub3Jn L21ham9yZG9tby1pbmZvLmh0bWwK From mboxrd@z Thu Jan 1 00:00:00 1970 From: okaya@codeaurora.org Subject: Re: [PATCH v1 1/4] ACPI / bus: Remove checks in acpi_get_match_data() Date: Thu, 01 Feb 2018 07:58:07 -0500 Message-ID: <0858321da222e203fe71269df6b384b9@codeaurora.org> References: <20180131212959.68766-1-andriy.shevchenko@linux.intel.com> <1517487893.7000.1372.camel@linux.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit Return-path: Received: from smtp.codeaurora.org ([198.145.29.96]:43282 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752282AbeBAM6I (ORCPT ); Thu, 1 Feb 2018 07:58:08 -0500 In-Reply-To: <1517487893.7000.1372.camel@linux.intel.com> Sender: linux-acpi-owner@vger.kernel.org List-Id: linux-acpi@vger.kernel.org To: Andy Shevchenko Cc: "Rafael J. Wysocki" , dmaengine , "Rafael J. Wysocki" , ACPI Devel Maling List , Sakari Ailus , Vinod Koul , dmaengine-owner@vger.kernel.org On 2018-02-01 07:24, Andy Shevchenko wrote: > On Thu, 2018-02-01 at 08:27 +0100, Rafael J. Wysocki wrote: >> On Wed, Jan 31, 2018 at 11:17 PM, Sinan Kaya >> wrote: >> > On 1/31/2018 4:29 PM, Andy Shevchenko wrote: >> > > As well as its sibling of_device_get_match_data() has no such >> > > checks, >> > > no need to do it in acpi_get_match_data(). >> > > >> > > First of all, we are not supposed to call fwnode API like this >> > > without >> > > driver attached. >> > > >> > > Second, if pure OF driver calls this function, it's weird to have >> > > ACPI >> > > companion without ACPI ID in this case. >> > >> > We talked about this during review. >> > >> > of_match_device() does all the checking for the OF part. ACPI >> > doesn't have >> > any checks. >> >> Yeah, this patch is just plain incorrect AFAICS. > > I don't see how check dev->driver is implemented on OF side then > > > of_device_get_match_data() which is called by > of_fwnode_device_get_match_data() has dereferenced dev->driver w/o any > check. > > I can't agree that the patch is plain incorrect, if I didn't miss > anything. Sorry, i should have been more specific. I was talkimg about match_data not driver. I agree that driver check is redundant.