From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 91F8BC28B23 for ; Thu, 6 Mar 2025 14:26:14 +0000 (UTC) Received: from list by lists.xenproject.org with outflank-mailman.903616.1311573 (Exim 4.92) (envelope-from ) id 1tqCAn-0002dA-2N; Thu, 06 Mar 2025 14:26:05 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 903616.1311573; Thu, 06 Mar 2025 14:26:05 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1tqCAm-0002d3-VV; Thu, 06 Mar 2025 14:26:04 +0000 Received: by outflank-mailman (input) for mailman id 903616; Thu, 06 Mar 2025 14:26:04 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1tqCAm-0002cx-KL for xen-devel@lists.xenproject.org; Thu, 06 Mar 2025 14:26:04 +0000 Received: from mail-wm1-x329.google.com (mail-wm1-x329.google.com [2a00:1450:4864:20::329]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id ee6b72e2-fa96-11ef-9898-31a8f345e629; Thu, 06 Mar 2025 15:26:02 +0100 (CET) Received: by mail-wm1-x329.google.com with SMTP id 5b1f17b1804b1-43948021a45so6544835e9.1 for ; Thu, 06 Mar 2025 06:26:02 -0800 (PST) Received: from [10.156.60.236] (ip-037-024-206-209.um08.pools.vodafone-ip.de. [37.24.206.209]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-43bd41c7cc7sm54775005e9.0.2025.03.06.06.26.01 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 06 Mar 2025 06:26:01 -0800 (PST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: ee6b72e2-fa96-11ef-9898-31a8f345e629 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1741271162; x=1741875962; darn=lists.xenproject.org; h=content-transfer-encoding:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to; bh=esWI7dOAhdBwgABK7TD6m1EdJ5p7fIMpwh7jYkHhM64=; b=LZjSAPlqpEwKb9wPw+ft2jWemimVqg3wDAwb3fajuqe3Qro7eLkIWlOG5C/KuP+I+G qIoUc2hCu3giZpltV6BO6Imu98LpMrJmEnO9A2SOvmT9ml3cXTGubaIx9QUBnHEaVpgN fZmjYeNfaqknPK96HSRB2MkHW24DJYFYJey0ijmKLSeQC46sdc0603gFttmXGlQ6k677 bmNv2fBjiBvSRLTk1VKDmgFJQbnikeTzmslIoV9nb80afbqKpvYeKCmmmzlMdIOg3mV6 3/41njGrvLpR7B7Fr9z8iDRrstpiOdx14GPTao46lBcPQDu6qCoTN/UZCmYy1Yo0Ppbl o58g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1741271162; x=1741875962; h=content-transfer-encoding:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=esWI7dOAhdBwgABK7TD6m1EdJ5p7fIMpwh7jYkHhM64=; b=iYFUGyddoSlwNx89aDHdIihah5ky2CL96BFRqftq5h/8HXg+7Go/0N2cBi3aYN588y 8zdqkpJmHJXw7aUJgGU4E6gkjZOlbtytRgEmBUHf437qjDb/2Zuta9YDe8iAObohMRsL iwaXALUml8CcdADyEr1UC2EXRUMAE7zmHV5hAA6MW6/FHs8Dk0MbdNDnJPlOl7HEvxzZ lSPl4xx+wceBcgfMNUUaZvgVcdpzz9/G7Khu6nv/oaDXVQ/jAlHf2xSK4ANejqIvGHl0 KK4XgN5KqkHacA25Sk3g/ZWXzVpX1VpTr2vb8wTBCIwe0L1M7ZJxheWvGzwNNmijN12A xATA== X-Gm-Message-State: AOJu0YwlxJwQGiVUuZNzqTgn99NX/pjWy0D1Hp9ySHl3319Hmf/9uO7E MRPZ5tbLNjOdlpp0ECDawMOnDt7wqG1QgOwu7BOwVeU6NXVgtjxAUvwYQ2cHSg== X-Gm-Gg: ASbGncsM0hCtoTr8Aq+kRSHwHLg9IPK1fyYOzs04MHorbpxm39vOGegUGS6ArQTP6Md 94j3g/VNI5MKUT9l7gvBwwyc9+NVelyIRTasTEr9Ct+MTaejG5ikWdLpBWQ0y2RXIv4Gkx+bDhR c0oEIvcKYeP0N/cKcak6Jpspz4J8olz0YQbVGgWdQquwbhGIR604oxLNJiJdKPrd1qtyyZRt9Fx em1tzQ4W5HuPQJTxTU+uYT25yk4bPjgKTZBERT1fL7r5NNpOM51CUkv8t/moADdLkobzrjWYfSb VzUHP5x3VYKpME1tJeLhoz9MQ9uWCMh/hr0p21j8TcRG8vgW/r3ySs99XA2S2lqrD6N/NH2jIZH jQVB9BzfGO3nqbUnqtf+r0EfbX1O+xg== X-Google-Smtp-Source: AGHT+IHX85HfEKx6FkOyVUdQKyns2H4dQTnt6kCUbbW6QNSt5FIPGu+I3A5yLoiUV9/K3OBf3G6ITg== X-Received: by 2002:a05:600c:458a:b0:439:5da7:8e0 with SMTP id 5b1f17b1804b1-43bd2992d20mr76250395e9.16.1741271161775; Thu, 06 Mar 2025 06:26:01 -0800 (PST) Message-ID: <086f7e05-2cab-4a53-8ecb-dff7421e38bc@suse.com> Date: Thu, 6 Mar 2025 15:26:00 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v6] Avoid crash calling PrintErrMesg from efi_multiboot2 To: =?UTF-8?Q?Marek_Marczykowski-G=C3=B3recki?= , Frediano Ziglio Cc: xen-devel@lists.xenproject.org, "Daniel P. Smith" References: <20250217162659.151232-1-frediano.ziglio@cloud.com> Content-Language: en-US From: Jan Beulich Autocrypt: addr=jbeulich@suse.com; keydata= xsDiBFk3nEQRBADAEaSw6zC/EJkiwGPXbWtPxl2xCdSoeepS07jW8UgcHNurfHvUzogEq5xk hu507c3BarVjyWCJOylMNR98Yd8VqD9UfmX0Hb8/BrA+Hl6/DB/eqGptrf4BSRwcZQM32aZK 7Pj2XbGWIUrZrd70x1eAP9QE3P79Y2oLrsCgbZJfEwCgvz9JjGmQqQkRiTVzlZVCJYcyGGsD /0tbFCzD2h20ahe8rC1gbb3K3qk+LpBtvjBu1RY9drYk0NymiGbJWZgab6t1jM7sk2vuf0Py O9Hf9XBmK0uE9IgMaiCpc32XV9oASz6UJebwkX+zF2jG5I1BfnO9g7KlotcA/v5ClMjgo6Gl MDY4HxoSRu3i1cqqSDtVlt+AOVBJBACrZcnHAUSuCXBPy0jOlBhxPqRWv6ND4c9PH1xjQ3NP nxJuMBS8rnNg22uyfAgmBKNLpLgAGVRMZGaGoJObGf72s6TeIqKJo/LtggAS9qAUiuKVnygo 3wjfkS9A3DRO+SpU7JqWdsveeIQyeyEJ/8PTowmSQLakF+3fote9ybzd880fSmFuIEJldWxp Y2ggPGpiZXVsaWNoQHN1c2UuY29tPsJgBBMRAgAgBQJZN5xEAhsDBgsJCAcDAgQVAggDBBYC AwECHgECF4AACgkQoDSui/t3IH4J+wCfQ5jHdEjCRHj23O/5ttg9r9OIruwAn3103WUITZee e7Sbg12UgcQ5lv7SzsFNBFk3nEQQCACCuTjCjFOUdi5Nm244F+78kLghRcin/awv+IrTcIWF hUpSs1Y91iQQ7KItirz5uwCPlwejSJDQJLIS+QtJHaXDXeV6NI0Uef1hP20+y8qydDiVkv6l IreXjTb7DvksRgJNvCkWtYnlS3mYvQ9NzS9PhyALWbXnH6sIJd2O9lKS1Mrfq+y0IXCP10eS FFGg+Av3IQeFatkJAyju0PPthyTqxSI4lZYuJVPknzgaeuJv/2NccrPvmeDg6Coe7ZIeQ8Yj t0ARxu2xytAkkLCel1Lz1WLmwLstV30g80nkgZf/wr+/BXJW/oIvRlonUkxv+IbBM3dX2OV8 AmRv1ySWPTP7AAMFB/9PQK/VtlNUJvg8GXj9ootzrteGfVZVVT4XBJkfwBcpC/XcPzldjv+3 HYudvpdNK3lLujXeA5fLOH+Z/G9WBc5pFVSMocI71I8bT8lIAzreg0WvkWg5V2WZsUMlnDL9 mpwIGFhlbM3gfDMs7MPMu8YQRFVdUvtSpaAs8OFfGQ0ia3LGZcjA6Ik2+xcqscEJzNH+qh8V m5jjp28yZgaqTaRbg3M/+MTbMpicpZuqF4rnB0AQD12/3BNWDR6bmh+EkYSMcEIpQmBM51qM EKYTQGybRCjpnKHGOxG0rfFY1085mBDZCH5Kx0cl0HVJuQKC+dV2ZY5AqjcKwAxpE75MLFkr wkkEGBECAAkFAlk3nEQCGwwACgkQoDSui/t3IH7nnwCfcJWUDUFKdCsBH/E5d+0ZnMQi+G0A nAuWpQkjM1ASeQwSHEeAWPgskBQL In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit On 26.02.2025 19:54, Marek Marczykowski-Górecki wrote: > On Mon, Feb 24, 2025 at 02:31:00PM +0000, Frediano Ziglio wrote: >> On Mon, Feb 24, 2025 at 1:16 PM Marek Marczykowski-Górecki >> wrote: >>> >>> On Mon, Feb 24, 2025 at 12:57:13PM +0000, Frediano Ziglio wrote: >>>> On Fri, Feb 21, 2025 at 8:20 PM Marek Marczykowski-Górecki >>>> wrote: >>>>> >>>>> On Mon, Feb 17, 2025 at 04:26:59PM +0000, Frediano Ziglio wrote: >>>>>> Although code is compiled with -fpic option data is not position >>>>>> independent. This causes data pointer to become invalid if >>>>>> code is not relocated properly which is what happens for >>>>>> efi_multiboot2 which is called by multiboot entry code. >>>>>> >>>>>> Code tested adding >>>>>> PrintErrMesg(L"Test message", EFI_BUFFER_TOO_SMALL); >>>>>> in efi_multiboot2 before calling efi_arch_edd (this function >>>>>> can potentially call PrintErrMesg). >>>>>> >>>>>> Before the patch (XenServer installation on Qemu, xen replaced >>>>>> with vanilla xen.gz): >>>>>> Booting `XenServer (Serial)'Booting `XenServer (Serial)' >>>>>> Test message: !!!! X64 Exception Type - 0E(#PF - Page-Fault) CPU Apic ID - 00000000 !!!! >>>>>> ExceptionData - 0000000000000000 I:0 R:0 U:0 W:0 P:0 PK:0 SS:0 SGX:0 >>>>>> RIP - 000000007EE21E9A, CS - 0000000000000038, RFLAGS - 0000000000210246 >>>>>> RAX - 000000007FF0C1B5, RCX - 0000000000000050, RDX - 0000000000000010 >>>>>> RBX - 0000000000000000, RSP - 000000007FF0C180, RBP - 000000007FF0C210 >>>>>> RSI - FFFF82D040467CE8, RDI - 0000000000000000 >>>>>> R8 - 000000007FF0C1C8, R9 - 000000007FF0C1C0, R10 - 0000000000000000 >>>>>> R11 - 0000000000001020, R12 - FFFF82D040467CE8, R13 - 000000007FF0C1B8 >>>>>> R14 - 000000007EA33328, R15 - 000000007EA332D8 >>>>>> DS - 0000000000000030, ES - 0000000000000030, FS - 0000000000000030 >>>>>> GS - 0000000000000030, SS - 0000000000000030 >>>>>> CR0 - 0000000080010033, CR2 - FFFF82D040467CE8, CR3 - 000000007FC01000 >>>>>> CR4 - 0000000000000668, CR8 - 0000000000000000 >>>>>> DR0 - 0000000000000000, DR1 - 0000000000000000, DR2 - 0000000000000000 >>>>>> DR3 - 0000000000000000, DR6 - 00000000FFFF0FF0, DR7 - 0000000000000400 >>>>>> GDTR - 000000007F9DB000 0000000000000047, LDTR - 0000000000000000 >>>>>> IDTR - 000000007F48E018 0000000000000FFF, TR - 0000000000000000 >>>>>> FXSAVE_STATE - 000000007FF0BDE0 >>>>>> !!!! Find image based on IP(0x7EE21E9A) (No PDB) (ImageBase=000000007EE20000, EntryPoint=000000007EE23935) !!!! >>>>>> >>>>>> After the patch: >>>>>> Booting `XenServer (Serial)'Booting `XenServer (Serial)' >>>>>> Test message: Buffer too small >>>>>> BdsDxe: loading Boot0000 "UiApp" from Fv(7CB8BDC9-F8EB-4F34-AAEA-3EE4AF6516A1)/FvFile(462CAA21-7614-4503-836E-8AB6F4662331) >>>>>> BdsDxe: starting Boot0000 "UiApp" from Fv(7CB8BDC9-F8EB-4F34-AAEA-3EE4AF6516A1)/FvFile(462CAA21-7614-4503-836E-8AB6F4662331) >>>>>> >>>>>> This partially rollback commit 00d5d5ce23e6. >>>>>> >>>>>> Fixes: 9180f5365524 ("x86: add multiboot2 protocol support for EFI platforms") >>>>>> Signed-off-by: Frediano Ziglio >>>>> >>>>> I tried testing this patch, but it seems I cannot reproduce the original >>>>> failure... >>>>> >>>>> I did as the commit message suggests here: >>>>> https://gitlab.com/xen-project/people/marmarek/xen/-/commit/ca3d6911c448eb886990f33d4380b5646617a982 >>>>> >>>>> With blexit() in PrintErrMesg(), it went back to the bootloader, so I'm >>>>> sure this code path was reached. But with blexit() commented out, Xen >>>>> started correctly both with and without this patch... The branch I used >>>>> is here: >>>>> https://gitlab.com/xen-project/people/marmarek/xen/-/commits/automation-tests?ref_type=heads >>>>> >>>>> Are there some extra condition to reproduce the issue? Maybe it depends >>>>> on the compiler version? I guess I can try also on QEMU, but based on >>>>> the description, I would expect it to crash in any case. >>>>> >>>> >>>> Did you see the correct message in both cases? >>>> Did you use Grub or direct EFI? >>>> >>>> With Grub and without this patch you won't see the message, with grub >>>> with the patch you see the correct message. >>> >>> I did use grub, and I didn't see the message indeed. >>> But in the case it was supposed to crash (with added PrintErrMesg(), >>> commented out blexit and without your patch) it did _not_ crashed and >>> continued to normal boot. Is that #PF non-fatal here? >>> >> >> Hi, >> I tried again with my test environment. >> Added the PrintErrMesg line before efi_arch_edd call, I got a #PF, in >> my case the system hangs. With the fix patch machine is rebooting and >> I can see the message in the logs. >> I'm trying with Xen starting inside Qemu, EFI firmware, xen.gz >> compiled as ELF file. Host system is an Ubuntu 22.04.5 LTS. Gcc is >> version 11.4. > > My test was wrong, commenting out blexit made "mesg" variable unused. > After fixing that, I can reproduce it on both QEMU and real hardware: > without your patch it crashes and with your patch it works just fine. > While there may be more places with similar issue, this patch clearly > improves the situation, so: > > Acked-by: Marek Marczykowski-Górecki This had to be reverted, for breaking the build with old Clang. See the respective Matrix conversation. Jan