All of lore.kernel.org
 help / color / mirror / Atom feed
From: Matthew Rosato <mjrosato@linux.ibm.com>
To: "Eric Farman" <farman@linux.ibm.com>,
	"Richard Henderson" <richard.henderson@linaro.org>,
	"Philippe Mathieu-Daudé" <philmd@oss.qualcomm.com>
Cc: qemu-devel@nongnu.org, qemu-s390x@nongnu.org
Subject: Re: [PATCH] disas: Replace straggling CS_ARCH_SYSZ
Date: Mon, 24 Aug 2026 15:19:39 -0400	[thread overview]
Message-ID: <0875272c-0095-47bc-b7d2-d5793f270816@linux.ibm.com> (raw)
In-Reply-To: <20260824143033.306201-1-farman@linux.ibm.com>

On 8/24/26 10:30 AM, Eric Farman wrote:
> When updating to capstone v6, the define CS_ARCH_SYSZ was replaced
> with CS_ARCH_SYSTEMZ, except here. On systems without capstone-devel
> installed, this causes a compile error:
> 
>   ../disas/disas-host.c: In function ‘initialize_debug_host’:
>   ../disas/disas-host.c:78:24: error: ‘CS_ARCH_SYSZ’ undeclared (first use in this function); did you mean ‘CS_ARCH_SH’?
>      78 |     s->info.cap_arch = CS_ARCH_SYSZ;
>         |                        ^~~~~~~~~~~~
>         |                        CS_ARCH_SH
>   ../disas/disas-host.c:78:24: note: each undeclared identifier is reported only once for each function it appears in
> 
> Rather than making capstone required, replace the constant
> with the same one used elsewhere after that change.
> 
> Fixes: c8220a096f ("target/s390x: Update capstone disassembly to v6")
> Signed-off-by: Eric Farman <farman@linux.ibm.com>

Thanks Eric, I just noticed the same compile error and this resolved it
for me.

Reviewed-by: Matthew Rosato <mjrosato@linux.ibm.com>



  reply	other threads:[~2026-08-24 19:20 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-08-24 14:30 [PATCH] disas: Replace straggling CS_ARCH_SYSZ Eric Farman
2026-08-24 19:19 ` Matthew Rosato [this message]
2026-08-24 21:33 ` Philippe Mathieu-Daudé
2026-08-25 15:53 ` Richard Henderson
2026-08-26 17:20   ` Richard Henderson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=0875272c-0095-47bc-b7d2-d5793f270816@linux.ibm.com \
    --to=mjrosato@linux.ibm.com \
    --cc=farman@linux.ibm.com \
    --cc=philmd@oss.qualcomm.com \
    --cc=qemu-devel@nongnu.org \
    --cc=qemu-s390x@nongnu.org \
    --cc=richard.henderson@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.