diff for duplicates of <087710e9-2aeb-c070-cebb-82ae9cb5c20e@linux.dev> diff --git a/a/1.txt b/N1/1.txt index d8b2e55..aadf9bc 100644 --- a/a/1.txt +++ b/N1/1.txt @@ -1,9 +1,9 @@ -? 2021/10/18 21:44, Paul Menzel ??: +在 2021/10/18 21:44, Paul Menzel 写道: > Dear Yanjun, > > -> Am 18.10.21 um 15:17 schrieb yanjun.zhu at linux.dev: +> Am 18.10.21 um 15:17 schrieb yanjun.zhu@linux.dev: >> From: Zhu Yanjun <yanjun.zhu@linux.dev> >> >> The function ice_aq_nvm_update_empr is not used, so remove it. @@ -14,7 +14,7 @@ >> ice: Remove unused `ice_aq_nvm_update_empr()` > > If you find out, what commit removed the usage, that would be also -> good to document, but it?s not that important. +> good to document, but it’s not that important. Thanks for your suggestion. @@ -41,9 +41,9 @@ Zhu Yanjun > >> Signed-off-by: Zhu Yanjun <yanjun.zhu@linux.dev> >> --- ->> ? drivers/net/ethernet/intel/ice/ice_nvm.c | 16 ---------------- ->> ? drivers/net/ethernet/intel/ice/ice_nvm.h |? 1 - ->> ? 2 files changed, 17 deletions(-) +>> drivers/net/ethernet/intel/ice/ice_nvm.c | 16 ---------------- +>> drivers/net/ethernet/intel/ice/ice_nvm.h | 1 - +>> 2 files changed, 17 deletions(-) >> >> diff --git a/drivers/net/ethernet/intel/ice/ice_nvm.c >> b/drivers/net/ethernet/intel/ice/ice_nvm.c @@ -52,9 +52,9 @@ Zhu Yanjun >> +++ b/drivers/net/ethernet/intel/ice/ice_nvm.c >> @@ -1106,22 +1106,6 @@ enum ice_status ice_nvm_write_activate(struct >> ice_hw *hw, u8 cmd_flags) ->> ????? return ice_aq_send_cmd(hw, &desc, NULL, 0, NULL); ->> ? } ->> ? -/** +>> return ice_aq_send_cmd(hw, &desc, NULL, 0, NULL); +>> } +>> -/** >> - * ice_aq_nvm_update_empr >> - * @hw: pointer to the HW struct >> - * @@ -63,30 +63,30 @@ Zhu Yanjun >> - */ >> -enum ice_status ice_aq_nvm_update_empr(struct ice_hw *hw) >> -{ ->> -??? struct ice_aq_desc desc; +>> - struct ice_aq_desc desc; >> - ->> -??? ice_fill_dflt_direct_cmd_desc(&desc, ice_aqc_opc_nvm_update_empr); +>> - ice_fill_dflt_direct_cmd_desc(&desc, ice_aqc_opc_nvm_update_empr); >> - ->> -??? return ice_aq_send_cmd(hw, &desc, NULL, 0, NULL); +>> - return ice_aq_send_cmd(hw, &desc, NULL, 0, NULL); >> -} >> - ->> ? /* ice_nvm_set_pkg_data ->> ?? * @hw: pointer to the HW struct ->> ?? * @del_pkg_data_flag: If is set then the current pkg_data store by FW +>> /* ice_nvm_set_pkg_data +>> * @hw: pointer to the HW struct +>> * @del_pkg_data_flag: If is set then the current pkg_data store by FW >> diff --git a/drivers/net/ethernet/intel/ice/ice_nvm.h >> b/drivers/net/ethernet/intel/ice/ice_nvm.h >> index c6f05f43d593..925225905491 100644 >> --- a/drivers/net/ethernet/intel/ice/ice_nvm.h >> +++ b/drivers/net/ethernet/intel/ice/ice_nvm.h >> @@ -39,7 +39,6 @@ enum ice_status ->> ? ice_aq_erase_nvm(struct ice_hw *hw, u16 module_typeid, struct +>> ice_aq_erase_nvm(struct ice_hw *hw, u16 module_typeid, struct >> ice_sq_cd *cd); ->> ? enum ice_status ice_nvm_validate_checksum(struct ice_hw *hw); ->> ? enum ice_status ice_nvm_write_activate(struct ice_hw *hw, u8 +>> enum ice_status ice_nvm_validate_checksum(struct ice_hw *hw); +>> enum ice_status ice_nvm_write_activate(struct ice_hw *hw, u8 >> cmd_flags); >> -enum ice_status ice_aq_nvm_update_empr(struct ice_hw *hw); ->> ? enum ice_status ->> ? ice_nvm_set_pkg_data(struct ice_hw *hw, bool del_pkg_data_flag, u8 +>> enum ice_status +>> ice_nvm_set_pkg_data(struct ice_hw *hw, bool del_pkg_data_flag, u8 >> *data, ->> ?????????????? u16 length, struct ice_sq_cd *cd); +>> u16 length, struct ice_sq_cd *cd); >> diff --git a/a/content_digest b/N1/content_digest index a46c184..a5fa2a3 100644 --- a/a/content_digest +++ b/N1/content_digest @@ -1,17 +1,23 @@ "ref\020211018131713.3478-1-yanjun.zhu@linux.dev\0" "ref\0c1903730-9508-1fef-4232-3a5b62f28d7c@molgen.mpg.de\0" "From\0Yanjun Zhu <yanjun.zhu@linux.dev>\0" - "Subject\0[Intel-wired-lan] [PATCH 1/1] ice: compact the file ice_nvm.c\0" + "Subject\0Re: [Intel-wired-lan] [PATCH 1/1] ice: compact the file ice_nvm.c\0" "Date\0Mon, 18 Oct 2021 22:00:05 +0800\0" - "To\0intel-wired-lan@osuosl.org\0" + "To\0Paul Menzel <pmenzel@molgen.mpg.de>\0" + "Cc\0jesse.brandeburg@intel.com" + anthony.l.nguyen@intel.com + davem@davemloft.net + kuba@kernel.org + intel-wired-lan@lists.osuosl.org + " netdev@vger.kernel.org\0" "\00:1\0" "b\0" "\n" - "? 2021/10/18 21:44, Paul Menzel ??:\n" + "\345\234\250 2021/10/18 21:44, Paul Menzel \345\206\231\351\201\223:\n" "> Dear Yanjun,\n" ">\n" ">\n" - "> Am 18.10.21 um 15:17 schrieb yanjun.zhu at linux.dev:\n" + "> Am 18.10.21 um 15:17 schrieb yanjun.zhu@linux.dev:\n" ">> From: Zhu Yanjun <yanjun.zhu@linux.dev>\n" ">>\n" ">> The function ice_aq_nvm_update_empr is not used, so remove it.\n" @@ -22,7 +28,7 @@ ">> ice: Remove unused `ice_aq_nvm_update_empr()`\n" ">\n" "> If you find out, what commit removed the usage, that would be also \n" - "> good to document, but it?s not that important.\n" + "> good to document, but it\342\200\231s not that important.\n" "\n" "\n" "Thanks for your suggestion.\n" @@ -49,9 +55,9 @@ ">\n" ">> Signed-off-by: Zhu Yanjun <yanjun.zhu@linux.dev>\n" ">> ---\n" - ">> ? drivers/net/ethernet/intel/ice/ice_nvm.c | 16 ----------------\n" - ">> ? drivers/net/ethernet/intel/ice/ice_nvm.h |? 1 -\n" - ">> ? 2 files changed, 17 deletions(-)\n" + ">> \302\240 drivers/net/ethernet/intel/ice/ice_nvm.c | 16 ----------------\n" + ">> \302\240 drivers/net/ethernet/intel/ice/ice_nvm.h |\302\240 1 -\n" + ">> \302\240 2 files changed, 17 deletions(-)\n" ">>\n" ">> diff --git a/drivers/net/ethernet/intel/ice/ice_nvm.c \n" ">> b/drivers/net/ethernet/intel/ice/ice_nvm.c\n" @@ -60,9 +66,9 @@ ">> +++ b/drivers/net/ethernet/intel/ice/ice_nvm.c\n" ">> @@ -1106,22 +1106,6 @@ enum ice_status ice_nvm_write_activate(struct \n" ">> ice_hw *hw, u8 cmd_flags)\n" - ">> ????? return ice_aq_send_cmd(hw, &desc, NULL, 0, NULL);\n" - ">> ? }\n" - ">> ? -/**\n" + ">> \302\240\302\240\302\240\302\240\302\240 return ice_aq_send_cmd(hw, &desc, NULL, 0, NULL);\n" + ">> \302\240 }\n" + ">> \302\240 -/**\n" ">> - * ice_aq_nvm_update_empr\n" ">> - * @hw: pointer to the HW struct\n" ">> - *\n" @@ -71,32 +77,32 @@ ">> - */\n" ">> -enum ice_status ice_aq_nvm_update_empr(struct ice_hw *hw)\n" ">> -{\n" - ">> -??? struct ice_aq_desc desc;\n" + ">> -\302\240\302\240\302\240 struct ice_aq_desc desc;\n" ">> -\n" - ">> -??? ice_fill_dflt_direct_cmd_desc(&desc, ice_aqc_opc_nvm_update_empr);\n" + ">> -\302\240\302\240\302\240 ice_fill_dflt_direct_cmd_desc(&desc, ice_aqc_opc_nvm_update_empr);\n" ">> -\n" - ">> -??? return ice_aq_send_cmd(hw, &desc, NULL, 0, NULL);\n" + ">> -\302\240\302\240\302\240 return ice_aq_send_cmd(hw, &desc, NULL, 0, NULL);\n" ">> -}\n" ">> -\n" - ">> ? /* ice_nvm_set_pkg_data\n" - ">> ?? * @hw: pointer to the HW struct\n" - ">> ?? * @del_pkg_data_flag: If is set then the current pkg_data store by FW\n" + ">> \302\240 /* ice_nvm_set_pkg_data\n" + ">> \302\240\302\240 * @hw: pointer to the HW struct\n" + ">> \302\240\302\240 * @del_pkg_data_flag: If is set then the current pkg_data store by FW\n" ">> diff --git a/drivers/net/ethernet/intel/ice/ice_nvm.h \n" ">> b/drivers/net/ethernet/intel/ice/ice_nvm.h\n" ">> index c6f05f43d593..925225905491 100644\n" ">> --- a/drivers/net/ethernet/intel/ice/ice_nvm.h\n" ">> +++ b/drivers/net/ethernet/intel/ice/ice_nvm.h\n" ">> @@ -39,7 +39,6 @@ enum ice_status\n" - ">> ? ice_aq_erase_nvm(struct ice_hw *hw, u16 module_typeid, struct \n" + ">> \302\240 ice_aq_erase_nvm(struct ice_hw *hw, u16 module_typeid, struct \n" ">> ice_sq_cd *cd);\n" - ">> ? enum ice_status ice_nvm_validate_checksum(struct ice_hw *hw);\n" - ">> ? enum ice_status ice_nvm_write_activate(struct ice_hw *hw, u8 \n" + ">> \302\240 enum ice_status ice_nvm_validate_checksum(struct ice_hw *hw);\n" + ">> \302\240 enum ice_status ice_nvm_write_activate(struct ice_hw *hw, u8 \n" ">> cmd_flags);\n" ">> -enum ice_status ice_aq_nvm_update_empr(struct ice_hw *hw);\n" - ">> ? enum ice_status\n" - ">> ? ice_nvm_set_pkg_data(struct ice_hw *hw, bool del_pkg_data_flag, u8 \n" + ">> \302\240 enum ice_status\n" + ">> \302\240 ice_nvm_set_pkg_data(struct ice_hw *hw, bool del_pkg_data_flag, u8 \n" ">> *data,\n" - ">> ?????????????? u16 length, struct ice_sq_cd *cd);\n" + ">> \302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240 u16 length, struct ice_sq_cd *cd);\n" >> -727e8ba3bb03ec2fa0041ac505d024e6c7fb4a0495b3a991e577bc8ebbd774a9 +ebfa19f98027c17da76caafd8e5cd1889ab3070901e945fd9dd30c776b682afd
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.