From: Krzysztof Kozlowski <krzk@kernel.org>
To: Wim de With <wf@dewith.io>
Cc: Lee Jones <lee@kernel.org>, Daniel Thompson <danielt@kernel.org>,
Jingoo Han <jingoohan1@gmail.com>,
Pavel Machek <pavel@kernel.org>, Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>, Helge Deller <deller@gmx.de>,
dri-devel@lists.freedesktop.org, linux-leds@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-fbdev@vger.kernel.org
Subject: Re: [PATCH v3 2/2] backlight: Add support for Orient Chip OCP8178
Date: Tue, 18 Aug 2026 10:21:32 +0200 [thread overview]
Message-ID: <087f9e9e-afd5-4073-b78d-4131f9b8e4c4@kernel.org> (raw)
In-Reply-To: <aoQVofK2EK6Tjsw8@dewith.io>
On 18/08/2026 10:19, Wim de With wrote:
> On Tue, Aug 18, 2026 at 09:34:14AM +0200, Krzysztof Kozlowski wrote:
>> On Sun, Aug 16, 2026 at 12:57:04PM +0200, Wim de With wrote:
>>> +static int ocp8178_bl_enable_onewire(struct ocp8178_bl *ocp8178)
>>> +{
>>> + u64 start, duration;
>>> +
>>
>> It seems you re-implemented one-wire interface instead of using w1. Why?
>> What sort of one-wire bus/interface is this?
>>
>> Best regards,
>> Krzysztof
>>
>
> It's not actually w1, it's just some non-standard protocol that the
> vendor confusingly calls '1-Wire' in the datasheet, to distinguish it
> from the PWM mode.
OK
Best regards,
Krzysztof
prev parent reply other threads:[~2026-08-18 8:21 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-16 10:57 [PATCH v3 0/2] backlight: Add support for Orient Chip OCP8178 Wim de With
2026-08-16 10:57 ` [PATCH v3 1/2] dt-bindings: backlight: Add " Wim de With
2026-08-16 11:04 ` sashiko-bot
2026-08-17 9:40 ` Daniel Thompson
2026-08-18 7:35 ` Krzysztof Kozlowski
2026-08-16 10:57 ` [PATCH v3 2/2] backlight: Add support for " Wim de With
2026-08-16 11:07 ` sashiko-bot
2026-08-18 7:34 ` Krzysztof Kozlowski
2026-08-18 8:19 ` Wim de With
2026-08-18 8:21 ` Krzysztof Kozlowski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=087f9e9e-afd5-4073-b78d-4131f9b8e4c4@kernel.org \
--to=krzk@kernel.org \
--cc=conor+dt@kernel.org \
--cc=danielt@kernel.org \
--cc=deller@gmx.de \
--cc=devicetree@vger.kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=jingoohan1@gmail.com \
--cc=krzk+dt@kernel.org \
--cc=lee@kernel.org \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=pavel@kernel.org \
--cc=robh@kernel.org \
--cc=wf@dewith.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.