From: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
To: Arnd Bergmann <arnd@arndb.de>,
Oder Chiou <oder_chiou@realtek.com>,
Mark Brown <broonie@kernel.org>
Cc: alsa-devel@alsa-project.org, kbuild test robot <lkp@intel.com>,
linux-kernel@vger.kernel.org, Liam Girdwood <lgirdwood@gmail.com>,
Takashi Iwai <tiwai@suse.com>,
Derek Fang <derek.fang@realtek.com>,
Shuming Fan <shumingf@realtek.com>
Subject: Re: [PATCH] ASoC: rt5682: fix building without I2C
Date: Wed, 8 Apr 2020 14:12:59 -0500 [thread overview]
Message-ID: <08b488ef-91bb-ab66-c2d8-16822f3bf152@linux.intel.com> (raw)
In-Reply-To: <20200408185527.308213-1-arnd@arndb.de>
On 4/8/20 1:55 PM, Arnd Bergmann wrote:
> When I2C is disabled, building rt5682 produces a compile-time error:
>
> sound/soc/codecs/rt5682.c:3716:1: warning: data definition has no type or storage class
> 3716 | module_i2c_driver(rt5682_i2c_driver);
> | ^~~~~~~~~~~~~~~~~
> sound/soc/codecs/rt5682.c:3716:1: error: type defaults to 'int' in declaration of 'module_i2c_driver' [-Werror=implicit-int]
> sound/soc/codecs/rt5682.c:3716:1: warning: parameter names (without types) in function declaration
> sound/soc/codecs/rt5682.c:3706:26: error: 'rt5682_i2c_driver' defined but not used [-Werror=unused-variable]
> 3706 | static struct i2c_driver rt5682_i2c_driver = {
> | ^~~~~~~~~~~~~~~~~
>
> Move the i2c specific entry points into an #ifdef section so
> it can actually be built standalone.
>
> Fixes: 5549ea647997 ("ASoC: rt5682: fix unmet dependencies")
it's already fixed by [PATCH -next] ASoC: rt5682: Fix build error
without CONFIG_I2C
prev parent reply other threads:[~2020-04-08 19:14 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-08 18:55 [PATCH] ASoC: rt5682: fix building without I2C Arnd Bergmann
2020-04-08 18:55 ` Arnd Bergmann
2020-04-08 19:12 ` Pierre-Louis Bossart [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=08b488ef-91bb-ab66-c2d8-16822f3bf152@linux.intel.com \
--to=pierre-louis.bossart@linux.intel.com \
--cc=alsa-devel@alsa-project.org \
--cc=arnd@arndb.de \
--cc=broonie@kernel.org \
--cc=derek.fang@realtek.com \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lkp@intel.com \
--cc=oder_chiou@realtek.com \
--cc=shumingf@realtek.com \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.