From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.3 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI, NICE_REPLY_A,PDS_TONAME_EQ_TOLOCAL_SHORT,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id AE550C433ED for ; Sun, 25 Apr 2021 01:03:49 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 6543761481 for ; Sun, 25 Apr 2021 01:03:49 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229771AbhDYBEX (ORCPT ); Sat, 24 Apr 2021 21:04:23 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38154 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229723AbhDYBEX (ORCPT ); Sat, 24 Apr 2021 21:04:23 -0400 Received: from mail-pf1-x42b.google.com (mail-pf1-x42b.google.com [IPv6:2607:f8b0:4864:20::42b]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8E620C061574; Sat, 24 Apr 2021 18:03:44 -0700 (PDT) Received: by mail-pf1-x42b.google.com with SMTP id d124so36557200pfa.13; Sat, 24 Apr 2021 18:03:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:references:from:message-id:date:user-agent:mime-version :in-reply-to:content-language:content-transfer-encoding; bh=ugzbtBPge5rlDTNTfzbBcRClDGR7j9CqrIsdICObdrM=; b=nekFe5aFcl3AsAs4+lPJj8kg8cxfTcm3hk3+XvFrQqxXDAGbpb1ExB1vBODPeYQRCG Fu90qg/zb4UWXGzrjESZtludDQ0EemkQrl+81LeZJ3ntLwJ9ZWmVAPH4XxxjnGIKNexw teWrUaCx2PWzYjCgjK+JKnnX0Ra1LPszmBpkL+XXDGQbXCA4qR6p9TjNTAd/XFq172dN DlzfLbpRF/ChjTLb/wrYhcs+aDusMlkexisJOY/7+GM+LZyMzKxyZtEj/954nRK1sD0d teR1T1uFCXe1zqfTl/JavocyxMYDQLqkayp6WK4WyCmqQk+NCIOln1OFTXUnusztsbSy g5qw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=ugzbtBPge5rlDTNTfzbBcRClDGR7j9CqrIsdICObdrM=; b=Sxe7lPsagaOlrGUfoqhfxN0vvHATfLuD4/iKz7hFisGN6GEN6Sj6TCRIa2iwMJV2HJ HmAm3V5KYyHKsSeXDUoiFPkH+VVG/AgUIIIKt7zS0PPO/m/03upGo782bW9RoAOYN0C0 5v8zkF5qmmms5PFlp0y82ORoXMWWIL8h1WUODi6PzTUZoGUFwyTpv/YdDLNpcuRLpqPH 5NIO0ZxzidDEhBPFZbfX810Lilj+GkXGBQhMcT9W0wUhq4OnHn90GZzxryqMvPTU2xjY hxBp7iDoPtKU0z5D3BXfzBRwGUgB5OIRKLQ0O7r/Yr/YT+z3QT7gIPlEMd5DfKnFqVmv t2mQ== X-Gm-Message-State: AOAM531muGBVBeaDRSnhgZGchJczaQ7wagyaUti5rsbxdlDD8pvZ8kn3 B0pfVC6vfzhMMMqk4Ua9f/EEFC9b7vQ= X-Google-Smtp-Source: ABdhPJzTPRFHgmYTvvrOCW3jpRJLrURZ5ZH8ucMaXZIrUdEbORjq/70lHGdB+u2ffSVrEoNAA3JPNQ== X-Received: by 2002:a65:5289:: with SMTP id y9mr10331524pgp.447.1619312623531; Sat, 24 Apr 2021 18:03:43 -0700 (PDT) Received: from [10.230.29.202] ([192.19.223.252]) by smtp.gmail.com with ESMTPSA id y18sm7685468pfp.121.2021.04.24.18.03.41 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 24 Apr 2021 18:03:42 -0700 (PDT) Subject: Re: [PATCH] MIPS: BCM63XX: Use BUG_ON instead of condition followed by BUG. To: zhouchuangao , Thomas Bogendoerfer , Florian Fainelli , bcm-kernel-feedback-list@broadcom.com, linux-mips@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org References: <1619279992-81335-1-git-send-email-zhouchuangao@vivo.com> From: Florian Fainelli Message-ID: <08bbb077-cfa3-69b8-e366-378f3c43a187@gmail.com> Date: Sat, 24 Apr 2021 18:03:41 -0700 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Firefox/78.0 Thunderbird/78.10.0 MIME-Version: 1.0 In-Reply-To: <1619279992-81335-1-git-send-email-zhouchuangao@vivo.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-mips@vger.kernel.org On 4/24/2021 8:59 AM, zhouchuangao wrote: > BUG_ON uses unlikely in if(), it can be optimized at compile time. > > Usually, the condition in if() is not satisfied. In my opinion, > this can improve the efficiency of the multi-stage pipeline. > > Signed-off-by: zhouchuangao Acked-by: Florian Fainelli -- Florian From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.2 required=3.0 tests=BAYES_00,DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED,DKIM_VALID,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI, NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A017BC433ED for ; Sun, 25 Apr 2021 01:06:30 +0000 (UTC) Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 1EFDF61422 for ; Sun, 25 Apr 2021 01:06:30 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 1EFDF61422 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=desiato.20200630; h=Sender:Content-Transfer-Encoding :Content-Type:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date:Message-ID:From: References:To:Subject:Reply-To:Cc:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=ttExao2MCgupCpobjHfECvp3DxNbd3kp/cpQ1sm3tTQ=; b=Ao1SlXMs2vgYHTxKx5agOL9cW +6FhNMrC8Spp6eoqPhPmuyqJ+KM13kVeBh06YQ7Pu13LiDmrB+F+ZVIQqzVdlhm3F8RwP3TGPlAhE 8y4eHu/rwm+WmGTW9O/kLDiNj9JXtW54DLyqkSAwuqgKgU7McSlA4KKoYgFT8WFp8LXRkKlLoZemP kDTGIh4y35L3DBEPdAFpdi+IQxNyoqG6kwwcbKZWEZsxcFPl2RAP+kJDFcfz89KZeCWsgz51v/p1t qbdseCgpASoH2rc4FbVD9a5xDnZmyabBZgmNNrT2xydotFLR7dKH7NV4zwc4qvzKpNwkxcdVb/7Yv nCR8n5NQA==; Received: from localhost ([::1] helo=desiato.infradead.org) by desiato.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1laTBn-004lAS-Tm; Sun, 25 Apr 2021 01:04:00 +0000 Received: from bombadil.infradead.org ([2607:7c80:54:e::133]) by desiato.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1laTBf-004lA0-39 for linux-arm-kernel@desiato.infradead.org; Sun, 25 Apr 2021 01:03:51 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=Content-Transfer-Encoding: Content-Type:In-Reply-To:MIME-Version:Date:Message-ID:From:References:To: Subject:Sender:Reply-To:Cc:Content-ID:Content-Description; bh=ugzbtBPge5rlDTNTfzbBcRClDGR7j9CqrIsdICObdrM=; b=dn2b9r9BXzCFTtV22MstSBpWPJ WcxjV1XalLq4XuSAMIYgpEehybD6Ar8cOVG60yr7h06GjI9Ooe8WWJ8d5+TKXmXgjhGiQzxpwKfJq Rm+LKkPyp970hjIyLsXLLXEpc4InQXjz2yYKtdhCQTkNBpJBnuhPtIqUAhPxNKgLSGnKQQbD6yLL6 E0OGVb0HqarN4s0qxbJjO+zqNAvElk4zmEC8q4FvRv3b6MJLCfT8pYmMHOthdYth4hXyfA/xjITMo lxCrTT0xb9eUZcYzw+eoaJaSSUXnHpiYNiFDvbeBv/1zlHJiczx/se9gaoLiJGMz7IDrPMEw+iZDr EwdVV5/Q==; Received: from mail-pf1-x434.google.com ([2607:f8b0:4864:20::434]) by bombadil.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1laTBb-00FDb6-KT for linux-arm-kernel@lists.infradead.org; Sun, 25 Apr 2021 01:03:48 +0000 Received: by mail-pf1-x434.google.com with SMTP id c17so1961531pfn.6 for ; Sat, 24 Apr 2021 18:03:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:references:from:message-id:date:user-agent:mime-version :in-reply-to:content-language:content-transfer-encoding; bh=ugzbtBPge5rlDTNTfzbBcRClDGR7j9CqrIsdICObdrM=; b=nekFe5aFcl3AsAs4+lPJj8kg8cxfTcm3hk3+XvFrQqxXDAGbpb1ExB1vBODPeYQRCG Fu90qg/zb4UWXGzrjESZtludDQ0EemkQrl+81LeZJ3ntLwJ9ZWmVAPH4XxxjnGIKNexw teWrUaCx2PWzYjCgjK+JKnnX0Ra1LPszmBpkL+XXDGQbXCA4qR6p9TjNTAd/XFq172dN DlzfLbpRF/ChjTLb/wrYhcs+aDusMlkexisJOY/7+GM+LZyMzKxyZtEj/954nRK1sD0d teR1T1uFCXe1zqfTl/JavocyxMYDQLqkayp6WK4WyCmqQk+NCIOln1OFTXUnusztsbSy g5qw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=ugzbtBPge5rlDTNTfzbBcRClDGR7j9CqrIsdICObdrM=; b=PJ+UwKHAA8uc4AmbW1XoHBiosV3liqa3qWF5G5Ovpn/RUiSwfVWzVnWj8FcxptyxUb EXtyE6BWy42u1/5E9kRCb+pIcPitz4trmECvYfQpP4hsvtnzvYoPFBaCkvIadbTcAE3p 5R06gNaPiszzZ/uCP4pOicEK9v93fAubWU0025Zry1aZFuhD7/xhxIH14nV7/T0jHO5d ByYRstktjp8/ebfOGt2a91CE6Bh9rEg7KI8q+VwUTCCIUgYbKGDoX/cAtdNX3NmSy+CC O3O32bxRl9lfsVKTeYeujcMU1ZdCZSIUO7piRKnwKF9C5sXu+cr2Ud87BMIRK1TINYbh GJCA== X-Gm-Message-State: AOAM533p8OziYpY1fjhD8ELkC1V4bn3c0kFog2V5kEEN++VR6lYQlhNZ e8nS1MeZ8xRLBuztfQj07mg= X-Google-Smtp-Source: ABdhPJzTPRFHgmYTvvrOCW3jpRJLrURZ5ZH8ucMaXZIrUdEbORjq/70lHGdB+u2ffSVrEoNAA3JPNQ== X-Received: by 2002:a65:5289:: with SMTP id y9mr10331524pgp.447.1619312623531; Sat, 24 Apr 2021 18:03:43 -0700 (PDT) Received: from [10.230.29.202] ([192.19.223.252]) by smtp.gmail.com with ESMTPSA id y18sm7685468pfp.121.2021.04.24.18.03.41 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 24 Apr 2021 18:03:42 -0700 (PDT) Subject: Re: [PATCH] MIPS: BCM63XX: Use BUG_ON instead of condition followed by BUG. To: zhouchuangao , Thomas Bogendoerfer , Florian Fainelli , bcm-kernel-feedback-list@broadcom.com, linux-mips@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org References: <1619279992-81335-1-git-send-email-zhouchuangao@vivo.com> From: Florian Fainelli Message-ID: <08bbb077-cfa3-69b8-e366-378f3c43a187@gmail.com> Date: Sat, 24 Apr 2021 18:03:41 -0700 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Firefox/78.0 Thunderbird/78.10.0 MIME-Version: 1.0 In-Reply-To: <1619279992-81335-1-git-send-email-zhouchuangao@vivo.com> Content-Language: en-US X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210424_180347_722399_6C064DB3 X-CRM114-Status: UNSURE ( 7.73 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 4/24/2021 8:59 AM, zhouchuangao wrote: > BUG_ON uses unlikely in if(), it can be optimized at compile time. > > Usually, the condition in if() is not satisfied. In my opinion, > this can improve the efficiency of the multi-stage pipeline. > > Signed-off-by: zhouchuangao Acked-by: Florian Fainelli -- Florian _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel