From: "Luka Gejak" <luka.gejak@linux.dev>
To: "Hungyu Lin" <dennylin0707@gmail.com>, pkshih@realtek.com
Cc: linux-wireless@vger.kernel.org, linux-kernel@vger.kernel.org,
fiona.klute@gmx.de, kvalo@kernel.org,
"Hungyu Lin" <dennylin0707@gmail.com>
Subject: Re: [PATCH] wifi: rtw88: 8703b: avoid converting RX SNR twice
Date: Sat, 10 Oct 2026 18:50:20 +0000 [thread overview]
Message-ID: <08bc0316b09cb28d4f660af89d249a222ce4be6f@linux.dev> (raw)
In-Reply-To: <20261010183629.39748-1-dennylin0707@gmail.com>
October 10, 2026 at 8:36 PM, "Hungyu Lin" <dennylin0707@gmail.com mailto:dennylin0707@gmail.com?to=%22Hungyu%20Lin%22%20%3Cdennylin0707%40gmail.com%3E > wrote:
>
> query_phy_status_ofdm() divides the SNR report by two when filling
> pkt_stat->rx_snr, then shifts it again when updating dm_info->rx_snr.
> This halves the SNR used for diagnostics and average statistics.
>
> Store the raw report in pkt_stat->rx_snr and convert it only when
> updating dm_info->rx_snr, as the other chip drivers do.
>
> Fixes: 61a486bcd782 ("wifi: rtw88: Add rtw8703b.c")
> Signed-off-by: Hungyu Lin <dennylin0707@gmail.com>
> ---
> drivers/net/wireless/realtek/rtw88/rtw8703b.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/wireless/realtek/rtw88/rtw8703b.c b/drivers/net/wireless/realtek/rtw88/rtw8703b.c
> index 25456f0367b2..1920277d626f 100644
> --- a/drivers/net/wireless/realtek/rtw88/rtw8703b.c
> +++ b/drivers/net/wireless/realtek/rtw88/rtw8703b.c
> @@ -959,7 +959,7 @@ static void query_phy_status_ofdm(struct rtw_dev *rtwdev, u8 *phy_raw,
> val_s8 = phy_status->path_agc[RF_PATH_A].gain & 0x3F;
> pkt_stat->rx_power[RF_PATH_A] = (val_s8 * 2) - 110;
> pkt_stat->rssi = rtw_phy_rf_power_2_rssi(pkt_stat->rx_power, 1);
> - pkt_stat->rx_snr[RF_PATH_A] = (s8)(phy_status->path_rxsnr[RF_PATH_A] / 2);
> + pkt_stat->rx_snr[RF_PATH_A] = phy_status->path_rxsnr[RF_PATH_A];
>
> /* signal power reported by HW */
> val_s8 = phy_status->cck_sig_qual_ofdm_pwdb_all >> 1;
>
Looking good to me.
Reviewed-by: Luka Gejak <luka.gejak@linux.dev>
Best regards,
Luka Gejak
next prev parent reply other threads:[~2026-10-10 18:50 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-10 18:36 [PATCH] wifi: rtw88: 8703b: avoid converting RX SNR twice Hungyu Lin
2026-10-10 18:48 ` Luka Gejak
2026-10-10 18:49 ` Luka Gejak
2026-10-10 18:50 ` Luka Gejak [this message]
2026-10-12 5:56 ` Ping-Ke Shih
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=08bc0316b09cb28d4f660af89d249a222ce4be6f@linux.dev \
--to=luka.gejak@linux.dev \
--cc=dennylin0707@gmail.com \
--cc=fiona.klute@gmx.de \
--cc=kvalo@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=pkshih@realtek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.