From: Eric Farman <farman@linux.ibm.com>
To: Cornelia Huck <cohuck@redhat.com>,
Farhan Ali <alifm@linux.ibm.com>,
Halil Pasic <pasic@linux.ibm.com>
Cc: qemu-s390x@nongnu.org, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH v6] vfio-ccw: support async command subregion
Date: Wed, 19 Jun 2019 15:05:25 -0400 [thread overview]
Message-ID: <08cdcd56-e6a1-8d36-fe77-c683f526feb3@linux.ibm.com> (raw)
In-Reply-To: <20190613092542.2834-1-cohuck@redhat.com>
On 6/13/19 5:25 AM, Cornelia Huck wrote:
> A vfio-ccw device may provide an async command subregion for
> issuing halt/clear subchannel requests. If it is present, use
> it for sending halt/clear request to the device; if not, fall
> back to emulation (as done today).
>
> Reviewed-by: Farhan Ali <alifm@linux.ibm.com>
> Signed-off-by: Cornelia Huck <cohuck@redhat.com>
> ---
>
> v5->v6:
> - plug a memory leak [Farhan]
>
> v4->v5:
> - It seems we need to take the indirection via the class for the
> callbacks after all :(
> - Dropped Eric's R-b: for that reason
I've finally looked over this version, and think it looks good. Feel
free to add this back:
Reviewed-by: Eric Farman <farman@linux.ibm.com>
next prev parent reply other threads:[~2019-06-19 19:07 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-13 9:25 [Qemu-devel] [PATCH v6] vfio-ccw: support async command subregion Cornelia Huck
2019-06-19 8:26 ` Cornelia Huck
2019-06-19 19:05 ` Eric Farman [this message]
2019-06-21 11:08 ` Cornelia Huck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=08cdcd56-e6a1-8d36-fe77-c683f526feb3@linux.ibm.com \
--to=farman@linux.ibm.com \
--cc=alifm@linux.ibm.com \
--cc=cohuck@redhat.com \
--cc=pasic@linux.ibm.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-s390x@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.