All of lore.kernel.org
 help / color / mirror / Atom feed
From: Janosch Frank <frankja@linux.ibm.com>
To: Christian Borntraeger <borntraeger@linux.ibm.com>, kvm@vger.kernel.org
Cc: imbrenda@linux.ibm.com, linux-s390@vger.kernel.org
Subject: Re: [PATCH] kvm: s390: Improve floating IRQ injection behavior
Date: Fri, 14 Aug 2026 14:40:05 +0200	[thread overview]
Message-ID: <08dc5d50-2ccc-41b2-97ab-105e605d2724@linux.ibm.com> (raw)
In-Reply-To: <ac0193b2-f286-404b-b8e9-8f67e4489aa8@linux.ibm.com>

On 8/13/26 6:43 PM, Christian Borntraeger wrote:
> 
> 
> Am 13.08.26 um 16:56 schrieb Janosch Frank:
>    	kvm_s390_set_cpuflags(vcpu, CPUSTAT_WAIT);
>> @@ -1933,7 +1964,8 @@ static void __floating_irq_kick(struct kvm *kvm, u64 type)
>>    	for (sigcpu = kvm->arch.float_int.last_sleep_cpu; ; sigcpu++) {
>>    		sigcpu %= online_vcpus;
>>    		dst_vcpu = kvm_get_vcpu(kvm, sigcpu);
>> -		if (!is_vcpu_stopped(dst_vcpu))
>> +		if (!is_vcpu_stopped(dst_vcpu) &&
>> +		    deliverable_irqs(dst_vcpu))
> 
> We have the type. Wouldnt it be better to actually check if type is deliverable?
> 

Better yes, easier no.

I need to do the translation from the IRQ types that we have in the 
function to the pending types that deliverable_irqs() returns.
I'll send a v2 next week once I had some time to test the change.

      reply	other threads:[~2026-08-14 12:40 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-08-13 14:56 [PATCH] kvm: s390: Improve floating IRQ injection behavior Janosch Frank
2026-08-13 16:43 ` Christian Borntraeger
2026-08-14 12:40   ` Janosch Frank [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=08dc5d50-2ccc-41b2-97ab-105e605d2724@linux.ibm.com \
    --to=frankja@linux.ibm.com \
    --cc=borntraeger@linux.ibm.com \
    --cc=imbrenda@linux.ibm.com \
    --cc=kvm@vger.kernel.org \
    --cc=linux-s390@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.