All of lore.kernel.org
 help / color / mirror / Atom feed
From: Michal Simek <michal.simek@amd.com>
To: Ilias Apalodimas <ilias.apalodimas@linaro.org>
Cc: u-boot@lists.denx.de, git@amd.com,
	Dario Binacchi <dario.binacchi@amarulasolutions.com>,
	Kory Maincent <kory.maincent@bootlin.com>,
	Padmarao Begari <padmarao.begari@amd.com>,
	Simon Glass <sjg@chromium.org>,
	Sughosh Ganu <sughosh.ganu@arm.com>,
	Tom Rini <trini@konsulko.com>
Subject: Re: [PATCH 2/2] fwu: Gracefully handle missing FWU metadata device
Date: Thu, 2 Jul 2026 11:09:44 +0200	[thread overview]
Message-ID: <08e98c15-80a0-40d8-bc7c-8d8edfbf3f99@amd.com> (raw)
In-Reply-To: <CAC_iWjLfC_U=q+iPCy-BXLXwLiwjXBe3UHqH5XuvU1gkyVxKkA@mail.gmail.com>



On 7/2/26 10:03, Ilias Apalodimas wrote:
> On Thu, 2 Jul 2026 at 10:49, Michal Simek <michal.simek@amd.com> wrote:
>>
>>
>>
>> On 7/2/26 09:41, Ilias Apalodimas wrote:
>>> Hi Michal,
>>>
>>> On Tue, 30 Jun 2026 at 16:18, Michal Simek <michal.simek@amd.com> wrote:
>>>>
>>>> On systems with FWU enabled but without the required DT changes the FWU
>>>> metadata device is not found and fwu_boottime_checks() returns an error.
>>>> Being an initcall, that non-zero return aborts the boot flow
>>>>
>>>> Return 0 instead so the boot continues. The preceding log_err() still
>>>> tells the user that the FWU device could not be found.
>>>
>>> Won't that affect the board later on? E.g When you do capsule updates,
>>> updating the metadata will fail
>>
>> Do you mean on systems without mdata?
> 
> Yes. if the config is enabled it will make the capsule update code
> searching and updating metadata.

fwu mdata backend is not enabled hence not used. fwu just returns 0 in dump.
Updating metadata will never call any backend.

Some logs below.

Thanks,
Michal


ZYNQ GEM: f1a60000, mdio bus f1a60000, phyaddr 1, interface rgmii-id
eth0: ethernet@f1a60000
ZYNQ GEM: ed920000, mdio bus ed920000, phyaddr 0, interface 10gbase-r
, eth1: ethernet@ed920000
Cannot find fwu device
Cannot persist EFI variables without system partition
Missing TPMv2 device for EFI_TCG_PROTOCOL
Missing RNG device for EFI_RNG_PROTOCOL
Hit any key to stop autoboot: 0
versal2>
versal2> fwu
	FWU Metadata
crc32: 0x0
version: 0x0
size: 0x0
active_index: 0x0
previous_active_index: 0x0
	Image Info

Image Type Guid: 00000000-0000-0000-0000-000000000000
Location Guid: 00000000-0000-0000-0000-000000000000
Image Guid:  00000000-0000-0000-0000-000000000000
Image Acceptance: no
Image Guid:  00000000-0000-0000-0000-000000000000
Image Acceptance: no
versal2>
versal2> efidebug capsule esrt
========================================
ESRT: fw_resource_count=1
ESRT: fw_resource_count_max=1
ESRT: fw_resource_version=1
[entry 0]==============================
ESRT: fw_class=ED9E7FCF-47B3-40CD-B6E3-565F14676D82
ESRT: fw_type=system FW
ESRT: fw_version=0
ESRT: lowest_supported_fw_version=0
ESRT: capsule_flags=0
ESRT: last_attempt_version=0
ESRT: last_attempt_status=success
========================================


  reply	other threads:[~2026-07-02  9:10 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-06-30 13:17 [PATCH 1/2] fwu: Make boottime check failures visible Michal Simek
2026-06-30 13:17 ` [PATCH 2/2] fwu: Gracefully handle missing FWU metadata device Michal Simek
2026-07-02  7:41   ` Ilias Apalodimas
2026-07-02  7:48     ` Michal Simek
2026-07-02  8:03       ` Ilias Apalodimas
2026-07-02  9:09         ` Michal Simek [this message]
2026-07-02 10:07           ` Ilias Apalodimas
2026-07-02 11:55             ` Michal Simek
2026-07-02 12:00               ` Ilias Apalodimas
2026-07-02 12:09                 ` Michal Simek
2026-07-02 12:24                   ` Ilias Apalodimas
2026-07-02 12:40                     ` Michal Simek
2026-07-02 13:07                       ` Ilias Apalodimas
2026-06-30 18:47 ` [PATCH 1/2] fwu: Make boottime check failures visible Ilias Apalodimas

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=08e98c15-80a0-40d8-bc7c-8d8edfbf3f99@amd.com \
    --to=michal.simek@amd.com \
    --cc=dario.binacchi@amarulasolutions.com \
    --cc=git@amd.com \
    --cc=ilias.apalodimas@linaro.org \
    --cc=kory.maincent@bootlin.com \
    --cc=padmarao.begari@amd.com \
    --cc=sjg@chromium.org \
    --cc=sughosh.ganu@arm.com \
    --cc=trini@konsulko.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.