From: "Burakov, Anatoly" <anatoly.burakov@intel.com>
To: "Wang, Yipeng1" <yipeng1.wang@intel.com>, "dev@dpdk.org" <dev@dpdk.org>
Cc: "Gobriel, Sameh" <sameh.gobriel@intel.com>
Subject: Re: [PATCH] member: fix memory leak on error
Date: Fri, 22 Dec 2017 09:20:44 +0000 [thread overview]
Message-ID: <08f1736c-e3ce-1dfd-02a1-032f990472d1@intel.com> (raw)
In-Reply-To: <D2C4A16CA39F7F4E8E384D204491D7A6445B1F5E@ORSMSX105.amr.corp.intel.com>
On 22-Dec-17 12:01 AM, Wang, Yipeng1 wrote:
> Thank you Anatoly for finding this issue. In the code I tried to reuse the rte_member_free function to free memory but it may not be executed through.
>
> Because of this, I may not properly release setsum struct neither. I will post a fix for both soon.
>
> Thanks
Yep, i can see that now. Didn't think to look inside rte_member_free()
:/ However, you're creating a race condition there - you're unlocking a
tailq, and then locking (and unlocking) it again inside
rte_member_free() - it probably needs _thread_unsafe() functions that
you can call from behind the lock.
--
Thanks,
Anatoly
next prev parent reply other threads:[~2017-12-22 9:20 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-21 17:50 [PATCH] member: fix memory leak on error Anatoly Burakov
2017-12-22 0:01 ` Wang, Yipeng1
2017-12-22 9:20 ` Burakov, Anatoly [this message]
2017-12-22 18:33 ` Wang, Yipeng1
2017-12-23 11:55 ` Burakov, Anatoly
2017-12-26 17:23 ` Wang, Yipeng1
2017-12-22 0:07 ` Wang, Yipeng1
2018-01-12 17:23 ` [PATCH v2] " Anatoly Burakov
2018-01-16 17:14 ` Wang, Yipeng1
2018-01-18 23:40 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=08f1736c-e3ce-1dfd-02a1-032f990472d1@intel.com \
--to=anatoly.burakov@intel.com \
--cc=dev@dpdk.org \
--cc=sameh.gobriel@intel.com \
--cc=yipeng1.wang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.