From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.1 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 019D5C433E2 for ; Thu, 17 Sep 2020 15:10:37 +0000 (UTC) Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 97A3820795 for ; Thu, 17 Sep 2020 15:10:36 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="key not found in DNS" (0-bit key) header.d=suse.com header.i=@suse.com header.b="OLdtoHCc" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 97A3820795 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=suse.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=xen-devel-bounces@lists.xenproject.org Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1kIvY3-0000PK-5L; Thu, 17 Sep 2020 15:10:11 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1kIvY1-0000Oo-8X for xen-devel@lists.xenproject.org; Thu, 17 Sep 2020 15:10:09 +0000 X-Inumbo-ID: 19987bdb-5d2c-474c-a2f9-91b505ac35f5 Received: from mx2.suse.de (unknown [195.135.220.15]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 19987bdb-5d2c-474c-a2f9-91b505ac35f5; Thu, 17 Sep 2020 15:10:08 +0000 (UTC) X-Virus-Scanned: by amavisd-new at test-mx.suse.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=cantorsusede; t=1600355407; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=OuyvRRq3qoAtHg8ElWFInTYo9ZirXk+znsFHemENgDs=; b=OLdtoHCcWaqyXxXYmoL6zI0p/0kgMZ/HKP0dbBW1py0XL1/xnASQHjVO5oNyJ9TXWx0BuR qWr0e5t2xMnIBheCPmGZXNxqVd2cPn7sN7JWARTfsKPKe0lm+9mRL9Z1fHcDv0SRcDLbgJ aauetHW0WytTuDyNtC484Ol101+JB4gfsTHtY54AItJ1bWOwh7lZcqyB58b3X++zAL8DYW A1O/8+Fn1LlY07lCNOo0CJAOWB+SRbeW74YsulvXjKDj8j4YgMs5SJ2Skb5WJWb9JpXQaI Y5zzDGarpAzaRsYa6snUV44/xaUaIutPqUfkojNkPkHI0C+NwoogVyA+8RYwng== Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 64243AB5C; Thu, 17 Sep 2020 15:10:41 +0000 (UTC) Subject: Re: [PATCH v4 3/4] efi: Enable booting unified hypervisor/kernel/initrd images To: Trammell Hudson Cc: "xen-devel@lists.xenproject.org" , "roger.pau@citrix.com" , "andrew.cooper3@citrix.com" , "wl@xen.org" References: <20200914115013.814079-1-hudson@trmm.net> <20200914115013.814079-4-hudson@trmm.net> <6Vz2rQJvGRtW6Uinda3l_V45Sor337x8uIkVphhgLRUkZSQz33lOJn-qkqwyUhtO-8ZWS28kdVrgIduNAq5Fkv0JPGbJf6_MTvlGAGRYm_s=@trmm.net> From: Jan Beulich Message-ID: <08f957a4-3290-8ab8-1076-174f275b6f9c@suse.com> Date: Thu, 17 Sep 2020 17:10:07 +0200 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.12.0 MIME-Version: 1.0 In-Reply-To: <6Vz2rQJvGRtW6Uinda3l_V45Sor337x8uIkVphhgLRUkZSQz33lOJn-qkqwyUhtO-8ZWS28kdVrgIduNAq5Fkv0JPGbJf6_MTvlGAGRYm_s=@trmm.net> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" On 17.09.2020 15:33, Trammell Hudson wrote: > On Thursday, September 17, 2020 9:04 AM, Trammell Hudson wrote: >> On Thursday, September 17, 2020 8:33 AM, Jan Beulich jbeulich@suse.com wrote: >>> [...] >>>> - if ( read_section(image, ".ucode", &ucode, NULL) ) >>>> - return; >>>> >>>> - name.s = get_value(&cfg, section, "ucode"); >>> >>> With the Arm change already in mind and with further similar >>> changes further down, may I suggest to consider passing >>> 'section' into read_section(), thus guaranteeing consistent >>> naming between image section and config file items, not only now >>> but also going forward? read_section() would then check for the >>> leading dot followed by the specified name. >> >> That could work, I think. Let me test it out for v5. > > Or maybe not. section is the "section-name" of the config file > that is being booted: > > [global] > default=section-name > > Meanwhile, read_section() wants the PE section name, like ".ucode", which might appear as a line item in that section. Oh, yes - looking at just the code fragment left in context I realize my comment was just rubbish. Sorry. Jan