All of lore.kernel.org
 help / color / mirror / Atom feed
From: "John W. Linville" <linville@tuxdriver.com>
To: linux-kernel@vger.kernel.org, netdev@vger.kernel.org
Cc: mchan@broadcom.com, davem@davemloft.net, jgarzik@pobox.com
Subject: [patch 2.6.13 5/5] tg3: correct rx_dropped and add rx_missed_errors
Date: Mon, 12 Sep 2005 10:49:00 -0400	[thread overview]
Message-ID: <09122005104900.650@bilbo.tuxdriver.com> (raw)
In-Reply-To: <09122005104900.585@bilbo.tuxdriver.com>

Do not count non-error frames dropped by the hardware as
rx_errors. Instead, count them as part of rx_missed_errors.

Signed-off-by: John W. Linville <linville@tuxdriver.com>
---

 drivers/net/tg3.c |    6 ++++--
 1 files changed, 4 insertions(+), 2 deletions(-)

diff --git a/drivers/net/tg3.c b/drivers/net/tg3.c
--- a/drivers/net/tg3.c
+++ b/drivers/net/tg3.c
@@ -6893,8 +6893,7 @@ static struct net_device_stats *tg3_get_
 		get_stat64(&hw_stats->tx_octets);
 
 	stats->rx_errors = old_stats->rx_errors +
-		get_stat64(&hw_stats->rx_errors) +
-		get_stat64(&hw_stats->rx_discards);
+		get_stat64(&hw_stats->rx_errors);
 	stats->tx_errors = old_stats->tx_errors +
 		get_stat64(&hw_stats->tx_errors) +
 		get_stat64(&hw_stats->tx_mac_errors) +
@@ -6922,6 +6921,9 @@ static struct net_device_stats *tg3_get_
 	stats->rx_crc_errors = old_stats->rx_crc_errors +
 		calc_crc_errors(tp);
 
+	stats->rx_missed_errors = old_stats->rx_missed_errors +
+		get_stat64(&hw_stats->rx_discards);
+
 	return stats;
 }
 

  reply	other threads:[~2005-09-12 15:01 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20050822181726.GJ2736@tuxdriver.com>
2005-09-12 14:48 ` [patch 2.6.13 0/5] normalize calculations of rx_dropped John W. Linville
2005-09-12 14:48   ` [patch 2.6.13 1/5] 3c59x: correct rx_dropped counting John W. Linville
2005-09-12 14:48     ` [patch 2.6.13 2/5] e1000: " John W. Linville
2005-09-12 14:48       ` [patch 2.6.13 3/5] e100: correct rx_dropped and add rx_missed_errors John W. Linville
2005-09-12 14:49         ` [patch 2.6.13 4/5] ixgb: correct rx_dropped counting John W. Linville
2005-09-12 14:49           ` John W. Linville [this message]
2005-09-12 18:53   ` [patch 2.6.13 0/5] normalize calculations of rx_dropped Jeff Garzik
2005-09-12 19:14     ` John W. Linville
2005-10-24 21:35       ` Ben Greear
2005-10-24 21:57         ` John W. Linville
2005-10-25  1:15           ` Ben Greear
2005-10-25  1:42             ` jamal
2005-10-25 19:50             ` Ingo Oeser

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=09122005104900.650@bilbo.tuxdriver.com \
    --to=linville@tuxdriver.com \
    --cc=davem@davemloft.net \
    --cc=jgarzik@pobox.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mchan@broadcom.com \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.