All of lore.kernel.org
 help / color / mirror / Atom feed
From: Guoqing Jiang <guoqing.jiang@linux.dev>
To: Jinpu Wang <jinpu.wang@ionos.com>
Cc: haris.iqbal@ionos.com, axboe@kernel.dk, jgg@ziepe.ca,
	leon@kernel.org, linux-block@vger.kernel.org,
	linux-rdma@vger.kernel.org
Subject: Re: [PATCH] rnbd-srv: remove 'dir' argument from rnbd_srv_rdma_ev
Date: Fri, 26 Aug 2022 22:01:55 +0800	[thread overview]
Message-ID: <09317a03-4e29-0f8b-4d7e-a2024c9364f6@linux.dev> (raw)
In-Reply-To: <CAMGffEkAYOJPAPaHDspk-JfJNNF96pHWnrCwYzROFZxPBBO+Fw@mail.gmail.com>



On 8/26/22 7:58 PM, Jinpu Wang wrote:
>> And I guess we can just pass parameters with register after remove an
>> argument,
>> otherwise need to push/pop stack with more than six parameters for x64.
> I doubt it makes any notable performance change.

I think it is called in the IO path (process_read and process_write) ...

BTW, do you agree if the 'usr' can be dropped from rdma_ev given it is 
always
same as 'data + data_len'?

Thanks,
Guoqing

  reply	other threads:[~2022-08-26 14:02 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-08-26  8:11 [PATCH] rnbd-srv: remove 'dir' argument from rnbd_srv_rdma_ev Guoqing Jiang
2022-08-26 10:48 ` Jinpu Wang
2022-08-26 11:26   ` Guoqing Jiang
2022-08-26 11:29     ` Jinpu Wang
2022-08-26 11:38       ` Guoqing Jiang
2022-08-26 11:58         ` Jinpu Wang
2022-08-26 14:01           ` Guoqing Jiang [this message]
2022-08-29 11:12             ` Jinpu Wang
2022-08-28 11:27       ` Leon Romanovsky
2022-08-29  7:44 ` Leon Romanovsky
2022-08-29 13:33   ` Guoqing Jiang
2022-08-29 13:43     ` Jinpu Wang
2022-08-30  8:44       ` Leon Romanovsky
2022-08-30  8:57         ` Guoqing Jiang
2022-08-30  9:15           ` Leon Romanovsky
2022-08-30  9:00         ` Jinpu Wang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=09317a03-4e29-0f8b-4d7e-a2024c9364f6@linux.dev \
    --to=guoqing.jiang@linux.dev \
    --cc=axboe@kernel.dk \
    --cc=haris.iqbal@ionos.com \
    --cc=jgg@ziepe.ca \
    --cc=jinpu.wang@ionos.com \
    --cc=leon@kernel.org \
    --cc=linux-block@vger.kernel.org \
    --cc=linux-rdma@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.