From: Alexandra Winter <wintera@linux.ibm.com>
To: "Breno Leitao" <leitao@debian.org>,
"Uwe Kleine-König (The Capable Hub)"
<u.kleine-koenig@baylibre.com>
Cc: Aswin Karuvally <aswin@linux.ibm.com>,
Andrew Lunn <andrew+netdev@lunn.ch>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Heiko Carstens <hca@linux.ibm.com>,
Vasily Gorbik <gor@linux.ibm.com>,
Alexander Gordeev <agordeev@linux.ibm.com>,
Christian Borntraeger <borntraeger@linux.ibm.com>,
Sven Schnelle <svens@linux.ibm.com>,
linux-s390@vger.kernel.org, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v1 net-next] s390/ism: Drop superflous zeros in pci_device_id array
Date: Tue, 26 May 2026 11:24:00 +0200 [thread overview]
Message-ID: <09374d76-07fc-4b12-a0a7-94de4bfe595d@linux.ibm.com> (raw)
In-Reply-To: <ahB7_10zHxM2HQWG@gmail.com>
On 22.05.26 17:54, Breno Leitao wrote:
> On Fri, May 22, 2026 at 05:30:09PM +0200, Uwe Kleine-König (The Capable Hub) wrote:
>> Subject: [PATCH v1 net-next] s390/ism: Drop superflous zeros in pci_device_id array
>
> Nit: s/superflous/superfluous/ ?
>
>> The .driver_data member of the struct pci_device_id array were
>> initialized by a list expressions to zero without making use of that
>> value. In this case it's better to not specify a value at all and let
>> the compiler fill in the zeros. Same for the list terminator that can
>> better be completely empty.
>>
>> This patch doesn't introduce changes to the compiled array.
>
> True. For a `static const` aggregate, omitted members are
> zero-initialized per C99 6.7.8, so dropping the trailing `, 0` and
> collapsing `{ 0, }` to `{ }` is a no-op at the object level.
>
>> Signed-off-by: Uwe Kleine-König (The Capable Hub) <u.kleine-koenig@baylibre.com>
>
> Reviewed-by: Breno Leitao <leitao@debian.org>
Acked-by: Alexandra Winter <wintera@linux.ibm.com>
next prev parent reply other threads:[~2026-05-26 9:24 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-22 15:30 [PATCH v1 net-next] s390/ism: Drop superflous zeros in pci_device_id array Uwe Kleine-König (The Capable Hub)
2026-05-22 15:54 ` Breno Leitao
2026-05-26 9:24 ` Alexandra Winter [this message]
2026-05-26 13:54 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=09374d76-07fc-4b12-a0a7-94de4bfe595d@linux.ibm.com \
--to=wintera@linux.ibm.com \
--cc=agordeev@linux.ibm.com \
--cc=andrew+netdev@lunn.ch \
--cc=aswin@linux.ibm.com \
--cc=borntraeger@linux.ibm.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=gor@linux.ibm.com \
--cc=hca@linux.ibm.com \
--cc=kuba@kernel.org \
--cc=leitao@debian.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-s390@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=svens@linux.ibm.com \
--cc=u.kleine-koenig@baylibre.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.