Re: [PATCH v2 5/5] accel/amdxdna: Provide real-time NPU power estimate via AMD PMF

["Ilpo Järvinen" <ilpo.jarvinen@linux.intel.com>]

[-- Attachment #1: Type: text/plain, Size: 1683 bytes --]

On Tue, 18 Nov 2025, Ilpo Järvinen wrote:

> On Fri, 14 Nov 2025, Mario Limonciello wrote:
> > On 11/13/2025 1:33 AM, Shyam Sundar S K wrote:
> > > On 11/12/2025 23:33, Mario Limonciello wrote:
> > > > On 11/11/25 12:37 AM, Shyam Sundar S K wrote:
> > > > > From: VinitKumar Shukla <VinitKumar.Shukla@amd.com>
> > > > > 
> > > > > Add aie2_smu_get_power_estimate() to obtain NPU power readings from the
> > > > > AMD PMF driver. This xdna interface enables user space to reflect
> > > > > current
> > > > > workload power consumption in real time.
> > > > 
> > > > But.. it doesn't.  It just adds a new function that could potentially
> > > > do this job.  The actual gluing it to userspace in some way to use
> > > > this function will be another patch.
> > > 
> > > For now, yes.. that's right. XDNA team will add more support on it
> > > that goes via the accel tree. But this patch is meant to have a
> > > minimal change on the xdna side so that there is a  consumer of the
> > > pmf symbol that is getting exported to the kernel.
> > > 
> > > So, there is more support coming on the way. If you think, its worth
> > > to rephrase the commit?
> > 
> > Yes; that other support isn't happening this kernel cycle.  So the commit
> > message should be accurate to what it's actually doing (laying ground work).
> 
> To me it looks this and patch 4 should be submitted with the actual user 
> instead of trying to justify things with far in the future changes. I've 
> no problem with creating immutable branch if necessary when multiple trees 
> are involved.

In case it wasn't obvious, I'm fine with taking patches 1-3 in earlier.

-- 
 i.