From: heyunlei <heyunlei@huawei.com>
To: Hou Pengyang <houpengyang@huawei.com>, Jaegeuk Kim <jaegeuk@kernel.org>
Cc: guoweichao@huawei.com, linux-f2fs-devel@lists.sourceforge.net
Subject: Re: [PATCH] f2fs: avoid unnecessary fg_gc
Date: Mon, 27 Feb 2017 10:28:26 +0800 [thread overview]
Message-ID: <094e099e-e97d-8eaa-fdcf-e62434f4b4f0@huawei.com> (raw)
In-Reply-To: <58B387ED.8080700@huawei.com>
Hi Jaegeuk,
On 2017/2/27 9:59, Hou Pengyang wrote:
> We use has_not_enough_free_secs to check if there are enough free segments,
>
> (free_sections(sbi) + freed) <=
> (node_secs + 2 * dent_secs + imeta_secs +
> reserved_sections(sbi) + needed);
Now node SSR is enable, how can we change this condition simply as:
(free_sections(sbi) + freed) <= reserved_sections(sbi)
If dirty node pages can find SSR segment, write it in SSR mode,
or it will consume free segments, and then we do FG_GC.
Another thing is that each process has a chance to do FG_GC, it's no problem
for all normal processes, but may be not a good thing for a process within
certain limits such as lower priority, with bound cpu to do FG_GC. Maybe it
will block system for a long time. So what can we do to improve this?
Thanks.
------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, SlashDot.org! http://sdm.link/slashdot
next prev parent reply other threads:[~2017-02-27 2:30 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-24 10:01 [PATCH] f2fs: avoid unnecessary fg_gc Hou Pengyang
2017-02-24 10:28 ` Chao Yu
2017-02-25 1:44 ` Hou Pengyang
2017-02-25 2:07 ` Chao Yu
2017-02-25 2:07 ` Jaegeuk Kim
2017-02-25 2:23 ` heyunlei
2017-02-25 19:39 ` Jaegeuk Kim
2017-02-27 1:59 ` Hou Pengyang
2017-02-27 2:28 ` heyunlei [this message]
2017-02-27 23:40 ` Jaegeuk Kim
2017-02-28 2:06 ` heyunlei
2017-02-27 6:25 ` Chao Yu
2017-02-25 2:54 ` Hou Pengyang
2017-02-25 3:57 ` [PATCH 1/2] remove stale comment info about cp before fggc Hou Pengyang
2017-02-25 3:57 ` [PATCH 2/2] f2fs: avoid bggc->fggc when enough free segments are avaliable after cp Hou Pengyang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=094e099e-e97d-8eaa-fdcf-e62434f4b4f0@huawei.com \
--to=heyunlei@huawei.com \
--cc=guoweichao@huawei.com \
--cc=houpengyang@huawei.com \
--cc=jaegeuk@kernel.org \
--cc=linux-f2fs-devel@lists.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.