From: Krzysztof Kozlowski <krzk@kernel.org>
To: Xuyang Dong <dongxuyang@eswincomputing.com>
Cc: ukleinek@kernel.org, robh@kernel.org, krzk+dt@kernel.org,
conor+dt@kernel.org, ben-linux@fluff.org,
ben.dooks@codethink.co.uk, p.zabel@pengutronix.de,
linux-pwm@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, ningyu@eswincomputing.com,
linmin@eswincomputing.com, xuxiang@eswincomputing.com,
wangguosheng@eswincomputing.com, pinkesh.vaghela@einfochips.com
Subject: Re: [PATCH v7 1/2] dt-bindings: pwm: dwc: Add eswin compatible and resets property
Date: Wed, 10 Jun 2026 12:17:07 +0200 [thread overview]
Message-ID: <09563fd2-344e-4458-831f-1bef862dfb34@kernel.org> (raw)
In-Reply-To: <25b0baf0.731a.19eb0d9bf07.Coremail.dongxuyang@eswincomputing.com>
On 10/06/2026 11:25, Xuyang Dong wrote:
>>> Hi Krzysztof,
>>>
>>> Thanks for your comments and time.
>>>
>>> Regarding snps,dw-apb-timers-pwm2, we previously intended to add the
>>> resets property in the same patch.
>>> However, as you suggested, we will split it into a separate patch.
>>
>> I find commit msg still confusing. Please always clearly explain WHY you
>> are doing changes.
>>
>
> Hi Krzysztof,
>
> Thanks for your comments.
>
> According to the DesignWare IP for PWM controllers manual, it seems to me
> that Ben's previous submission may have missed the optional resets property.
>
> Therefore, I would like to confirm: should I submit a separate fix patch for
> the resets property, or include it as a feature patch in this series?
>
One change is adding resets to existing binding for existing device.
With its own rationale.
Another change is adding new device compatible with its own necessary
changes (if resets are different).
Best regards,
Krzysztof
next prev parent reply other threads:[~2026-06-10 10:17 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-06-05 8:22 [PATCH v7 0/2] Update designware pwm driver dongxuyang
2026-06-05 8:23 ` [PATCH v7 1/2] dt-bindings: pwm: dwc: Add eswin compatible and resets property dongxuyang
2026-06-05 10:12 ` Krzysztof Kozlowski
2026-06-09 9:31 ` Xuyang Dong
2026-06-09 10:02 ` Krzysztof Kozlowski
2026-06-10 9:25 ` Xuyang Dong
2026-06-10 10:17 ` Krzysztof Kozlowski [this message]
2026-06-05 8:24 ` [PATCH v7 2/2] pwm: dwc: add of/platform support Xuyang Dong
2026-06-05 8:38 ` sashiko-bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=09563fd2-344e-4458-831f-1bef862dfb34@kernel.org \
--to=krzk@kernel.org \
--cc=ben-linux@fluff.org \
--cc=ben.dooks@codethink.co.uk \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dongxuyang@eswincomputing.com \
--cc=krzk+dt@kernel.org \
--cc=linmin@eswincomputing.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pwm@vger.kernel.org \
--cc=ningyu@eswincomputing.com \
--cc=p.zabel@pengutronix.de \
--cc=pinkesh.vaghela@einfochips.com \
--cc=robh@kernel.org \
--cc=ukleinek@kernel.org \
--cc=wangguosheng@eswincomputing.com \
--cc=xuxiang@eswincomputing.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.