RE: [PATCH] ARM: EXYNOS: skip the clock initialization for exynos5440

[Kukjin Kim <kgene.kim@samsung.com>]

Olof Johansson wrote:
> 
> Hi,
> 
> On Mon, Dec 31, 2012 at 3:33 PM, Kukjin Kim <kgene.kim@samsung.com>
> wrote:
> > Since exynos5440 can support only common clk stuff, so this
> > patch skips legacy exynos5 clock initialization.
> >
> > Signed-off-by: Kukjin Kim <kgene.kim@samsung.com>
> > ---
> >  arch/arm/mach-exynos/common.c |    7 +++++++
> >  1 file changed, 7 insertions(+)
> >
> > diff --git a/arch/arm/mach-exynos/common.c b/arch/arm/mach-
> exynos/common.c
> > index d6d0dc6..1a89824 100644
> > --- a/arch/arm/mach-exynos/common.c
> > +++ b/arch/arm/mach-exynos/common.c
> > @@ -424,11 +424,18 @@ static void __init exynos5_init_clocks(int xtal)
> >  {
> >         printk(KERN_DEBUG "%s: initializing clocks\n", __func__);
> >
> > +       /* EXYNOS5440 can support only common clock framework */
> > +
> > +       if (soc_is_exynos5440())
> > +               return;
> > +
> > +#ifdef CONFIG_SOC_EXYNOS5250
> 
> Why are you adding an ifdef here, when the return above will take care
> of returning early for 5440?
> 
Without this, compilation error should be happened when we builds only for
exynos5440 without selection exynos5250, because you know, current
exynos5440 stuff cannot support legacy exynos5 clock. Of course, the ifdef
will be going away when we support common clock on all of exynos stuff, but
it's v3.9 not v3.8 so I think, we need this for now.
Note, exynos5440 is working fine on current mainline + v3.8-samsung-fixes-2
without any configuration clock stuff in kernel because hardware initial
value is ok.

- Kukjin