From: Baolu Lu <baolu.lu@linux.intel.com>
To: Yi Liu <yi.l.liu@intel.com>, joro@8bytes.org, jgg@nvidia.com
Cc: baolu.lu@linux.intel.com, kevin.tian@intel.com,
iommu@lists.linux.dev, robin.murphy@arm.com, nicolinc@nvidia.com,
will@kernel.org
Subject: Re: [PATCH v2 2/4] iommu: Drop iommu_group_replace_domain()
Date: Sun, 23 Feb 2025 21:18:32 +0800 [thread overview]
Message-ID: <0998ec60-9b91-4d81-b45f-1d0a5db02bee@linux.intel.com> (raw)
In-Reply-To: <20250221143335.49874-3-yi.l.liu@intel.com>
On 2025/2/21 22:33, Yi Liu wrote:
> iommufd does not use it now, so drop it.
iommufd still uses iommu_group_replace_domain() in Joerg's tree. This
could cause compiling issues if this series goes through the iommu tree.
$ git grep iommu_group_replace_domain
drivers/iommu/iommu-priv.h:int iommu_group_replace_domain(struct
iommu_group *group,
drivers/iommu/iommu.c: * iommu_group_replace_domain - replace the domain
that a group is attached to
drivers/iommu/iommu.c:int iommu_group_replace_domain(struct iommu_group
*group,
drivers/iommu/iommu.c:EXPORT_SYMBOL_NS_GPL(iommu_group_replace_domain,
"IOMMUFD_INTERNAL");
drivers/iommu/iommu.c: * This is a variant of
iommu_group_replace_domain(). It allows the caller to
drivers/iommu/iommufd/iommufd_private.h: return
iommu_group_replace_domain(idev->igroup->group, hwpt->domain);
> Reviewed-by: Jason Gunthorpe<jgg@nvidia.com>
> Reviewed-by: Nicolin Chen<nicolinc@nvidia.com>
> Reviewed-by: Kevin Tian<kevin.tian@intel.com>
> Signed-off-by: Yi Liu<yi.l.liu@intel.com>
> ---
> drivers/iommu/iommu-priv.h | 3 ---
> drivers/iommu/iommu.c | 35 ++++++-----------------------------
> 2 files changed, 6 insertions(+), 32 deletions(-)
Thanks,
baolu
next prev parent reply other threads:[~2025-02-23 13:18 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-21 14:33 [PATCH v2 0/4] Misc iommu_attach_handle enhancements in iommu core Yi Liu
2025-02-21 14:33 ` [PATCH v2 1/4] iommu: Make @handle mandatory in iommu_{attach|replace}_group_handle() Yi Liu
2025-02-23 13:08 ` Baolu Lu
2025-02-21 14:33 ` [PATCH v2 2/4] iommu: Drop iommu_group_replace_domain() Yi Liu
2025-02-23 13:18 ` Baolu Lu [this message]
2025-02-24 4:40 ` Yi Liu
2025-02-24 14:43 ` Jason Gunthorpe
2025-02-21 14:33 ` [PATCH v2 3/4] iommu: Store either domain or handle in group->pasid_array Yi Liu
2025-02-23 13:22 ` Baolu Lu
2025-02-24 2:38 ` Tian, Kevin
2025-02-24 2:57 ` Baolu Lu
2025-02-24 3:04 ` Tian, Kevin
2025-02-24 4:22 ` Yi Liu
2025-02-21 14:33 ` [PATCH v2 4/4] iommu: Swap the order of setting group->pasid_array and calling attach op of iommu drivers Yi Liu
2025-02-21 17:27 ` Nicolin Chen
2025-02-22 1:59 ` Yi Liu
2025-02-22 15:35 ` Nicolin Chen
2025-02-23 13:32 ` Baolu Lu
2025-02-24 4:38 ` Yi Liu
2025-02-24 5:07 ` Baolu Lu
2025-02-24 5:28 ` Yi Liu
2025-02-23 13:28 ` Baolu Lu
2025-02-25 0:12 ` Jason Gunthorpe
2025-02-25 0:13 ` [PATCH v2 0/4] Misc iommu_attach_handle enhancements in iommu core Jason Gunthorpe
2025-02-25 3:35 ` Yi Liu
2025-02-28 9:23 ` Joerg Roedel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0998ec60-9b91-4d81-b45f-1d0a5db02bee@linux.intel.com \
--to=baolu.lu@linux.intel.com \
--cc=iommu@lists.linux.dev \
--cc=jgg@nvidia.com \
--cc=joro@8bytes.org \
--cc=kevin.tian@intel.com \
--cc=nicolinc@nvidia.com \
--cc=robin.murphy@arm.com \
--cc=will@kernel.org \
--cc=yi.l.liu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.