Re: [PATCH v3 10/16] platform/x86: int3472: Add include defining struct dmi_system_id

["Ilpo Järvinen" <ilpo.jarvinen@linux.intel.com>]

[-- Attachment #1: Type: text/plain, Size: 1738 bytes --]

On Sun, 28 Jun 2026, Uwe Kleine-König (The Capable Hub) wrote:

> Currently <linux/mod_devicetable.h> is included transitively in
> int3472.h via
> 
> 	<linux/clk-provider.h> ->
> 	<linux/of.h> ->
> 	<linux/mod_devicetable.h>
> 
> However these includes will be tightend such that only the bits relevant
> for of will be provided by <linux/of.h>. To ensure that dmi_system_id
> stays around, include the respective header explicitly.
>
> Acked-by: Danilo Krummrich <dakr@kernel.org>
> Signed-off-by: Uwe Kleine-König (The Capable Hub) <u.kleine-koenig@baylibre.com>
> ---
>  include/linux/platform_data/x86/int3472.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/include/linux/platform_data/x86/int3472.h b/include/linux/platform_data/x86/int3472.h
> index 93f1e1fe09b4..a73841dfae27 100644
> --- a/include/linux/platform_data/x86/int3472.h
> +++ b/include/linux/platform_data/x86/int3472.h
> @@ -13,6 +13,7 @@
>  #include <linux/leds.h>
>  #include <linux/regulator/driver.h>
>  #include <linux/regulator/machine.h>
> +#include <linux/device-id/dmi.h>
>  #include <linux/types.h>
>  
>  /* FIXME drop this once the I2C_DEV_NAME_FORMAT macro has been added to include/linux/i2c.h */
> @@ -72,7 +73,6 @@
>  	container_of(clk, struct int3472_discrete_device, clock)
>  
>  struct acpi_device;
> -struct dmi_system_id;

So the forward declaration was actually snakeoil and the real struct was 
always required for the extern (it just came silently in through other 
includes without anyone noticing). I had to check myself what happens 
without this patch because your changelog didn't mention it.

Acked-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com>

-- 
 i.