From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ben Greear Subject: Re: Repeatable inet6_dump_fib crash in stock 4.12.0-rc4+ Date: Tue, 20 Jun 2017 07:12:27 -0700 Message-ID: <09a00004-da54-dc8f-5806-9576bbf577c7@candelatech.com> References: <1496795269.736.21.camel@edumazet-glaptop3.roam.corp.google.com> <1496809166.736.25.camel@edumazet-glaptop3.roam.corp.google.com> <94bcc041-6402-d0ce-b9cf-3b46aa622f34@candelatech.com> <7e0c97fa-cd6e-ed0f-bf99-0e4af40fbd2f@gmail.com> <1497043557.736.94.camel@edumazet-glaptop3.roam.corp.google.com> <9cb61ef0-37c0-8f35-bb5c-e3d8e63cbe2f@candelatech.com> <3230b360-528b-0ae0-8731-7906e57ee993@gmail.com> <4b65e262-e727-010a-ce1f-eb45fcef8e42@candelatech.com> <8630b942-2684-2f21-fdb9-8474aba71528@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Cc: Eric Dumazet , netdev To: David Ahern , Cong Wang Return-path: Received: from mail2.candelatech.com ([208.74.158.173]:35730 "EHLO mail2.candelatech.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751989AbdFTOM3 (ORCPT ); Tue, 20 Jun 2017 10:12:29 -0400 In-Reply-To: <8630b942-2684-2f21-fdb9-8474aba71528@gmail.com> Sender: netdev-owner@vger.kernel.org List-ID: On 06/14/2017 03:25 PM, David Ahern wrote: > On 6/14/17 4:23 PM, Ben Greear wrote: >> On 06/13/2017 07:27 PM, David Ahern wrote: >> >>> Let's try a targeted debug patch. See attached >> >> I had to change it to pr_err so it would go to our serial console >> since the system locked hard on crash, >> and that appears to be enough to change the timing where we can no longer >> reproduce the problem. > > > ok, let's figure out which one is doing that. There are 3 debug > statements. I suspect fib6_del_route is the one setting the state to > FWS_U. Can you remove the debug prints in fib6_repair_tree and > fib6_walk_continue and try again? We cannot reproduce with just that one printf in the kernel either. It must change the timing too much to trigger the bug. Thanks, Ben -- Ben Greear Candela Technologies Inc http://www.candelatech.com