From: Jens Axboe <axboe@kernel.dk>
To: Christoph Hellwig <hch@lst.de>
Cc: linux-block@vger.kernel.org
Subject: Re: [PATCH] block: reorder the REQ_ flags
Date: Tue, 10 May 2022 17:03:15 -0600 [thread overview]
Message-ID: <09a72de2-c171-63d8-ff0d-13050aa40c87@kernel.dk> (raw)
In-Reply-To: <20220510130058.1315400-1-hch@lst.de>
On 5/10/22 7:00 AM, Christoph Hellwig wrote:
> Keep the op-specific flag last.
Not that I'm against the patch, but we really should have some
justification in the commit message as to why the change is
useful or needed.
--
Jens Axboe
next prev parent reply other threads:[~2022-05-10 23:03 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-10 13:00 [PATCH] block: reorder the REQ_ flags Christoph Hellwig
2022-05-10 23:03 ` Jens Axboe [this message]
2022-05-11 7:31 ` Chaitanya Kulkarni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=09a72de2-c171-63d8-ff0d-13050aa40c87@kernel.dk \
--to=axboe@kernel.dk \
--cc=hch@lst.de \
--cc=linux-block@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.