All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Steve Wise" <swise@opengridcomputing.com>
To: 'Varun Prakash' <varun@chelsio.com>, davem@davemloft.net
Cc: netdev@vger.kernel.org, linux-scsi@vger.kernel.org,
	target-devel@vger.kernel.org, nab@linux-iscsi.org,
	gerlitz.or@gmail.com, james.bottomley@hansenpartnership.com,
	indranil@chelsio.com
Subject: RE: [net-next 6/6] cxgb3i,cxgb4i: fix symbol not declared sparse warning
Date: Fri, 15 Jul 2016 09:17:39 -0500	[thread overview]
Message-ID: <09cb01d1dea3$a4acf950$ee06ebf0$@opengridcomputing.com> (raw)
In-Reply-To: <bd0f185a6dafaf31d825b67758eaec01e69f7c36.1467998293.git.varun@chelsio.com>

> 
> Fix following sparse warnings
> warning: symbol 'cxgb3i_ofld_init' was not declared. Should it be static?
> warning: symbol 'cxgb4i_cplhandlers' was not declared. Should it be static?
> warning: symbol 'cxgb4i_ofld_init' was not declared. Should it be static?
> 
> Signed-off-by: Varun Prakash <varun@chelsio.com>

looks fine.

Reviewed-by: Steve Wise <swise@opengridcomputing.com>

WARNING: multiple messages have this Message-ID (diff)
From: "Steve Wise" <swise@opengridcomputing.com>
To: "'Varun Prakash'" <varun@chelsio.com>, <davem@davemloft.net>
Cc: <netdev@vger.kernel.org>, <linux-scsi@vger.kernel.org>,
	<target-devel@vger.kernel.org>, <nab@linux-iscsi.org>,
	<gerlitz.or@gmail.com>, <james.bottomley@hansenpartnership.com>,
	<indranil@chelsio.com>
Subject: RE: [net-next 6/6] cxgb3i,cxgb4i: fix symbol not declared sparse warning
Date: Fri, 15 Jul 2016 09:17:39 -0500	[thread overview]
Message-ID: <09cb01d1dea3$a4acf950$ee06ebf0$@opengridcomputing.com> (raw)
In-Reply-To: <bd0f185a6dafaf31d825b67758eaec01e69f7c36.1467998293.git.varun@chelsio.com>

> 
> Fix following sparse warnings
> warning: symbol 'cxgb3i_ofld_init' was not declared. Should it be static?
> warning: symbol 'cxgb4i_cplhandlers' was not declared. Should it be static?
> warning: symbol 'cxgb4i_ofld_init' was not declared. Should it be static?
> 
> Signed-off-by: Varun Prakash <varun@chelsio.com>

looks fine.

Reviewed-by: Steve Wise <swise@opengridcomputing.com>

  reply	other threads:[~2016-07-15 14:17 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-07-08 17:33 [net-next 0/6] common library for Chelsio drivers Varun Prakash
2016-07-08 17:33 ` [net-next 1/6] libcxgb: add library module " Varun Prakash
2016-07-15 14:02   ` Steve Wise
2016-07-15 14:02     ` Steve Wise
2016-07-08 17:33 ` [net-next 2/6] cxgb3i,cxgb4i,libcxgbi: remove iSCSI DDP support Varun Prakash
2016-07-15 14:05   ` Steve Wise
2016-07-15 14:05     ` Steve Wise
2016-07-16 15:44     ` Varun Prakash
2016-07-08 17:33 ` [net-next 3/6] cxgb4i,libcxgbi: add " Varun Prakash
2016-07-15 14:13   ` Steve Wise
2016-07-15 14:13     ` Steve Wise
2016-07-16 15:54     ` Varun Prakash
2016-07-08 17:33 ` [net-next 4/6] cxgb3i: " Varun Prakash
2016-07-15 14:14   ` Steve Wise
2016-07-15 14:14     ` Steve Wise
2016-07-08 17:33 ` [net-next 5/6] libcxgb: export ppm release and tagmask set api Varun Prakash
2016-07-15 14:15   ` Steve Wise
2016-07-15 14:15     ` Steve Wise
2016-07-08 17:33 ` [net-next 6/6] cxgb3i,cxgb4i: fix symbol not declared sparse warning Varun Prakash
2016-07-15 14:17   ` Steve Wise [this message]
2016-07-15 14:17     ` Steve Wise
2016-07-11 19:50 ` [net-next 0/6] common library for Chelsio drivers David Miller
2016-07-11 19:55   ` Steve Wise
2016-07-11 19:55     ` Steve Wise

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='09cb01d1dea3$a4acf950$ee06ebf0$@opengridcomputing.com' \
    --to=swise@opengridcomputing.com \
    --cc=davem@davemloft.net \
    --cc=gerlitz.or@gmail.com \
    --cc=indranil@chelsio.com \
    --cc=james.bottomley@hansenpartnership.com \
    --cc=linux-scsi@vger.kernel.org \
    --cc=nab@linux-iscsi.org \
    --cc=netdev@vger.kernel.org \
    --cc=target-devel@vger.kernel.org \
    --cc=varun@chelsio.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.