All of lore.kernel.org
 help / color / mirror / Atom feed
From: ZhangGuoDong <zhang.guodong@linux.dev>
To: Namjae Jeon <linkinjeon@kernel.org>
Cc: smfrench@gmail.com, chenxiaosong@chenxiaosong.com,
	linux-cifs@vger.kernel.org,
	ZhangGuoDong <zhangguodong@kylinos.cn>,
	ChenXiaoSong <chenxiaosong@kylinos.cn>
Subject: Re: [PATCH v4 5/5] smb: introduce struct file_posix_info
Date: Tue, 3 Mar 2026 11:00:00 +0800	[thread overview]
Message-ID: <09cb6f53-e5e1-4b42-9b25-b28860fe2a9e@linux.dev> (raw)
In-Reply-To: <b257491a-e821-4b2a-8465-1aa1102d35b9@linux.dev>

And we cannot use `SidBuffer[32]` because the size of `SidBuffer[]` on 
the client side is not necessarily 32.

在 2026/3/3 10:41, ZhangGuoDong 写道:
> Hi Namjae,
> 
> C structure cannot have two flexible array members.
> 
> If we make `Sids[]` a flexible array member, then there cannot be any 
> members after it. However, this structure still has `filenamelength` and 
> `filename[]` after it. And `filename[]` is also a flexible array member.
> 
> Do you have any suggestions for this?
> 
> 在 2026/2/27 12:37, Namjae Jeon 写道:
>> You need to add Sids[] flex array here.
>>> +       // var sized owner SID
>>> +       // var sized group SID
>>> +       /* end of POSIX Create Context Response */
>>> +       // le32 filenamelength
>>> +       // u8 filename[]
>>> +} __packed;
> 


  reply	other threads:[~2026-03-03  3:00 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-02-25  4:10 [PATCH v4 0/5] smb: move duplicate definitions into common header file, part 2 zhang.guodong
2026-02-25  4:10 ` [PATCH v4 1/5] smb: move some definitions from common/smb2pdu.h into common/fscc.h zhang.guodong
2026-02-25  4:10 ` [PATCH v4 2/5] smb: move file_basic_info " zhang.guodong
2026-02-25  4:10 ` [PATCH v4 3/5] smb: move filesystem_vol_info " zhang.guodong
2026-02-27  2:37   ` Namjae Jeon
2026-02-27  2:48     ` ZhangGuoDong
2026-02-25  4:10 ` [PATCH v4 4/5] smb: update some doc references zhang.guodong
2026-03-01 17:41   ` Steve French
2026-02-25  4:11 ` [PATCH v4 5/5] smb: introduce struct file_posix_info zhang.guodong
2026-02-27  4:37   ` Namjae Jeon
2026-03-03  2:41     ` ZhangGuoDong
2026-03-03  3:00       ` ZhangGuoDong [this message]
2026-03-03  7:31         ` ChenXiaoSong
2026-03-03  8:58           ` ChenXiaoSong
2026-03-03  9:41             ` ChenXiaoSong

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=09cb6f53-e5e1-4b42-9b25-b28860fe2a9e@linux.dev \
    --to=zhang.guodong@linux.dev \
    --cc=chenxiaosong@chenxiaosong.com \
    --cc=chenxiaosong@kylinos.cn \
    --cc=linkinjeon@kernel.org \
    --cc=linux-cifs@vger.kernel.org \
    --cc=smfrench@gmail.com \
    --cc=zhangguodong@kylinos.cn \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.