From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.11]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id EFA3C392C46 for ; Wed, 26 Aug 2026 06:12:03 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=198.175.65.11 ARC-Seal:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787724727; cv=fail; b=C+4CGREAVfTBk363N3AyWzDS3sF0APPqs56Qw6rNNmkHGBAozWMs5xeIRm56Fk5YQljikGn9oN3UeD00t21NdwTL2LcwCKm9KTkZw+3jDC+1epMgIPduc5xxBhH+f7BwxSDL7Ql3oTiIRZdG2HTH7BR8ZghvzEqB28WOutKXV94= ARC-Message-Signature:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787724727; c=relaxed/simple; bh=gcKRXaRgIuMBaOopyDr5SmLwxRkgdyZgeMeG1v6cKSs=; h=Message-ID:Date:Subject:To:CC:References:From:In-Reply-To: Content-Type:MIME-Version; b=HKWk4oJ1ViRio6icFxwHetIuKUw9VoPWeJaNVdCUwhRsm71R+qx9Er+D/YGYPA7+bJUmbPWp3GadMSKBIGLnBbJqh8paaw9BVkWDZWEMuhoF+8y2n46VpuL6R+kzvvDkL5zNnnuqyjsbeNDVXX988zg8//pTKIH54l2BkGZvqwA= ARC-Authentication-Results:i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com; spf=pass smtp.mailfrom=intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=DmqNcHEN; arc=fail smtp.client-ip=198.175.65.11 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="DmqNcHEN" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1787724725; x=1819260725; h=message-id:date:subject:to:cc:references:from: in-reply-to:content-transfer-encoding:mime-version; bh=gcKRXaRgIuMBaOopyDr5SmLwxRkgdyZgeMeG1v6cKSs=; b=DmqNcHENHayb+kf3aGXoONBZ69CbDA1ldUrVxKFAfL917mNABKAlMeNr DkIxtJAr62q9PublJp5JQqESRCnD/eWT2JpI3Xykkkq4yKsjaWo8GyV27 44reQ2cL/1aeH015V3LOBx8L4xIBDy2l6nBh8z30cm03e+TTpuA3j0GJe EM/+E3KEJeiKaozzTO9k0USyp/RqVAdFdNrx/kTfFnsk3YxD3sXitOTvj 7Ed5/vX66ostax9W2lTsTuiMwCx0KDuaQdmOQH9aa1ujWm5ATk/wyxZ2u IfHthfAJac5SNElip1fIXgeIWJxA7zv5GIS3sibDEr5IthXNObIVH/3KP g==; X-CSE-ConnectionGUID: qT88KZS6SzKHiybPfSTOEw== X-CSE-MsgGUID: hGgHPuLdTyGhDixN+7w1+A== X-IronPort-AV: E=McAfee;i="6800,10657,11886"; a="98534587" X-IronPort-AV: E=Sophos;i="6.25,244,1779174000"; d="scan'208";a="98534587" Received: from orviesa007.jf.intel.com ([10.64.159.147]) by orvoesa103.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 25 Aug 2026 23:12:02 -0700 X-CSE-ConnectionGUID: A0y2ITg0T0OaAcjzx+UzMw== X-CSE-MsgGUID: uuPQn2AcRCKm1x9NcWcyQA== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.25,244,1779174000"; d="scan'208";a="267508519" Received: from orsmsx901.amr.corp.intel.com ([10.22.229.23]) by orviesa007.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 25 Aug 2026 23:12:01 -0700 Received: from ORSMSX901.amr.corp.intel.com (10.22.229.23) by ORSMSX901.amr.corp.intel.com (10.22.229.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.46; Tue, 25 Aug 2026 23:12:00 -0700 Received: from ORSEDG901.ED.cps.intel.com (10.7.248.11) by ORSMSX901.amr.corp.intel.com (10.22.229.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.46 via Frontend Transport; Tue, 25 Aug 2026 23:12:00 -0700 Received: from CH4PR04CU002.outbound.protection.outlook.com (40.107.201.40) by edgegateway.intel.com (134.134.137.111) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.45; Tue, 25 Aug 2026 23:12:00 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=XaBZRWeva0wgiGh6gylEBaBFYUPTZwYu4ZP/o8Jv+Zf+yomjzHv9pG87/Pxo9lM01Hn8ZxaKl6z3kW0/YXyOKmYrwcalKAF1vD5yL4EzCHp5+z5TZ364YdxpiR3VDP2E4CpsO19iAL3k+CUJXXxh38/sB1DKCdfrfx15E3NBXei9nnFkly55URM6sWfWFlZD9O/jwTrs8v7esfUY43UEk015SqZ4QZRvm2T7jUOTCQ48GlTuxr2fOMME7KXwyaG5uGyyXg/mi+j7YgGyi8xtE1R5WcyY1ZRCIIPhFP9o2pce4xXLVnbPoRZxXM4IcnT1wGq6EFqlQHwhjl/FN1i2HQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=1IcMVDf1qD29+un/lNIvlETiE0PDTP9NAOAaIEV9iSQ=; b=kIK+x8Egy/DWG5jPvvAj9RsCTW/IEAeaVvqKk0sN0rE44pF0kiMbTgZ6KYeqXIn421vUaT9unkaNJSvs/klnS+8TFHAO7kOlPw6hHsXH0VrlNM3Zi6dr3uxeZYnCenS0bg9R+ET/rMba2QYNxVsVq8uLNYQDFcZAGq48RqB/Le9DRGJExfblY8iwn1hQzImrmmP4wHXZzMWc0rsB4TrK2DuwZVozEhLFHE1M9ocAEXBrTXC/A+Z9ADxZqypVvXTzmoVCPJ0tHFXwoTw14ngakWtyQEEP+9524FBWFVeEYJCJP6N959oCJoIpWucBe0KaTg9bqJTk6FelqTh7gSeVYA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; Received: from DM4PR11MB6020.namprd11.prod.outlook.com (2603:10b6:8:61::19) by DS4PR11MB298041.namprd11.prod.outlook.com (2603:10b6:8:508::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.339.12; Wed, 26 Aug 2026 06:11:57 +0000 Received: from DM4PR11MB6020.namprd11.prod.outlook.com ([fe80::3058:1480:e4ac:5765]) by DM4PR11MB6020.namprd11.prod.outlook.com ([fe80::3058:1480:e4ac:5765%4]) with mapi id 15.21.0360.005; Wed, 26 Aug 2026 06:11:57 +0000 Message-ID: <09de61d6-7a7c-42ce-bb25-d455a913b506@intel.com> Date: Wed, 26 Aug 2026 14:11:47 +0800 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v6 5/9] x86/resctrl: Parse ACPI CMRC table To: "Luck, Tony" CC: Reinette Chatre , , , , , , , , , , References: <01d48e87-eade-438d-9d33-b1110b6bbfcd@intel.com> <64ac0eaf-c2da-4683-9859-81b46ff325e7@intel.com> <4314ce95-baa9-43cd-ad1c-4e56c07b9556@intel.com> Content-Language: en-US From: "Chen, Yu C" In-Reply-To: Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 8bit X-ClientProxiedBy: SI2PR01CA0051.apcprd01.prod.exchangelabs.com (2603:1096:4:193::6) To DM4PR11MB6020.namprd11.prod.outlook.com (2603:10b6:8:61::19) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DM4PR11MB6020:EE_|DS4PR11MB298041:EE_ X-MS-Office365-Filtering-Correlation-Id: e480d4d4-1d60-4654-a26a-08df0338eeba X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|1800799024|366016|7416014|376014|23010399003|56012099006|10067099003|22082099003|18002099003|11063799006|4143699003; X-Microsoft-Antispam-Message-Info: YQ6oFb+Nuqi/aVxMcjpAThm34FDZpD27ZbnzwAftkPIZSPZ7wEyE/cJCgX2QDv3Xv3zqKIV6gAsTIe05nd8dy3Fbb9WlaVuFRSjaCgfLc/VRU0wCKRgUFKJ/w5jnPkprDvk86QU/P90QmSbkYJ2GKvd8xa9tUa5jsuoTGX3rvZhdAqzSt4Bo7XTFXq3syz85tYqOmKyeyygRX/tww7Yt7FzDnkqKY+pDueJU0+33MLKYgELldA8vumGulkOu2DrZg7Rg46MZeI1KdptXa9VtJeyuGrd2ht6shhBFm0n3XjEYg/nM+w0X3PiDBFGR6d8KNTQ1/xC5oOPb6061F4iOVd+QjJHJTCp3OQMJQFuOCqJQQ2V8hNxecddMHEA2waDZGPz+gO9ZS/VjANAo6eD0Lhf9vpVN6fojHfYMjBvAaB5Fb7n6O8ml23FQdVaXKZ1rTYnf1fQX6bTj9gE1rNKLHJbATgWdmcSHl0UJbTn22HgYB6joEZmV2wJswEaXt8Ako092Qmqwl3nc6Jtyd0wMDbhBTQmg6cumrtcc4l3LJ3crnFvFunSbSUm1xye7/AmFOtmGTT2QVRyhTLx9ITj/L4krw13kyY2Hxo8Fe1k4nIgVK7NzO+EAb0EiZSWuXnw5ywAoeAHDpFhZAFGmNCkMfixvHD3kb3th6HeTCU5AfIE= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DM4PR11MB6020.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(1800799024)(366016)(7416014)(376014)(23010399003)(56012099006)(10067099003)(22082099003)(18002099003)(11063799006)(4143699003);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?cjNaYk5TY2x0ZDJQMWV2RVdVZE9xVmtpcWNsSG0raDNvWW1TQXJobEtvQUdX?= =?utf-8?B?bUpDT1ljdGNsdllOZEZWNjhBNTJEM1JVSnF0QjZ2TGV4OExLMk8vTWFWaHUw?= =?utf-8?B?STFXMVZ3bVJrRXlBdjB0MU4rbGhpcFJ1TWQxYXBmZjRjeFMxejJBRzJoRVIw?= =?utf-8?B?UHdsM0VQUFhhc1BESFdZZ3IrdUFoVWRNTlk1QzRJUGtNQ1NDSkZiM1VCNXZO?= =?utf-8?B?cXhENDNnSVcySDMzb1UwMCtKb2dCT2xjc0FKYVBpWDlpZm1jVzhLdXVTOWNV?= =?utf-8?B?UGl0ajNNcEJjWk9iSDBaSHVqalV5eVpkWDRZYUZFM09ySWxDcG90OWlKMVEy?= =?utf-8?B?ZlRjT3VGdzE4RkRnK1Vxc2V4VmdJcTd2bzRicThMVHQ5NUd4VkpJQmpqcjN6?= =?utf-8?B?dkNQbnVJcEd6N1RKemwvQ0lHMDhrUFUvb3FlZmR2TkswYzlwQ1JCa3Y5VWFW?= =?utf-8?B?cThWc3ZqSmQ3cloxQnc3bXd6Y000b0g0aTJ1bDh3eWptcHhma01pUDZtTHMr?= =?utf-8?B?MVpVTXVCaTZNU0JIbzhQckVZNmVFZ3Z2WDE5emkvMy9RUis1a21sYkdPM3FE?= =?utf-8?B?TTZJYzFIZGNUTzJVUVN2QVdzWTBsejJFaFZqcVhIVzFjazFlWTNya0dNRVdu?= =?utf-8?B?dExUdnNxYUlXOG9oRUl4cHJKODFzVVI3TVFhcWFzcTBkV3BJY2cxSnI0YU5Y?= =?utf-8?B?Y3J6c3ltbFEvWVhXUlZLRTRqTHFyOEpGbDk2MjkwT0JveG56RVQzaUEyV0ds?= =?utf-8?B?THYvVXh3VnFabzl0ajBzU2I4V1ZwTitPSDRXWG5HcjltUFR1MUV0NUNWUzh6?= =?utf-8?B?M3V4WW11QTRnUkNaZDZ4bG83anhWMEZtOGJuVTdpZCsrVjFlTHZlTFhpbUFV?= =?utf-8?B?R0NReHdwbTFEYzQ3MmxRWW5OcVQxdk0wY2RRdUxncU9iVXZmenhPVUJwb1Fm?= =?utf-8?B?TlcvRlRjUXBwRXY4LzFDNm8zaWYyQWkxTEtsVElYT2xmejZzVnVHSDN1QWhQ?= =?utf-8?B?U2JLOVI5RXNOclNERTNDRWV4VS83UUJ6bEhtaW9kZUZBMGhWdlpUN01RRDNs?= =?utf-8?B?UmpCQkw4L1dFdWd4UnU4RnZTOUU3cVJqbUMrUXluZmJ5RTM4NytNaFpGNG9x?= =?utf-8?B?OEUxNjNtV1ZDdW9Hc2txakhyam1xc21hQkhnaEh4c25RU0lzZzRyYTlPY0ZS?= =?utf-8?B?di9sQmU0L2hITzZsTVJac2dVemJKWnc3VFAvQVdxRHNBVFdsUGNCZDBVeW8w?= =?utf-8?B?UWVqckx6dmpkZUxraDl0QmhweUI2cC9BU1ppTElxaTczK25tRE1zdm5wMEY1?= =?utf-8?B?RHNMRVdnYXM5VmdXUWlxcGdUODA2S2V4bkFIdjVTUHgwZ25aZ0JZdUEybGth?= =?utf-8?B?eloyYnBlZWxkWDhhNG9ZSld2OGtPTlNMcks1ZGJHYWZCcVBnR0JkYmlZVXRO?= =?utf-8?B?NTZPWkxlakNVb3BxRFFKUWdtTm9WbWo1TmtwZ2J6V2NGMGR2VjFNTWF1TnQ4?= =?utf-8?B?Y21PZ3kveExmY1Y3Z29WNHJzK0FZbnhBeUt1aGhRMGc3Qk4rRlltU2lkSE5z?= =?utf-8?B?a0ZpU3hzdExpUWFVUTRKWlpqOUszalpzdTJ5QVFyMEJvaThaeWRid2V2ZUpN?= =?utf-8?B?R05qMTN6b2lvcDdINDg1aEptSHdsY0w2d3pmbG9YZUFvZm5CblloWWlJY2kv?= =?utf-8?B?WHN6clN3RGFjR3FoQmlWVmI2Vkk1UlVlVVpIQmtTRXcrd0ZNSDVISHp6RjJi?= =?utf-8?B?eTZ1VlJKTEdCeEQ0MDZ5T0FLdCt0TVdrUGE1YWNuRWhlNG9IdTdHWlJNTk5F?= =?utf-8?B?c2tnRXlLS1B0Mi9vWTM4d2N2SlZnUDJqbWVtMU5QaGFlbStRYURUYkF0My9y?= =?utf-8?B?ZndWQk1qMjh4OHIraVFVUnVzcGNldHhBQWlNZThEUzNHMW8ydUFieENycGNx?= =?utf-8?B?a0VkSmRINUpFZVlnN1BuZ2dzcVNqUFZZQm11eHdZRVJRMTc1M0hlcnp4WXFZ?= =?utf-8?B?MmFoY2NlLzU0RFhPQmtQRHVCak9lNFR3b0w2aUlpTWRrNFVyV2tIdWVkUUdX?= =?utf-8?B?SHpSOFp2aktwMjgzajZCa21XUXdqZUxrQ3dCRFZ3RzVxcEJDVG1zYjlQRDU5?= =?utf-8?B?d1dCY0d5WHN3bW4wU1JDKzRSdzVzNVJ6bzJzZkJwN3BxdWxlajA4QjlEa0ht?= =?utf-8?B?MXMwOFpmN2ZRam5yTC9SY1pQRzhLTE42TERNQk4vaDNIcFYxbWMvYStiY1dy?= =?utf-8?B?YzdXQ0FuZytlaHA0cis5OVNQWURFV0NyYVRoSnJ6cElRRE53ejlJc3IycXNv?= =?utf-8?B?NFdHQ3pIQmZOZlh0elAxOG1CTDFlYUUwcER3NGNVbWVQWncyUmdyQT09?= X-Exchange-RoutingPolicyChecked: zSjoV383XXD2Xooy4tRFapDdR1ICiE+P/zaxSSHtApUP6FE9v/8RM4pMg1HQwOoWJfwIPmaehkGKYKEWyyxTxkgQXbELnzwb+WPpaT6JxovY8dx+E3zb47s6//zrmwdSs5r0NTxDxSJNFoLmEVbtr2lD5zjOjK/7nV4f1oZc/fW1gs3lWquUjeckrD/kVvOX4sFmys2aJ5SVFyBRkGcg2zUL0hnzwIBARdh0NpfvESc68TI5Oy7uzIblbmhEP2XBHZowkGZ6F0ozDYNx+9r68jOQT2A94EFq9Afa40ERTOXvlFFY0mvqaSG6uW6sREN7dyX0RubKVimQdyS7W/JRUg== X-MS-Exchange-CrossTenant-Network-Message-Id: e480d4d4-1d60-4654-a26a-08df0338eeba X-MS-Exchange-CrossTenant-AuthSource: DM4PR11MB6020.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 Aug 2026 06:11:57.0383 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: lwBY334ScxPjt6+0CD+eJKgB/x5plwJNodkeOb/Y8ev+7jwHK5csp9tGfjkanyMqEVnrtOQ9/XsD1zQOs3Q6Aw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS4PR11MB298041 X-OriginatorOrg: intel.com On 8/26/2026 12:38 AM, Luck, Tony wrote: >>>> In theory, we should change the scale type from unsigned int to u64 to accommodate >>>> both the legacy CPUID and CMRC. However, it seems unlikely that the scale would >>>> exceed 32 bits. If the scale were 32 bits, the L3 occupancy would be at least >>>> 2^32 − 1, which is about 4 GB. We have not yet seen platform with 4 GB of L3 cache. >>>> So perhaps we can keep erdt_scale as unsigned int for now IMO. >>> >>> >>> It sounds like you are saying that the spec you are enabling should not be using 64 bits for >>> this value. It is unexpected to me that work on enabling of a spec adds such constraint without >>> clear motivation. If you find that the spec is not correct then I think it would be better to have >>> it changed there instead of building what appears to be unsupported assumptions into resctrl. >>> >> >> OK, let me check with the team. > > Looking at the RDT architecture spec that defines the CMRC table it > looks to me like the "CMT Counter Upscaling Factor" was made 8-bytes > just to round the table out to a whole number or quad-words. > > This value represents the granularity of cache occupancy reporting. > The feature would be worthless if this was >=4GB no matter how large > the LLC cache may be in future generations. > > If large values are a big concern then perhaps include a sanity check > in the code: > > if (cmrc->upscale >= SZ_4G) > pr_warn(FW_BUG "insane CMRC upscale value 0x%llx\n", cmrc->upscale); Got it. The upscale factor should not exceed 32 bits, and the major monitor value should come from the 'counter' part. I'll add the above check in the next version. thanks, Chenyu