From: Krzysztof Kozlowski <krzk@kernel.org>
To: Brian Masney <bmasney@redhat.com>,
Konrad Dybcio <konrad.dybcio@linaro.org>
Cc: andersson@kernel.org, linus.walleij@linaro.org,
agross@kernel.org, linux-arm-msm@vger.kernel.org,
linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] pinctrl: qcom-pmic-gpio: silence -EPROBE_DEFER message on probe
Date: Fri, 18 Aug 2023 15:51:53 +0200 [thread overview]
Message-ID: <09df85cd-27c7-d64c-9792-41110bf32fce@kernel.org> (raw)
In-Reply-To: <ZN5KIlI+RDu92jsi@brian-x1>
On 17/08/2023 18:26, Brian Masney wrote:
> On Thu, Aug 17, 2023 at 05:01:19PM +0200, Konrad Dybcio wrote:
>> On 17.08.2023 16:59, Brian Masney wrote:
>>> The following message shows up one or more times when booting a Qualcomm
>>> SA8775 Development board:
>>>
>>> qcom-spmi-gpio c440000.spmi:pmic@2:gpio@8800: can't add gpio chip
>>>
>>> Convert this over to use dev_err_probe() to silence this message.
>>>
>>> Signed-off-by: Brian Masney <bmasney@redhat.com>
>>> ---
>> That looks odd, why would it ever defer?
>>
>> SPMI should be up by the time it gets a chance to probe.
>
> You replied within the same minute of me posting that patch, which is
> the fastest review I've had to date on an upstream kernel list. Before
> we continue, please verify:
>
> [ ] I am not a robot
>
> :)
>
> So SPMI is up and probes normally the first time, and is up by time this
> driver probes. I think the probe deferral is happening somewhere in
> pinctrl, however I am not sure exactly where. I added some tracers to
> the kernel command line and here's some relevant log messages:
>
> device: 'c440000.spmi:pmic@2:gpio@8800': device_add
> bus: 'platform': add device c440000.spmi:pmic@2:gpio@8800
> PM: Adding info for platform:c440000.spmi:pmic@2:gpio@8800
> bus: 'platform': __driver_probe_device: matched device c440000.spmi:pmic@2:gpio@8800 with driver qcom-spmi-gpio
> bus: 'platform': really_probe: probing driver qcom-spmi-gpio with device c440000.spmi:pmic@2:gpio@8800
> qcom-spmi-gpio c440000.spmi:pmic@2:gpio@8800: no pinctrl handle
> qcom-spmi-gpio c440000.spmi:pmic@2:gpio@8800: try to register 12 pins ...
> pinctrl core: registered pin 0 (gpio1) on c440000.spmi:pmic@2:gpio@8800
> pinctrl core: registered pin 1 (gpio2) on c440000.spmi:pmic@2:gpio@8800
> pinctrl core: registered pin 2 (gpio3) on c440000.spmi:pmic@2:gpio@8800
> pinctrl core: registered pin 3 (gpio4) on c440000.spmi:pmic@2:gpio@8800
> pinctrl core: registered pin 4 (gpio5) on c440000.spmi:pmic@2:gpio@8800
> pinctrl core: registered pin 5 (gpio6) on c440000.spmi:pmic@2:gpio@8800
> pinctrl core: registered pin 6 (gpio7) on c440000.spmi:pmic@2:gpio@8800
> pinctrl core: registered pin 7 (gpio8) on c440000.spmi:pmic@2:gpio@8800
> pinctrl core: registered pin 8 (gpio9) on c440000.spmi:pmic@2:gpio@8800
> pinctrl core: registered pin 9 (gpio10) on c440000.spmi:pmic@2:gpio@8800
> pinctrl core: registered pin 10 (gpio11) on c440000.spmi:pmic@2:gpio@8800
> pinctrl core: registered pin 11 (gpio12) on c440000.spmi:pmic@2:gpio@8800
> qcom-spmi-gpio c440000.spmi:pmic@2:gpio@8800: no hogs found
> qcom-spmi-gpio c440000.spmi:pmic@2:gpio@8800: error -EPROBE_DEFER: can't add gpio chip
> qcom-spmi-gpio c440000.spmi:pmic@2:gpio@8800: Driver qcom-spmi-gpio requests probe deferral
> platform c440000.spmi:pmic@2:gpio@8800: Added to deferred list
>
> The second time it probes the device is successfully added.
There is a bug in DTS. I'll send a patch.
Best regards,
Krzysztof
next prev parent reply other threads:[~2023-08-18 13:52 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-17 14:59 [PATCH] pinctrl: qcom-pmic-gpio: silence -EPROBE_DEFER message on probe Brian Masney
2023-08-17 15:01 ` Konrad Dybcio
2023-08-17 16:26 ` Brian Masney
2023-08-18 13:51 ` Krzysztof Kozlowski [this message]
2023-08-18 13:59 ` Krzysztof Kozlowski
2023-08-21 13:11 ` Brian Masney
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=09df85cd-27c7-d64c-9792-41110bf32fce@kernel.org \
--to=krzk@kernel.org \
--cc=agross@kernel.org \
--cc=andersson@kernel.org \
--cc=bmasney@redhat.com \
--cc=konrad.dybcio@linaro.org \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.