From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Yang, Wenyou" Date: Mon, 08 Jan 2018 00:58:21 +0000 Subject: Re: [PATCH] mtd/nand/atmel: Delete an error message for a failed memory allocation in two functions Message-Id: <09e98604-00ec-64be-665a-a101b31028b1@Microchip.com> List-Id: References: <81cadb76-8c67-9289-1375-2d4a55a4adfa@users.sourceforge.net> In-Reply-To: <81cadb76-8c67-9289-1375-2d4a55a4adfa@users.sourceforge.net> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: linux-arm-kernel@lists.infradead.org On 2018/1/6 4:55, SF Markus Elfring wrote: > From: Markus Elfring > Date: Fri, 5 Jan 2018 21:45:04 +0100 > > Omit an extra message for a memory allocation failure in these functions. > > This issue was detected by using the Coccinelle software. > > Signed-off-by: Markus Elfring > --- Acked-by: Wenyou Yang > drivers/mtd/nand/atmel/nand-controller.c | 8 ++------ > 1 file changed, 2 insertions(+), 6 deletions(-) > > diff --git a/drivers/mtd/nand/atmel/nand-controller.c b/drivers/mtd/nand/atmel/nand-controller.c > index 90a71a56bc23..a41b999229c9 100644 > --- a/drivers/mtd/nand/atmel/nand-controller.c > +++ b/drivers/mtd/nand/atmel/nand-controller.c > @@ -1612,10 +1612,8 @@ static int atmel_nand_register(struct atmel_nand *nand) > mtd->name = devm_kasprintf(nc->dev, GFP_KERNEL, > "%s:nand.%d", dev_name(nc->dev), > nand->cs[0].id); > - if (!mtd->name) { > - dev_err(nc->dev, "Failed to allocate mtd->name\n"); > + if (!mtd->name) > return -ENOMEM; > - } > } > > ret = nand_scan_tail(mtd); > @@ -1654,10 +1652,8 @@ static struct atmel_nand *atmel_nand_create(struct atmel_nand_controller *nc, > nand = devm_kzalloc(nc->dev, > sizeof(*nand) + (numcs * sizeof(*nand->cs)), > GFP_KERNEL); > - if (!nand) { > - dev_err(nc->dev, "Failed to allocate NAND object\n"); > + if (!nand) > return ERR_PTR(-ENOMEM); > - } > > nand->numcs = numcs; > Best Regards, Wenyou Yang From mboxrd@z Thu Jan 1 00:00:00 1970 Subject: Re: [PATCH] mtd/nand/atmel: Delete an error message for a failed memory allocation in two functions To: SF Markus Elfring , , , Alexandre Belloni , Boris Brezillon , Brian Norris , Cyrille Pitchen , David Woodhouse , Josh Wu , Marek Vasut , Nicolas Ferre , Richard Weinberger , Wenyou Yang CC: LKML , References: <81cadb76-8c67-9289-1375-2d4a55a4adfa@users.sourceforge.net> From: "Yang, Wenyou" Message-ID: <09e98604-00ec-64be-665a-a101b31028b1@Microchip.com> Date: Mon, 8 Jan 2018 08:58:21 +0800 MIME-Version: 1.0 In-Reply-To: <81cadb76-8c67-9289-1375-2d4a55a4adfa@users.sourceforge.net> Content-Type: text/plain; charset="utf-8"; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-US List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On 2018/1/6 4:55, SF Markus Elfring wrote: > From: Markus Elfring > Date: Fri, 5 Jan 2018 21:45:04 +0100 > > Omit an extra message for a memory allocation failure in these functions. > > This issue was detected by using the Coccinelle software. > > Signed-off-by: Markus Elfring > --- Acked-by: Wenyou Yang > drivers/mtd/nand/atmel/nand-controller.c | 8 ++------ > 1 file changed, 2 insertions(+), 6 deletions(-) > > diff --git a/drivers/mtd/nand/atmel/nand-controller.c b/drivers/mtd/nand/atmel/nand-controller.c > index 90a71a56bc23..a41b999229c9 100644 > --- a/drivers/mtd/nand/atmel/nand-controller.c > +++ b/drivers/mtd/nand/atmel/nand-controller.c > @@ -1612,10 +1612,8 @@ static int atmel_nand_register(struct atmel_nand *nand) > mtd->name = devm_kasprintf(nc->dev, GFP_KERNEL, > "%s:nand.%d", dev_name(nc->dev), > nand->cs[0].id); > - if (!mtd->name) { > - dev_err(nc->dev, "Failed to allocate mtd->name\n"); > + if (!mtd->name) > return -ENOMEM; > - } > } > > ret = nand_scan_tail(mtd); > @@ -1654,10 +1652,8 @@ static struct atmel_nand *atmel_nand_create(struct atmel_nand_controller *nc, > nand = devm_kzalloc(nc->dev, > sizeof(*nand) + (numcs * sizeof(*nand->cs)), > GFP_KERNEL); > - if (!nand) { > - dev_err(nc->dev, "Failed to allocate NAND object\n"); > + if (!nand) > return ERR_PTR(-ENOMEM); > - } > > nand->numcs = numcs; > Best Regards, Wenyou Yang From mboxrd@z Thu Jan 1 00:00:00 1970 From: Wenyou.Yang@Microchip.com (Yang, Wenyou) Date: Mon, 8 Jan 2018 08:58:21 +0800 Subject: [PATCH] mtd/nand/atmel: Delete an error message for a failed memory allocation in two functions In-Reply-To: <81cadb76-8c67-9289-1375-2d4a55a4adfa@users.sourceforge.net> References: <81cadb76-8c67-9289-1375-2d4a55a4adfa@users.sourceforge.net> Message-ID: <09e98604-00ec-64be-665a-a101b31028b1@Microchip.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On 2018/1/6 4:55, SF Markus Elfring wrote: > From: Markus Elfring > Date: Fri, 5 Jan 2018 21:45:04 +0100 > > Omit an extra message for a memory allocation failure in these functions. > > This issue was detected by using the Coccinelle software. > > Signed-off-by: Markus Elfring > --- Acked-by: Wenyou Yang > drivers/mtd/nand/atmel/nand-controller.c | 8 ++------ > 1 file changed, 2 insertions(+), 6 deletions(-) > > diff --git a/drivers/mtd/nand/atmel/nand-controller.c b/drivers/mtd/nand/atmel/nand-controller.c > index 90a71a56bc23..a41b999229c9 100644 > --- a/drivers/mtd/nand/atmel/nand-controller.c > +++ b/drivers/mtd/nand/atmel/nand-controller.c > @@ -1612,10 +1612,8 @@ static int atmel_nand_register(struct atmel_nand *nand) > mtd->name = devm_kasprintf(nc->dev, GFP_KERNEL, > "%s:nand.%d", dev_name(nc->dev), > nand->cs[0].id); > - if (!mtd->name) { > - dev_err(nc->dev, "Failed to allocate mtd->name\n"); > + if (!mtd->name) > return -ENOMEM; > - } > } > > ret = nand_scan_tail(mtd); > @@ -1654,10 +1652,8 @@ static struct atmel_nand *atmel_nand_create(struct atmel_nand_controller *nc, > nand = devm_kzalloc(nc->dev, > sizeof(*nand) + (numcs * sizeof(*nand->cs)), > GFP_KERNEL); > - if (!nand) { > - dev_err(nc->dev, "Failed to allocate NAND object\n"); > + if (!nand) > return ERR_PTR(-ENOMEM); > - } > > nand->numcs = numcs; > Best Regards, Wenyou Yang