All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Christian König" <christian.koenig@amd.com>
To: Alex Deucher <alexander.deucher@amd.com>, amd-gfx@lists.freedesktop.org
Cc: Srinivasan Shanmugam <srinivasan.shanmugam@amd.com>
Subject: Re: [PATCH 1/2] drm/amdgpu/mes11: fix set_hw_resources_1 calculation
Date: Mon, 10 Feb 2025 20:41:21 +0100	[thread overview]
Message-ID: <09f3506d-c85f-4cee-9013-3a3a1a05085a@amd.com> (raw)
In-Reply-To: <20250210162755.2488728-1-alexander.deucher@amd.com>

Am 10.02.25 um 17:27 schrieb Alex Deucher:
> It's GPU page size not CPU page size.  In most cases they
> are the same, but not always.  This can lead to overallocation
> on systems with larger pages.
>
> Cc: Srinivasan Shanmugam <srinivasan.shanmugam@amd.com>
> Cc: Christian König <christian.koenig@amd.com>
> Signed-off-by: Alex Deucher <alexander.deucher@amd.com>

Reviewed-by: Christian König <christian.koenig@amd.com>

> ---
>   drivers/gpu/drm/amd/amdgpu/mes_v11_0.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/amd/amdgpu/mes_v11_0.c b/drivers/gpu/drm/amd/amdgpu/mes_v11_0.c
> index bf51f3dcc130e..e862a3febe2b2 100644
> --- a/drivers/gpu/drm/amd/amdgpu/mes_v11_0.c
> +++ b/drivers/gpu/drm/amd/amdgpu/mes_v11_0.c
> @@ -743,7 +743,7 @@ static int mes_v11_0_set_hw_resources(struct amdgpu_mes *mes)
>   
>   static int mes_v11_0_set_hw_resources_1(struct amdgpu_mes *mes)
>   {
> -	int size = 128 * PAGE_SIZE;
> +	int size = 128 * AMDGPU_GPU_PAGE_SIZE;
>   	int ret = 0;
>   	struct amdgpu_device *adev = mes->adev;
>   	union MESAPI_SET_HW_RESOURCES_1 mes_set_hw_res_pkt;


  parent reply	other threads:[~2025-02-10 19:41 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-02-10 16:27 [PATCH 1/2] drm/amdgpu/mes11: fix set_hw_resources_1 calculation Alex Deucher
2025-02-10 16:27 ` [PATCH V4 2/2] drm/amdgpu/mes: Add cleaner shader fence address handling in MES for GFX11 Alex Deucher
2025-02-10 18:49   ` Liu, Shaoyun
2025-02-10 20:10     ` Alex Deucher
2025-02-10 19:42   ` Christian König
2025-02-10 19:41 ` Christian König [this message]
  -- strict thread matches above, loose matches on Subject: below --
2025-02-07 14:43 [PATCH 1/2] drm/amdgpu/mes11: fix set_hw_resources_1 calculation Alex Deucher

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=09f3506d-c85f-4cee-9013-3a3a1a05085a@amd.com \
    --to=christian.koenig@amd.com \
    --cc=alexander.deucher@amd.com \
    --cc=amd-gfx@lists.freedesktop.org \
    --cc=srinivasan.shanmugam@amd.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.