From: James Prestwood <prestwoj@gmail.com>
To: Andrea Covelli <andcov23@gmail.com>
Cc: Johannes Berg <johannes@sipsolutions.net>,
linux-wireless@vger.kernel.org,
Kavita Kavita <kavita.kavita@oss.qualcomm.com>,
Sai Pratyusha Magam <sai.magam@oss.qualcomm.com>
Subject: Re: [PATCH] wifi: mac80211: defer AP-side FT key upload until association
Date: Tue, 11 Aug 2026 11:36:56 -0700 [thread overview]
Message-ID: <09fdf1b1-8025-48a7-b479-8edfd625a561@gmail.com> (raw)
In-Reply-To: <20260811182545.256241-1-andcov23@gmail.com>
Hi Andrea,
On 8/11/26 11:25 AM, Andrea Covelli wrote:
> Hi James,
>
>> Another case I forgot to mention is the client will FT roam and
>> immediately start dropping _ALL_ IP traffic (despite the 802.11 layer
>> remaining connected/stable). We've seen this with several vendors and
>> actually had to create a watchdog to monitor for this situation and force
>> a deauth on the client side. I wonder if this is closer to the issue here.
> Yes, that is much closer to the failure mode I would expect here. The FT
> reassociation can complete because the initial set_key() failure is not
> propagated as an association failure. After calling the void
> wpa_ft_install_ptk() helper on WPA_ASSOC_FT, the caller unconditionally sets
> sm->ft_completed = 1; there is no success value to check. If that retry also
> fails, the AP and station can remain associated at the 802.11 state-machine
> level while the AP has no usable PTK, leaving the protected data path
> inoperable until a disconnect and reassociation.
>
> That does not establish that the vendor APs you observed hit this exact
> mac80211 ASSOC gate; a different key/peer ordering bug, or another data-path
> problem, could produce the same symptom. For this specific race, the strongest
> signature would be a successful FT reassociation followed by no working
> protected data, together with a failed pre-association key installation and a
> failed or absent post-association retry on the AP.
>
> Even without useful AP logs, a station-side monitor capture covering the FT
> exchange through the watchdog-triggered deauthentication could help narrow
> this down. In particular, protected data continuing to be transmitted and
> acknowledged at the 802.11 layer without any higher-layer response would be
> consistent with a key/data-path failure on the AP.
This is great to hear. Getting a monitor capture is tricky since its not
a consistent problem, but I will try and get this either way.
I really appreciate the context here, we've been struggling with this
issue for years with no help from vendors. This is the biggest break
I've gotten.
Thanks,
James
>
> Thanks,
> Andrea
prev parent reply other threads:[~2026-08-11 18:37 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-30 16:14 [PATCH] wifi: mac80211: defer AP-side FT key upload until association andcov23
2026-07-30 16:21 ` Johannes Berg
2026-07-30 17:00 ` Andrea Covelli
2026-07-30 18:54 ` Johannes Berg
2026-08-03 22:30 ` Andrea Covelli
2026-08-11 15:42 ` Andrea Covelli
2026-08-11 16:38 ` James Prestwood
2026-08-11 17:35 ` Andrea Covelli
2026-08-11 17:44 ` James Prestwood
2026-08-11 18:25 ` Andrea Covelli
2026-08-11 18:36 ` James Prestwood [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=09fdf1b1-8025-48a7-b479-8edfd625a561@gmail.com \
--to=prestwoj@gmail.com \
--cc=andcov23@gmail.com \
--cc=johannes@sipsolutions.net \
--cc=kavita.kavita@oss.qualcomm.com \
--cc=linux-wireless@vger.kernel.org \
--cc=sai.magam@oss.qualcomm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.