From: zhang warden <zhangwarden@gmail.com>
To: Miroslav Benes <mbenes@suse.cz>
Cc: Petr Mladek <pmladek@suse.com>,
Josh Poimboeuf <jpoimboe@kernel.org>,
Jiri Kosina <jikos@kernel.org>,
Joe Lawrence <joe.lawrence@redhat.com>,
live-patching@vger.kernel.org,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] livepatch: introduce klp_func called interface
Date: Tue, 4 Jun 2024 16:17:01 +0800 [thread overview]
Message-ID: <0C2ABDBE-FBBA-4CD6-A903-B146EBBF4AC8@gmail.com> (raw)
In-Reply-To: <alpine.LSU.2.21.2405311603260.8344@pobox.suse.cz>
> On May 31, 2024, at 22:06, Miroslav Benes <mbenes@suse.cz> wrote:
>
>> And for the unlikely branch, isn’t the complier will compile this branch
>> into a cold branch that will do no harm to the function performance?
>
> The test (cmp insn or something like that) still needs to be there. Since
> there is only a simple assignment in the branch, the compiler may just
> choose not to have a cold branch in this case. The only difference is in
> which case you would jump here. You can see for yourself (and prove me
> wrong if it comes to it).
>
> Miroslav
Hi Miroslav,
Yes, more tests should be done in this case according to your opinion.
Regards,
Wardenjohn
next prev parent reply other threads:[~2024-06-04 8:17 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-20 0:58 [PATCH] livepatch: introduce klp_func called interface Wardenjohn
2024-05-20 6:46 ` Miroslav Benes
2024-05-20 7:10 ` zhang warden
2024-05-21 6:34 ` Miroslav Benes
2024-05-21 8:04 ` Petr Mladek
2024-05-24 8:09 ` zhang warden
2024-05-31 2:16 ` zhang warden
2024-05-31 7:21 ` Miroslav Benes
2024-05-31 13:19 ` zhang warden
2024-05-31 14:06 ` Miroslav Benes
2024-06-04 8:17 ` zhang warden [this message]
2024-06-05 5:04 ` Song Liu
2024-06-07 9:07 ` Miroslav Benes
2024-06-07 16:59 ` Song Liu
2024-06-11 2:23 ` zhang warden
2024-06-20 3:39 ` zhang warden
2024-06-20 9:31 ` Miroslav Benes
2024-05-31 19:16 ` Joe Lawrence
2024-06-04 8:14 ` zhang warden
2024-06-04 11:01 ` zhang warden
2024-06-04 14:37 ` Joe Lawrence
2024-06-05 2:38 ` zhang warden
2024-06-06 15:01 ` Joe Lawrence
2024-06-07 2:26 ` zhang warden
2024-05-20 8:00 ` Markus Elfring
2024-05-20 9:34 ` zhang warden
-- strict thread matches above, loose matches on Subject: below --
2024-05-19 7:43 Wardenjohn
2024-05-19 18:05 ` Markus Elfring
2024-05-19 23:42 ` zhang warden
2024-05-23 14:22 ` Dan Carpenter
2024-05-24 8:12 ` zhang warden
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0C2ABDBE-FBBA-4CD6-A903-B146EBBF4AC8@gmail.com \
--to=zhangwarden@gmail.com \
--cc=jikos@kernel.org \
--cc=joe.lawrence@redhat.com \
--cc=jpoimboe@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=live-patching@vger.kernel.org \
--cc=mbenes@suse.cz \
--cc=pmladek@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.