Re: [PATCH bpf-next] libbpf: remove sample_period init in perf_buffer

[Tao Chen <chen.dylane@linux.dev>]

在 2025/4/24 00:39, Tao Chen 写道:

ping...

> It seems that sample_period no used in perf buffer, actually only
> wakeup_events valid about events aggregation for wakeup. So remove
> it to avoid causing confusion.
> 
> Fixes: fb84b8224655 ("libbpf: add perf buffer API")
> Acked-by: Jiri Olsa <jolsa@kernel.org>
> Acked-by: Namhyung Kim <namhyung@kernel.org>
> Signed-off-by: Tao Chen <chen.dylane@linux.dev>
> ---
>   tools/lib/bpf/libbpf.c | 1 -
>   1 file changed, 1 deletion(-)
> 
> diff --git a/tools/lib/bpf/libbpf.c b/tools/lib/bpf/libbpf.c
> index 194809da5172..1830e3c011a5 100644
> --- a/tools/lib/bpf/libbpf.c
> +++ b/tools/lib/bpf/libbpf.c
> @@ -13306,7 +13306,6 @@ struct perf_buffer *perf_buffer__new(int map_fd, size_t page_cnt,
>   	attr.config = PERF_COUNT_SW_BPF_OUTPUT;
>   	attr.type = PERF_TYPE_SOFTWARE;
>   	attr.sample_type = PERF_SAMPLE_RAW;
> -	attr.sample_period = sample_period;
>   	attr.wakeup_events = sample_period;
>   
>   	p.attr = &attr;


-- 
Best Regards
Tao Chen