From: Tirumala Marri <tmarri@apm.com>
To: greg@kroah.com
Cc: linux-usb@vger.kernel.org, linuxppc-dev@lists.ozlabs.org
Subject: RE: [PATCH v15 00/10] Add-Synopsys-DesignWare-HS-USB-OTG-driver
Date: Wed, 26 Oct 2011 10:17:19 -0700 [thread overview]
Message-ID: <0a2f495d6415e9cad48ae2c75c582e0d@mail.gmail.com> (raw)
In-Reply-To: <CAOesGMhVuxbqq7cmm2XVUof9vEifAL=GpPirYb8148a24upJCw@mail.gmail.com>
Greg,
<
<No, just start over from scratch. Just leave the crap driver behind,
<use it for reference but write the new one.
<
<It's obvious given that you are already at iteration v15 and it's
<still looking this bad that this is not realistic to get reviewed and
<accepted as-is. I don't think staging is a good target either -- what
<the driver really needs is _functional_ cut-down to only cover the use
<cases that your product uses, and staging cleanups are mostly around
<style and refactoring, not changing, fixing or removing functionality.
<
<> <Compare this to the dwc3 driver, which is much much cleaner.
<> <
Could you please comment on this. This has been reviewed so many times
And we did the major changes. I think it is un-acceptable to say to
re-write
The driver now after 15 reviews? This should have happened in first 5
reviews.
Thx,
Marri
next prev parent reply other threads:[~2011-10-26 17:17 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-10-14 22:08 [PATCH v15 00/10] Add-Synopsys-DesignWare-HS-USB-OTG-driver tmarri
2011-10-21 3:48 ` Pratyush Anand
2011-10-25 22:45 ` Tirumala Marri
2011-10-21 17:33 ` Olof Johansson
2011-10-22 20:30 ` Olof Johansson
2011-10-27 5:07 ` Pratyush Anand
2011-10-25 21:54 ` Tirumala Marri
2011-10-26 12:04 ` Olof Johansson
2011-10-26 16:06 ` Tirumala Marri
2011-10-27 3:52 ` Geoff Levand
2011-10-26 17:17 ` Tirumala Marri [this message]
2011-10-27 4:51 ` Greg KH
2011-10-28 0:25 ` Tirumala Marri
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0a2f495d6415e9cad48ae2c75c582e0d@mail.gmail.com \
--to=tmarri@apm.com \
--cc=greg@kroah.com \
--cc=linux-usb@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.