From: "Gilad Broner" <gbroner@codeaurora.org>
To: Steven Rostedt <rostedt@goodmis.org>
Cc: Gilad Broner <gbroner@codeaurora.org>,
james.bottomley@hansenpartnership.com,
linux-kernel@vger.kernel.org, linux-scsi@vger.kernel.org,
linux-arm-msm@vger.kernel.org, santoshsy@gmail.com,
linux-scsi-owner@vger.kernel.org, subhashj@codeaurora.org,
ygardi@codeaurora.org, draviv@codeaurora.org,
Lee Susman <lsusman@codeaurora.org>,
Sujit Reddy Thumma <sthumma@codeaurora.org>,
Vinayak Holikatti <vinholikatti@gmail.com>,
"James E.J. Bottomley" <jbottomley@parallels.com>,
Ingo Molnar <mingo@redhat.com>
Subject: Re: [PATCH v3 3/4] scsi: ufs: add trace events and dump prints for debug
Date: Sun, 1 Mar 2015 08:33:49 -0000 [thread overview]
Message-ID: <0a3014d48540bedb0ca333903934c40e.squirrel@codeaurora.org> (raw)
In-Reply-To: <20150223121242.08d4c008@gandalf.local.home>
> If I understand the patch above, you basically have:
>
> if (....)
> goto out;
> else
> ret = ufshcd_resume();
> out:
>
> Wouldn't it be better to just reverse the above if condition?
>
> if (!...)
> ret = ufshcd_resume();
>
> That would be much less confusing.
It gives a logical place to put the comment, but I agree it will be
less confusing the other way.
I will fix this in the next patchset.
--
Qualcomm Israel, on behalf of Qualcomm Innovation Center, Inc.
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
a Linux Foundation Collaborative Project
next prev parent reply other threads:[~2015-03-01 8:33 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-02-23 8:08 [PATCH v3 0/4] Add ioctl and debug utilities to UFS driver Gilad Broner
2015-02-23 8:08 ` [PATCH v3 1/4] scsi: ufs: add ioctl interface for query request Gilad Broner
2015-02-23 8:08 ` Gilad Broner
2015-02-23 9:16 ` Dov Levenglick
2015-02-23 8:08 ` [PATCH v3 2/4] scsi: ufs: add debugfs for ufs Gilad Broner
2015-02-23 9:15 ` Dov Levenglick
2015-02-23 9:15 ` Dov Levenglick
2015-02-24 15:10 ` Akinobu Mita
2015-03-01 8:29 ` Gilad Broner
2015-02-23 8:08 ` [PATCH v3 3/4] scsi: ufs: add trace events and dump prints for debug Gilad Broner
2015-02-23 9:15 ` Dov Levenglick
2015-02-23 9:15 ` Dov Levenglick
2015-02-23 11:51 ` Steven Rostedt
2015-02-23 17:12 ` Steven Rostedt
2015-03-01 8:33 ` Gilad Broner [this message]
2015-02-23 8:08 ` [PATCH v3 4/4] scsi: ufs: inject errors to verify error handling Gilad Broner
2015-02-23 9:10 ` Dov Levenglick
2015-02-23 9:10 ` [PATCH v3 0/4] Add ioctl and debug utilities to UFS driver Dov Levenglick
2015-02-23 9:10 ` Dov Levenglick
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0a3014d48540bedb0ca333903934c40e.squirrel@codeaurora.org \
--to=gbroner@codeaurora.org \
--cc=draviv@codeaurora.org \
--cc=james.bottomley@hansenpartnership.com \
--cc=jbottomley@parallels.com \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi-owner@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=lsusman@codeaurora.org \
--cc=mingo@redhat.com \
--cc=rostedt@goodmis.org \
--cc=santoshsy@gmail.com \
--cc=sthumma@codeaurora.org \
--cc=subhashj@codeaurora.org \
--cc=vinholikatti@gmail.com \
--cc=ygardi@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.