Re: [PATCH 00/15] Intel IPU6 and IPU6 input system drivers

[Bingbu Cao <bingbu.cao@linux.intel.com>]

Claus,


On 8/21/23 11:14 AM, Bingbu Cao wrote:
> Hi, Claus,
> 
> Thanks for your mail.
> 
> On 8/20/23 11:09 PM, Claus Stovgaard wrote:
>> On Thu, 2023-07-27 at 15:15 +0800, bingbu.cao@intel.com wrote:
>>> From: Bingbu Cao <bingbu.cao@intel.com>
>>>
>>> This patch series adds a driver for Intel IPU6 input system.
>>> IPU6 is the sixth generation of Imaging Processing Unit, it is a PCI
>>> device which can be found in some Intel Client Platforms. User can
>>> use
>>> IPU6 to capture images from MIPI camera sensors.
>>>
>>>
>>
>> Hello Bingbu.
>>
>> First thanks for your work in upstreaming the IPU6 isys driver, and the
>> updates with v1 of the patch series.
>>
>> I am trying to test it on a Dell XPS 9320 (0AF3) laptop
>>
>> First - The patch series does not apply cleanly on linus 6.5-rc6, nor
>> the linux-media master.
> 
> I think it is caused by some media changes was queued after I send
> this patch - such as ipu-bridge, ivsc, v4l2-async, etc. So it
> needs some rebase work.
> 
>>
>> For v6.5-rc6 I have an issue with
>>
>> Patch failed at 0012 media: add Kconfig and Makefile for IPU6
>> When you have resolved this problem, run "git am --continue".
>> If you prefer to skip this patch, run "git am --skip" instead.
>> To restore the original branch and stop patching, run "git am --abort".
>> error: drivers/media/pci/intel/Kconfig: does not exist in index
>> error: patch failed: drivers/media/pci/intel/Makefile:4
>> error: drivers/media/pci/intel/Makefile: patch does not apply
>>
>> For linux media it fails after commit 
>> https://git.linuxtv.org/media_tree.git/commit/?id=dd61c2a380037166517214957790a1486ae5d348
>> media: mediatek: vcodec: Consider vdecsys presence in reg range check
>>
>> As next commit is
>> https://git.linuxtv.org/media_tree.git/commit/?id=bda8953e8c3e7ecbbf6cb1be11790496300e3961
>> media: v4l: async: Drop v4l2_async_nf_parse_fwnode_endpoints()
>>
>> It fails on the v4l parts, and of cause the newer commits regarding
>> v4l: async in the linux-media master branch. So the IPU6 patch series
>> need a refresh to fit the linux-media.
>>
>> I did a custom branch from linus tag v6.5-rc5 with the commits from
>> linux-media up to the "Drop v4l2_async_nf_parse_fwnode_endpoints()" and
>> then applied the IPU6 patches on top.
>> https://github.com/frosteyes/linux/tree/fe/v6.5-rc5/media_test
>>
>> With this I am able to load the IPU6 modules, but I have problems with
>> the sensor.
>>
>> The sensor module is loaded - named ov01a10 but the probe function is
>> not run - as far as I can see
>>
>> Also in /sys/kernel/debug/v4l2-async/pending_async_subdevices I have it
>> as pending
>>
>> ipu6:
>>  [fwnode] dev=nil, node=\_SB.PC00.LNK1
>>
>> Looking at the /sys/bus/acpi/devices I can see the sensor device with a
>> status of 15 (cat OVTI01A0\:00/status)
>>
>> Will continue investigating, but I would like any input in getting the
>> driver up an running and testing on this Dell laptop. I think it should
>> be very close to working.
> 
> Do you any failure log for ov01a10?
> 
> For Dell XPS 9320, the camera sensor module has a dependency on Intel
> IVSC driver, so please make sure you have the latest ivsc driver.
> I remember they are already in media tree.
> 
> I will check again with latest IVSC driver, feel free to mail me or
> Wentong Wu meanwhile if you have any problems for camera sensor and
> IVSC.

I see that the ivsc driver has not been in master branch. Before that,
could you try several hack to check whether camera can work on master?

https://github.com/bingbucao/linux/commits/ipu_dev

7ebff51284d9 media: ov01a10: hack ivsc to make camera can work
01cc9f3d1b61 i2c: ljca: Call acpi_dev_clear_dependencies()
92e5d122e105 vsc: Defer firmware loading to avoid long probing time
5f5d5f0df06b driver: ivsc: add intel ivsc driver
0f4819dec533 Revert "gpio: Add support for Intel LJCA USB GPIO driver"

> 
>>
>> Regards
>> Claus Stovgaaard
>>
> 

-- 
Best regards,
Bingbu Cao