From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ed1-f42.google.com (mail-ed1-f42.google.com [209.85.208.42]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 59B4B179953; Sat, 8 Jun 2024 13:57:39 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.42 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1717855060; cv=none; b=Vl1pwmKN3PN+jNXzJxqRt5v9+3v04TLpZXjDnmFJsXASl7W05r46rhXKrkC/j03FVQamx8DB1CcLWwtFMFQqFDPHDbMpmEK5P6LfFMXmxHVHjfKiB8xEytCgdvAN+somT18DNNd6h028kz/MXhlk5wtctDyXPBjDLt8RGLV0l14= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1717855060; c=relaxed/simple; bh=2UM4TkAgmyxv6SDb5F+kaL1JQiFce8cl1rLs6OODL04=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=iYKGWTSJtiLs7MauF4+yUpOxLu4/eRh+S6H/w5rjfZwOaFC4fOAcR9lChY4QPUMkv4xAtt/N1rezMNSjuOI60jlYFodvir0aGDHlie1geHcbf3rCq9viV1j3E8DtiePHQevCKob1yd1k8Q0cZ2nXSuVsYLDEKaHiHNdY5r5qw2A= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=CK6JmMcY; arc=none smtp.client-ip=209.85.208.42 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="CK6JmMcY" Received: by mail-ed1-f42.google.com with SMTP id 4fb4d7f45d1cf-57c5920ed3bso1361272a12.2; Sat, 08 Jun 2024 06:57:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1717855058; x=1718459858; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=ATHWp/dx9XNWFfxqyNzwyLWvmPFO9JtEj/8KGLy30MQ=; b=CK6JmMcY6G1IUJkxdD5nja9MTv9JGjXzqp25xJKS18ljXbSt04Q33eOXm+kLBdGE3c Mha6Miaujkoc54ZoikMKqS1rl8JozI32iH24hHlM1TeiL3MCvsF+6bkDfLBX+ST/I9rW ZL6LzQIY9v9o+rJ2lUMDbauBCWk2VRRpM4WGYtczqj8AlmShfmTdoVRmqN2JxxUJdOEG tIPVJsHRse3wNj7Cypo+tgWZ7aIKE3iC7D4jYvpECv88uDNIPPzohJN2kQWID24s6HuN IC8KQDWcMqbJknyZPxDW8Nc2KqoVIM6ccE8PyLoUPhu2xcFB8DyOxVP61fxK8DCCBAjP Mteg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1717855058; x=1718459858; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=ATHWp/dx9XNWFfxqyNzwyLWvmPFO9JtEj/8KGLy30MQ=; b=RupLXrBfF+TJ3mtfFPjd3HE83ju5m7vxsGYZp7OHzhXb3JfI5Ci59gRQQ9xKZF41lZ Faw3H0V+8URkOU15OlKXk7tQfrqzJCTqVlCVe69T3njtlepXpcVcnAY9k1kpeBonF9uk A7TXrDADNf3Xt3OMlyIzEHGo7bWwREvnR6pNs1whZqUWVe58mYDzNzvaQEtmFWV0HIfT TJWQsnjWiQ6SECP1P5rXrQ2YQXQZRO4QTwYr5+v3iQgpwniyjBo51ekBKMfWapOSToYN IpnKVu7Wb1tKeYUW9G7G1G8YmFl7C8zR/sr2L+G29CuLP0+jcIf2fkabobaGY05if4TF 7lQw== X-Forwarded-Encrypted: i=1; AJvYcCXrH3eLHIvURXTTGUlYoauk5kGE5HsN0K04cTcTcCDTs729zW28H+WOEf2eVvPYI7V4NMVftBJhBoJ253TKKCEsisGuKzC8cZJTeWnbBg8= X-Gm-Message-State: AOJu0YxtzP455vjQKc1Epl6PCJpl9QGZQKXE3CGp2SivMRNBO5FZzNyT UMgzFgRNLSpbIKnYRz/IR1IMmngtkNZa4mcwpgtO5GovmvOXAwgk X-Google-Smtp-Source: AGHT+IHu1PowfDXRPVKxaC2rG5ito/4e7ETPFqVb1Wv2SDwuvHewQVtdPwJZiBgS6ziT6RxESzzQ7A== X-Received: by 2002:a50:d50e:0:b0:579:ca97:da1b with SMTP id 4fb4d7f45d1cf-57c5084e0damr2882721a12.6.1717855057289; Sat, 08 Jun 2024 06:57:37 -0700 (PDT) Received: from [10.5.1.156] (188-22-218-164.adsl.highway.telekom.at. [188.22.218.164]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-57aae12ce21sm4292594a12.49.2024.06.08.06.57.36 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 08 Jun 2024 06:57:37 -0700 (PDT) Message-ID: <0a45a87f-84d1-4fb7-adaf-c612af68cd40@gmail.com> Date: Sat, 8 Jun 2024 15:57:36 +0200 Precedence: bulk X-Mailing-List: rust-for-linux@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 1/1] arm: rust: Enable Rust support for ARMv7 To: Miguel Ojeda , Jamie Cunliffe Cc: linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, rust-for-linux@vger.kernel.org, Miguel Ojeda , Sven Van Asbroeck References: <4e0f5932-c7bc-4878-862c-1186cbecd71d@gmail.com> Content-Language: en-US From: Christian Schrefl In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit On 08.06.24 2:16 PM, Miguel Ojeda wrote: > On Sat, Jun 8, 2024 at 12:30 AM Christian Schrefl > wrote: >> >> This is based on the code by Sven Van Asbroeck from the original >> rust branch and inspired by the AArch version by Jamie Cunliffe. > > Thanks for mentioning that! > > (AArch64 perhaps?) Ah yes I meant AArch64. Fixed it locally. >> I have tested the rust samples and a custom simple MMIO module >> on on hardware (De1SoC FPGA + Arm A9 CPU). > > Very nice to have tested it in real hardware, thanks! > > (Duplicate "on on"). I fixed that locally, but forgot to run format-patch again, sorry! >> +``arm`` Maintained ARMv7 Little Endian only. > > How hard would it be to test and maintain other versions, eventually? > I met Jamie recently, he may have some ideas here. I think it would just be setting the correct rust target, but I have no hardware to test it and I think its best to only do v7 for the initial support. >> -BINDGEN_TARGET_arm64 := aarch64-linux-gnu >> +BINDGEN_TARGET_arm64:= aarch64-linux-gnu > > Spurious change? I've changed that so the := aligns with the others, but I can remove that for v2 if you want >> +# Depending on how the architecute defines ARCH_SLAB_MINALIGN, bindgen might generate a binding. >> +# Disable this here as there is a const that will always be generated in bindings_helper.c > > Typo in "architecute". Also, I guess you mean `.h` instead. Please use > Markdown formatting for consistency with the rest of the file. Fixed. >> + panic!("arm uses the builtin rustc target"); > > Since ARM64 puts the name of the target in the message, it would be > nice to do the same (or perhaps it can be removed from the ARM64 one > otherwise). I can add the target here but then the message would have to depend on the sub architecture if we support v6 in the future. > Cheers, > Miguel From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 4E3B0C27C5F for ; Sat, 8 Jun 2024 13:58:01 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To: Subject:MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=v/Bce+hG6zUCNqFyiDuUY/joZMr6cNDN+Yg3DyvREZA=; b=ng+BvNcEXrBsv3 VKbcktJeuB6rgRv9k1DUNmwc9cOSSfrGv1QaUpEDDijvCGGbjU0vH7zbB0ppWZDmy6dfw/RVKmc2N mNi4okfqygU7ZW37L6AZYBu5OBKM3YLlT0elMsySe3jkxNrBWsgwcpAJwHwNjJNi1+OKCxmXFzrTy hE8rcRgkIcFrLvEvvwjRJfg7ggLhyZzH0lBIPhBIr54nnZ3WC6BsGktNYLBZ+kOhx8eeO0AYTzxPW pWo/ZRdXRcPLPAfyaThSOldWjEYj/3BB/bnFgW76OX8vLpA4FjyxwEmtXvsz9HlJau9beDh+h0//z aRIWpFAWDOmI9LEnl+uA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sFwZk-000000000L7-0LRI; Sat, 08 Jun 2024 13:57:44 +0000 Received: from mail-ed1-x52e.google.com ([2a00:1450:4864:20::52e]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1sFwZh-000000000Jr-14Yd for linux-arm-kernel@lists.infradead.org; Sat, 08 Jun 2024 13:57:42 +0000 Received: by mail-ed1-x52e.google.com with SMTP id 4fb4d7f45d1cf-57c72d6d5f3so302682a12.1 for ; Sat, 08 Jun 2024 06:57:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1717855058; x=1718459858; darn=lists.infradead.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=ATHWp/dx9XNWFfxqyNzwyLWvmPFO9JtEj/8KGLy30MQ=; b=grCKbm/jTPkhq5TAeae1V7/l8JiV0LyrjFqSRO7mNGv7V4a+b88rXH1iZyrXY1o1xV MslZMCkWEa1vAJ0cvbAPqXK9bmJk/mjJJN1XQ7gA+nxe99W/jR2SfIICJNB0IlkliXsU xFKSrUScww++Dx7GFe8C8SMInQF4PM16wziq64boIxU4qDltRwK8X4T+Bc0M0i6NsiOa ZBwyqnZnFswFHOXcGGoYrmNsS69qhmFMr7WEgHx4iEHb2hS3OEvHlxACslzq0mbF7f1z 8MXWPdJrFsLssEXA9IGqDOXMU7iXWrftvwZtcuIYIy9ZPRIrIg2LuFTUknjC5SWsXqWt Q/JA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1717855058; x=1718459858; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=ATHWp/dx9XNWFfxqyNzwyLWvmPFO9JtEj/8KGLy30MQ=; b=Z35DhdrdXTstJnioM8CK+8C778g/zjzSDUaKpDF4E98mp3B94UsujDzcg6IRrBQGjH FrQDpOiRFq3caVmRI7o8RznIYLdrg9c8tsN8NZOJ0kC8pGBjqW/CdaoQGHmQU6iKtmO5 HpP9Y0r53pkGXPFvHxbrXjQSlPoYRwW2T73pMqkaZnp4Ntb1p+ueWMK+gUNG3BH1AXQq J60xydhbH7cKcpSe2zCrDS/fmW2k8PGcLvkmqM8cVf4u4U01zkEVFa4wh/ZtRNdumaRT 1/4kaDKme7EKx+uoDo5MxzVAsy80YQTDSz30uWDKcj5+Vl4YQE563ANQiyiGuyBnq6c8 bSQQ== X-Forwarded-Encrypted: i=1; AJvYcCUYAx9j6V2Ea9ZldmYQC/Vz8Kzx/sU6c03EUYvRXJPFvTm34d3Y27ACjuZIgV8i8YuuhU2mUftHB3ji/knt0TRnV6lYBRBLjPB3f1g3Psm5oUe1l8o= X-Gm-Message-State: AOJu0YyzLjRnv2vunKQxSdWECXZ/ko2cSqafLSQCahwnqSu3xQ4JVjNK zz0vDIUSb8Qwzg2+6v2DQkBBdYCWM5r5/1ikmlt/oQhCzvfOltIu X-Google-Smtp-Source: AGHT+IHu1PowfDXRPVKxaC2rG5ito/4e7ETPFqVb1Wv2SDwuvHewQVtdPwJZiBgS6ziT6RxESzzQ7A== X-Received: by 2002:a50:d50e:0:b0:579:ca97:da1b with SMTP id 4fb4d7f45d1cf-57c5084e0damr2882721a12.6.1717855057289; Sat, 08 Jun 2024 06:57:37 -0700 (PDT) Received: from [10.5.1.156] (188-22-218-164.adsl.highway.telekom.at. [188.22.218.164]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-57aae12ce21sm4292594a12.49.2024.06.08.06.57.36 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 08 Jun 2024 06:57:37 -0700 (PDT) Message-ID: <0a45a87f-84d1-4fb7-adaf-c612af68cd40@gmail.com> Date: Sat, 8 Jun 2024 15:57:36 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 1/1] arm: rust: Enable Rust support for ARMv7 To: Miguel Ojeda , Jamie Cunliffe Cc: linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, rust-for-linux@vger.kernel.org, Miguel Ojeda , Sven Van Asbroeck References: <4e0f5932-c7bc-4878-862c-1186cbecd71d@gmail.com> Content-Language: en-US From: Christian Schrefl In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240608_065741_344256_6F0618EE X-CRM114-Status: GOOD ( 24.20 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org T24gMDguMDYuMjQgMjoxNiBQTSwgTWlndWVsIE9qZWRhIHdyb3RlOgo+IE9uIFNhdCwgSnVuIDgs IDIwMjQgYXQgMTI6MzDigK9BTSBDaHJpc3RpYW4gU2NocmVmbAo+IDxjaHJpc2kuc2NocmVmbEBn bWFpbC5jb20+IHdyb3RlOgo+Pgo+PiBUaGlzIGlzIGJhc2VkIG9uIHRoZSBjb2RlIGJ5IFN2ZW4g VmFuIEFzYnJvZWNrIGZyb20gdGhlIG9yaWdpbmFsCj4+IHJ1c3QgYnJhbmNoIGFuZCBpbnNwaXJl ZCBieSB0aGUgQUFyY2ggdmVyc2lvbiBieSBKYW1pZSBDdW5saWZmZS4KPiAKPiBUaGFua3MgZm9y IG1lbnRpb25pbmcgdGhhdCEKPiAKPiAoQUFyY2g2NCBwZXJoYXBzPykKCkFoIHllcyBJIG1lYW50 IEFBcmNoNjQuIEZpeGVkIGl0IGxvY2FsbHkuCgo+PiBJIGhhdmUgdGVzdGVkIHRoZSBydXN0IHNh bXBsZXMgYW5kIGEgY3VzdG9tIHNpbXBsZSBNTUlPIG1vZHVsZQo+PiBvbiBvbiBoYXJkd2FyZSAo RGUxU29DIEZQR0EgKyBBcm0gQTkgQ1BVKS4KPiAKPiBWZXJ5IG5pY2UgdG8gaGF2ZSB0ZXN0ZWQg aXQgaW4gcmVhbCBoYXJkd2FyZSwgdGhhbmtzIQo+IAo+IChEdXBsaWNhdGUgIm9uIG9uIikuCgpJ IGZpeGVkIHRoYXQgbG9jYWxseSwgYnV0IGZvcmdvdCB0byBydW4gZm9ybWF0LXBhdGNoIGFnYWlu LCBzb3JyeSEgCgo+PiArYGBhcm1gYCAgICAgICAgTWFpbnRhaW5lZCAgICAgICAgQVJNdjcgTGl0 dGxlIEVuZGlhbiBvbmx5Lgo+IAo+IEhvdyBoYXJkIHdvdWxkIGl0IGJlIHRvIHRlc3QgYW5kIG1h aW50YWluIG90aGVyIHZlcnNpb25zLCBldmVudHVhbGx5Pwo+IEkgbWV0IEphbWllIHJlY2VudGx5 LCBoZSBtYXkgaGF2ZSBzb21lIGlkZWFzIGhlcmUuCgpJIHRoaW5rIGl0IHdvdWxkIGp1c3QgYmUg c2V0dGluZyB0aGUgY29ycmVjdCBydXN0IHRhcmdldCwKYnV0IEkgaGF2ZSBubyBoYXJkd2FyZSB0 byB0ZXN0IGl0IGFuZCBJIHRoaW5rIGl0cyBiZXN0IHRvCm9ubHkgZG8gdjcgZm9yIHRoZSBpbml0 aWFsIHN1cHBvcnQuCgo+PiAtQklOREdFTl9UQVJHRVRfYXJtNjQgICA6PSBhYXJjaDY0LWxpbnV4 LWdudQo+PiArQklOREdFTl9UQVJHRVRfYXJtNjQ6PSBhYXJjaDY0LWxpbnV4LWdudQo+IAo+IFNw dXJpb3VzIGNoYW5nZT8KCkkndmUgY2hhbmdlZCB0aGF0IHNvIHRoZSA6PSBhbGlnbnMgd2l0aCB0 aGUgb3RoZXJzLCBidXQgSSBjYW4KcmVtb3ZlIHRoYXQgZm9yIHYyIGlmIHlvdSB3YW50Cgo+PiAr IyBEZXBlbmRpbmcgb24gaG93IHRoZSBhcmNoaXRlY3V0ZSBkZWZpbmVzIEFSQ0hfU0xBQl9NSU5B TElHTiwgYmluZGdlbiBtaWdodCBnZW5lcmF0ZSBhIGJpbmRpbmcuCj4+ICsjIERpc2FibGUgdGhp cyBoZXJlIGFzIHRoZXJlIGlzIGEgY29uc3QgdGhhdCB3aWxsIGFsd2F5cyBiZSBnZW5lcmF0ZWQg aW4gYmluZGluZ3NfaGVscGVyLmMKPiAKPiBUeXBvIGluICJhcmNoaXRlY3V0ZSIuIEFsc28sIEkg Z3Vlc3MgeW91IG1lYW4gYC5oYCBpbnN0ZWFkLiBQbGVhc2UgdXNlCj4gTWFya2Rvd24gZm9ybWF0 dGluZyBmb3IgY29uc2lzdGVuY3kgd2l0aCB0aGUgcmVzdCBvZiB0aGUgZmlsZS4KCkZpeGVkLgoK Pj4gKyAgICAgICAgcGFuaWMhKCJhcm0gdXNlcyB0aGUgYnVpbHRpbiBydXN0YyB0YXJnZXQiKTsK PiAKPiBTaW5jZSBBUk02NCBwdXRzIHRoZSBuYW1lIG9mIHRoZSB0YXJnZXQgaW4gdGhlIG1lc3Nh Z2UsIGl0IHdvdWxkIGJlCj4gbmljZSB0byBkbyB0aGUgc2FtZSAob3IgcGVyaGFwcyBpdCBjYW4g YmUgcmVtb3ZlZCBmcm9tIHRoZSBBUk02NCBvbmUKPiBvdGhlcndpc2UpLgoKSSBjYW4gYWRkIHRo ZSB0YXJnZXQgaGVyZSBidXQgdGhlbiB0aGUgbWVzc2FnZSB3b3VsZCBoYXZlIHRvIGRlcGVuZApv biB0aGUgc3ViIGFyY2hpdGVjdHVyZSBpZiB3ZSBzdXBwb3J0IHY2IGluIHRoZSBmdXR1cmUuIAoK PiBDaGVlcnMsCj4gTWlndWVsCgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fXwpsaW51eC1hcm0ta2VybmVsIG1haWxpbmcgbGlzdApsaW51eC1hcm0ta2VybmVs QGxpc3RzLmluZnJhZGVhZC5vcmcKaHR0cDovL2xpc3RzLmluZnJhZGVhZC5vcmcvbWFpbG1hbi9s aXN0aW5mby9saW51eC1hcm0ta2VybmVsCg==