From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 68EB846C4DE for ; Tue, 21 Jul 2026 17:28:43 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784654924; cv=none; b=s3TqlBoCB/917ZLDqPqcGb7rP/zrrkpRBrJ6c5P7BSIsqmt/9degdPdeYuK165AKs+fk993sayP7FZfc+pUTZabEI/hTzOzZASMMGdnMc2IbLBvQltR44/jYZL+xtKnojbBYupfL9px0JG4OfdXDe7vxYf+WDoRk0FhL0Q/trJ8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784654924; c=relaxed/simple; bh=oGFlurauW0vy2xr/ep3EzULbH9EoqX4fPrPLD7ylxYs=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=pei+hNQIQp0UTgxbcjb8MhUr9TRsYw/sW/LVedkjK5tnRz6zTVolaPRN5Q5dr8heZDfeP6LgA0KkUhMU5nDykAv3eipWERxryhONZVyq2Znkr5hOq3EY/TYKR5+bvj4pLMGbrEMpfTD1PIoRsrb5IgPv4AZUEfJdnyGrt4FeBs0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=cw8M+Eqc; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="cw8M+Eqc" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 383591F000E9; Tue, 21 Jul 2026 17:28:42 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1784654923; bh=kjkFhYoB1Ev0kpsBtGDB1sE4s/m+orvsz81sW+bZqeQ=; h=Date:Subject:To:Cc:References:From:In-Reply-To; b=cw8M+EqcwqvFfAhgchBX4Dlv1dcef5k/Xe5CkPTL/GofWNUsyYcPKkRoKHWR4n28K hMqXsTblcisTPehyA9P0R/U4GXsBtsFN6WFzBFe8UPY9HuKOpMiCCuuB0+1hpAXjD/ 3YtMB60Lj/Uj9fDpNKbZ07DW7qf7oaDH5938EYwlvxLA0TvZQADlEYDn+dRolNvJIc M1HGK92nUj8ENQxJPs4slnzdlF4sDQWj3aolelg+8r+rxi+vVf9dYFxGtaklq3E/+g LDNnzCsUmG2PQipSGWDr3gRGZxrql8275uWwSyvgCh4tCWYTPPK4tpNnBx8xm9XT3Y Oay7QQFZxWaNA== Message-ID: <0a61cf2d-d0bb-4986-a2c2-a05ee046571c@kernel.org> Date: Tue, 21 Jul 2026 19:28:40 +0200 Precedence: bulk X-Mailing-List: mptcp@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Beta Subject: Re: [PATCH mptcp-net] selftests: mptcp: userspace_pm: fix undefined variable port Content-Language: fr To: Geliang Tang , mptcp@lists.linux.dev Cc: Geliang Tang References: <24cb3786d7ce0e7bb1397ef14c98c78fd4a9ecb1.1782457344.git.tanggeliang@kylinos.cn> From: Matthieu Baerts Autocrypt: addr=matttbe@kernel.org; keydata= xsFNBFXj+ekBEADxVr99p2guPcqHFeI/JcFxls6KibzyZD5TQTyfuYlzEp7C7A9swoK5iCvf YBNdx5Xl74NLSgx6y/1NiMQGuKeu+2BmtnkiGxBNanfXcnl4L4Lzz+iXBvvbtCbynnnqDDqU c7SPFMpMesgpcu1xFt0F6bcxE+0ojRtSCZ5HDElKlHJNYtD1uwY4UYVGWUGCF/+cY1YLmtfb WdNb/SFo+Mp0HItfBC12qtDIXYvbfNUGVnA5jXeWMEyYhSNktLnpDL2gBUCsdbkov5VjiOX7 CRTkX0UgNWRjyFZwThaZADEvAOo12M5uSBk7h07yJ97gqvBtcx45IsJwfUJE4hy8qZqsA62A nTRflBvp647IXAiCcwWsEgE5AXKwA3aL6dcpVR17JXJ6nwHHnslVi8WesiqzUI9sbO/hXeXw TDSB+YhErbNOxvHqCzZEnGAAFf6ges26fRVyuU119AzO40sjdLV0l6LE7GshddyazWZf0iac nEhX9NKxGnuhMu5SXmo2poIQttJuYAvTVUNwQVEx/0yY5xmiuyqvXa+XT7NKJkOZSiAPlNt6 VffjgOP62S7M9wDShUghN3F7CPOrrRsOHWO/l6I/qJdUMW+MHSFYPfYiFXoLUZyPvNVCYSgs 3oQaFhHapq1f345XBtfG3fOYp1K2wTXd4ThFraTLl8PHxCn4ywARAQABzSRNYXR0aGlldSBC YWVydHMgPG1hdHR0YmVAa2VybmVsLm9yZz7CwZEEEwEIADsCGwMFCwkIBwIGFQoJCAsCBBYC AwECHgECF4AWIQToy4X3aHcFem4n93r2t4JPQmmgcwUCZUDpDAIZAQAKCRD2t4JPQmmgcz33 EACjROM3nj9FGclR5AlyPUbAq/txEX7E0EFQCDtdLPrjBcLAoaYJIQUV8IDCcPjZMJy2ADp7 /zSwYba2rE2C9vRgjXZJNt21mySvKnnkPbNQGkNRl3TZAinO1Ddq3fp2c/GmYaW1NWFSfOmw MvB5CJaN0UK5l0/drnaA6Hxsu62V5UnpvxWgexqDuo0wfpEeP1PEqMNzyiVPvJ8bJxgM8qoC cpXLp1Rq/jq7pbUycY8GeYw2j+FVZJHlhL0w0Zm9CFHThHxRAm1tsIPc+oTorx7haXP+nN0J iqBXVAxLK2KxrHtMygim50xk2QpUotWYfZpRRv8dMygEPIB3f1Vi5JMwP4M47NZNdpqVkHrm jvcNuLfDgf/vqUvuXs2eA2/BkIHcOuAAbsvreX1WX1rTHmx5ud3OhsWQQRVL2rt+0p1DpROI 3Ob8F78W5rKr4HYvjX2Inpy3WahAm7FzUY184OyfPO/2zadKCqg8n01mWA9PXxs84bFEV2mP VzC5j6K8U3RNA6cb9bpE5bzXut6T2gxj6j+7TsgMQFhbyH/tZgpDjWvAiPZHb3sV29t8XaOF BwzqiI2AEkiWMySiHwCCMsIH9WUH7r7vpwROko89Tk+InpEbiphPjd7qAkyJ+tNIEWd1+MlX ZPtOaFLVHhLQ3PLFLkrU3+Yi3tXqpvLE3gO3LM7BTQRV4/npARAA5+u/Sx1n9anIqcgHpA7l 5SUCP1e/qF7n5DK8LiM10gYglgY0XHOBi0S7vHppH8hrtpizx+7t5DBdPJgVtR6SilyK0/mp 9nWHDhc9rwU3KmHYgFFsnX58eEmZxz2qsIY8juFor5r7kpcM5dRR9aB+HjlOOJJgyDxcJTwM 1ey4L/79P72wuXRhMibN14SX6TZzf+/XIOrM6TsULVJEIv1+NdczQbs6pBTpEK/G2apME7vf mjTsZU26Ezn+LDMX16lHTmIJi7Hlh7eifCGGM+g/AlDV6aWKFS+sBbwy+YoS0Zc3Yz8zrdbi Kzn3kbKd+99//mysSVsHaekQYyVvO0KD2KPKBs1S/ImrBb6XecqxGy/y/3HWHdngGEY2v2IP Qox7mAPznyKyXEfG+0rrVseZSEssKmY01IsgwwbmN9ZcqUKYNhjv67WMX7tNwiVbSrGLZoqf Xlgw4aAdnIMQyTW8nE6hH/Iwqay4S2str4HZtWwyWLitk7N+e+vxuK5qto4AxtB7VdimvKUs x6kQO5F3YWcC3vCXCgPwyV8133+fIR2L81R1L1q3swaEuh95vWj6iskxeNWSTyFAVKYYVskG V+OTtB71P1XCnb6AJCW9cKpC25+zxQqD2Zy0dK3u2RuKErajKBa/YWzuSaKAOkneFxG3LJIv Hl7iqPF+JDCjB5sAEQEAAcLBXwQYAQIACQUCVeP56QIbDAAKCRD2t4JPQmmgc5VnD/9YgbCr HR1FbMbm7td54UrYvZV/i7m3dIQNXK2e+Cbv5PXf19ce3XluaE+wA8D+vnIW5mbAAiojt3Mb 6p0WJS3QzbObzHNgAp3zy/L4lXwc6WW5vnpWAzqXFHP8D9PTpqvBALbXqL06smP47JqbyQxj Xf7D2rrPeIqbYmVY9da1KzMOVf3gReazYa89zZSdVkMojfWsbq05zwYU+SCWS3NiyF6QghbW voxbFwX1i/0xRwJiX9NNbRj1huVKQuS4W7rbWA87TrVQPXUAdkyd7FRYICNW+0gddysIwPoa KrLfx3Ba6Rpx0JznbrVOtXlihjl4KV8mtOPjYDY9u+8x412xXnlGl6AC4HLu2F3ECkamY4G6 UxejX+E6vW6Xe4n7H+rEX5UFgPRdYkS1TA/X3nMen9bouxNsvIJv7C6adZmMHqu/2azX7S7I vrxxySzOw9GxjoVTuzWMKWpDGP8n71IFeOot8JuPZtJ8omz+DZel+WCNZMVdVNLPOd5frqOv mpz0VhFAlNTjU1Vy0CnuxX3AM51J8dpdNyG0S8rADh6C8AKCDOfUstpq28/6oTaQv7QZdge0 JY6dglzGKnCi/zsmp2+1w559frz4+IC7j/igvJGX4KDDKUs0mlld8J2u2sBXv7CGxdzQoHaz lzVbFe7fduHbABmYz9cefQpO7wDE/Q== Organization: NGI0 Core In-Reply-To: <24cb3786d7ce0e7bb1397ef14c98c78fd4a9ecb1.1782457344.git.tanggeliang@kylinos.cn> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Hi Geliang, On 26/06/2026 09:04, Geliang Tang wrote: > From: Geliang Tang > > In make_connection(), the variable "port" is used but never defined. > This leads to an empty argument being passed to wait_local_port_listen(), > causing "printf: : invalid number" errors: > > # INFO: Init > # 01 Created network namespaces ns1, ns2 [ OK ] > # INFO: Make connections > # ./../lib.sh: line 651: printf: : invalid number > # 02 Established IPv4 MPTCP Connection ns2 => ns1 [ OK ] > # INFO: Connection info: 10.0.1.2:59516 -> 10.0.1.1:50002 > # ./../lib.sh: line 651: printf: : invalid number > # 03 Established IPv6 MPTCP Connection ns2 => ns1 [ OK ] > > Fix it by using the correctly defined variable "app_port", which holds the > appropriate port number for the connection. Thank you for the fix, and sorry for the delay! Arf, I think remember I had this issue, and I thought I fixed it before sending the patches, but no. Reviewed-by: Matthieu Baerts (NGI0) New patches for t/upstream-net and t/upstream: - ebaa2571aeaa: selftests: mptcp: userspace_pm: fix undefined variable port - Results: 4c2362a7db02..08c6392dbaf1 (export-net) - Results: 4285a4fe811b..ea196b8ada26 (export) Tests are now in progress: - export-net: https://github.com/multipath-tcp/mptcp_net-next/commit/1ef110cb2b759cde24642c71416460cd328469cf/checks - export: https://github.com/multipath-tcp/mptcp_net-next/commit/9d33b57982424bae6bd4e53ffe848dc8043fc2d8/checks Cheers, Matt -- Sponsored by the NGI0 Core fund.