All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jens Axboe <axboe@kernel.dk>
To: Pavel Begunkov <asml.silence@gmail.com>, io-uring@vger.kernel.org
Subject: Re: [PATCH 2/2] io_uring: introduce non-circular SQ
Date: Tue, 14 Oct 2025 11:21:19 -0600	[thread overview]
Message-ID: <0a659c8b-45e4-489e-9b84-fce7600a4beb@kernel.dk> (raw)
In-Reply-To: <d2cb4a123518196c2f33b9adfad8a8828969808c.1760438982.git.asml.silence@gmail.com>

On 10/14/25 4:58 AM, Pavel Begunkov wrote:
> diff --git a/include/uapi/linux/io_uring.h b/include/uapi/linux/io_uring.h
> index a0cc1cc0dd01..d1c654a7fa9a 100644
> --- a/include/uapi/linux/io_uring.h
> +++ b/include/uapi/linux/io_uring.h
> @@ -231,6 +231,12 @@ enum io_uring_sqe_flags_bit {
>   */
>  #define IORING_SETUP_CQE_MIXED		(1U << 18)
>  
> +/*
> + * SQEs always start at index 0 in the submission ring instead of using a
> + * wrap around indexing.
> + */
> +#define IORING_SETUP_SQ_REWIND		(1U << 19)

No real comments on this patch, very straightforward. I do think this
comment should be expanded on considerably, mostly just by adding a
comparison to how it's different from the normal non-rewind way of
tracking which SQEs to submit. I can do it too, or send a v2.

-- 
Jens Axboe

  reply	other threads:[~2025-10-14 17:21 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-10-14 10:58 [PATCH 0/2] Introduce non circular SQ Pavel Begunkov
2025-10-14 10:58 ` [PATCH 1/2] io_uring: check for user passing 0 nr_submit Pavel Begunkov
2025-10-14 10:58 ` [PATCH 2/2] io_uring: introduce non-circular SQ Pavel Begunkov
2025-10-14 17:21   ` Jens Axboe [this message]
2025-10-14 18:58     ` Pavel Begunkov
2025-10-14 18:37   ` Caleb Sander Mateos
2025-10-14 19:26     ` Pavel Begunkov
2025-10-14 19:46       ` Caleb Sander Mateos
2025-10-16 11:38         ` Pavel Begunkov
2025-10-14 15:05 ` [PATCH 0/2] Introduce non circular SQ Jens Axboe
2025-10-14 16:02   ` Pavel Begunkov
2025-10-14 16:08     ` Pavel Begunkov
2025-10-14 17:19       ` Jens Axboe

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=0a659c8b-45e4-489e-9b84-fce7600a4beb@kernel.dk \
    --to=axboe@kernel.dk \
    --cc=asml.silence@gmail.com \
    --cc=io-uring@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.