diff for duplicates of <0a82b85608ea13424c601a4a6364652d2a411675.camel@intel.com> diff --git a/a/1.txt b/N1/1.txt index aed08f7..41b8222 100644 --- a/a/1.txt +++ b/N1/1.txt @@ -3,69 +3,69 @@ On Thu, 2021-12-02 at 02:31 +0000, Billy Tsai wrote: > > On 2021/12/2, 9:55 AM, "Zev Weiss" <zweiss@equinix.com> wrote: > -> ??? On Wed, Dec 01, 2021 at 02:38:04AM PST, Billy Tsai wrote: -> ??? >?? >Hi, -> ??? >?? > -> ??? >?? >On 2021/11/23, 10:10 PM, "openbmc on behalf of Iwona Winiarska" -> <openbmc-bounces+billy_tsai=aspeedtech.com@lists.ozlabs.org?on behalf of -> iwona.winiarska at intel.com> wrote: -> ??? >?? > -> ??? >?? >??? Add device tree bindings for the peci-aspeed controller driver. -> ??? >?? > -> ??? >?? >??? >?? +? aspeed,clock-divider: -> ??? >?? >??? >?? +??? description: -> ??? >?? >??? >?? +????? This value determines PECI controller internal clock +> On Wed, Dec 01, 2021 at 02:38:04AM PST, Billy Tsai wrote: +> > >Hi, +> > > +> > >On 2021/11/23, 10:10 PM, "openbmc on behalf of Iwona Winiarska" +> <openbmc-bounces+billy_tsai=aspeedtech.com@lists.ozlabs.org on behalf of +> iwona.winiarska@intel.com> wrote: +> > > +> > > Add device tree bindings for the peci-aspeed controller driver. +> > > +> > > > + aspeed,clock-divider: +> > > > + description: +> > > > + This value determines PECI controller internal clock > dividing -> ??? >?? >??? >?? +????? rate. The divider will be calculated as 2 raised to +> > > > + rate. The divider will be calculated as 2 raised to > the power of -> ??? >?? >??? >?? +????? the given value. -> ??? >?? >??? >?? +??? $ref: /schemas/types.yaml#/definitions/uint32 -> ??? >?? >??? >?? +??? minimum: 0 -> ??? >?? >??? >?? +??? maximum: 7 -> ??? >?? >??? >?? +??? default: 0 -> ??? >?? >??? >?? + -> ??? >?? >??? >?? +? aspeed,msg-timing: -> ??? >?? >??? >?? +??? description: -> ??? >?? >??? >?? +????? Message timing negotiation period. This value will +> > > > + the given value. +> > > > + $ref: /schemas/types.yaml#/definitions/uint32 +> > > > + minimum: 0 +> > > > + maximum: 7 +> > > > + default: 0 +> > > > + +> > > > + aspeed,msg-timing: +> > > > + description: +> > > > + Message timing negotiation period. This value will > determine the period -> ??? >?? >??? >?? +????? of message timing negotiation to be issued by PECI +> > > > + of message timing negotiation to be issued by PECI > controller. The unit -> ??? >?? >??? >?? +????? of the programmed value is four times of PECI clock +> > > > + of the programmed value is four times of PECI clock > period. -> ??? >?? >??? >?? +??? $ref: /schemas/types.yaml#/definitions/uint32 -> ??? >?? >??? >?? +??? minimum: 0 -> ??? >?? >??? >?? +??? maximum: 255 -> ??? >?? >??? >?? +??? default: 1 -> ??? >?? >??? >?? + -> ??? >?? >??? >?? +? aspeed,addr-timing: -> ??? >?? >??? >?? +??? description: -> ??? >?? >??? >?? +????? Address timing negotiation period. This value will +> > > > + $ref: /schemas/types.yaml#/definitions/uint32 +> > > > + minimum: 0 +> > > > + maximum: 255 +> > > > + default: 1 +> > > > + +> > > > + aspeed,addr-timing: +> > > > + description: +> > > > + Address timing negotiation period. This value will > determine the period -> ??? >?? >??? >?? +????? of address timing negotiation to be issued by PECI +> > > > + of address timing negotiation to be issued by PECI > controller. The unit -> ??? >?? >??? >?? +????? of the programmed value is four times of PECI clock +> > > > + of the programmed value is four times of PECI clock > period. -> ??? >?? >??? >?? +??? $ref: /schemas/types.yaml#/definitions/uint32 -> ??? >?? >??? >?? +??? minimum: 0 -> ??? >?? >??? >?? +??? maximum: 255 -> ??? >?? >??? >?? +??? default: 1 -> ??? >?? >I suggest deleting these three properties and replacing them with the +> > > > + $ref: /schemas/types.yaml#/definitions/uint32 +> > > > + minimum: 0 +> > > > + maximum: 255 +> > > > + default: 1 +> > >I suggest deleting these three properties and replacing them with the > following -> ??? >?? > -> ??? >?? >aspeed,peci-bit-time: -> ??? >?? >??????? description: -> ??? >?? >????????? The bit time driven by PECI controller. The unit of the +> > > +> > >aspeed,peci-bit-time: +> > > description: +> > > The bit time driven by PECI controller. The unit of the > value is Hz. -> ??? >?? >??? minimum: 2000 -> ??? >?? >??? maximum: 1000000 -> ??? >?? > -> ??? >?? >And the driver should use this property to caculate the appropriate +> > > minimum: 2000 +> > > maximum: 1000000 +> > > +> > >And the driver should use this property to caculate the appropriate > clock-divider, -> ??? >?? >msg-timing and addr-timing, instead of exposing hardware registers to +> > >msg-timing and addr-timing, instead of exposing hardware registers to > dts. -> ??? >?? > +> > > > -> ??? >?? Or perhaps just 'bus-frequency' a la i2c-aspeed, gpio-aspeed-sgpio, +> > Or perhaps just 'bus-frequency' a la i2c-aspeed, gpio-aspeed-sgpio, > etc? > > It's a good ideal for the consistency. diff --git a/a/content_digest b/N1/content_digest index 2dcd0e0..7d6bccc 100644 --- a/a/content_digest +++ b/N1/content_digest @@ -4,9 +4,37 @@ "ref\020211202015455.GB25091@packtop\0" "ref\04B35121C-3BF3-4EF2-BBE6-AA76FA1920E3@aspeedtech.com\0" "From\0Winiarska, Iwona <iwona.winiarska@intel.com>\0" - "Subject\0[PATCH v4 02/13] dt-bindings: Add bindings for peci-aspeed\0" + "Subject\0Re: [PATCH v4 02/13] dt-bindings: Add bindings for peci-aspeed\0" "Date\0Tue, 7 Dec 2021 18:15:11 +0000\0" - "To\0linux-aspeed@lists.ozlabs.org\0" + "To\0billy_tsai@aspeedtech.com <billy_tsai@aspeedtech.com>" + " zweiss@equinix.com <zweiss@equinix.com>\0" + "Cc\0corbet@lwn.net <corbet@lwn.net>" + jae.hyun.yoo@linux.intel.com <jae.hyun.yoo@linux.intel.com> + robh@kernel.org <robh@kernel.org> + linux-hwmon@vger.kernel.org <linux-hwmon@vger.kernel.org> + Hansen + Dave <dave.hansen@intel.com> + Luck + Tony <tony.luck@intel.com> + andrew@aj.id.au <andrew@aj.id.au> + jdelvare@suse.com <jdelvare@suse.com> + linux-kernel@vger.kernel.org <linux-kernel@vger.kernel.org> + olof@lixom.net <olof@lixom.net> + rdunlap@infradead.org <rdunlap@infradead.org> + devicetree@vger.kernel.org <devicetree@vger.kernel.org> + linux-aspeed@lists.ozlabs.org <linux-aspeed@lists.ozlabs.org> + linux@roeck-us.net <linux@roeck-us.net> + linux-doc@vger.kernel.org <linux-doc@vger.kernel.org> + arnd@arndb.de <arnd@arndb.de> + robh+dt@kernel.org <robh+dt@kernel.org> + openbmc@lists.ozlabs.org <openbmc@lists.ozlabs.org> + bp@alien8.de <bp@alien8.de> + gregkh@linuxfoundation.org <gregkh@linuxfoundation.org> + pierre-louis.bossart@linux.intel.com <pierre-louis.bossart@linux.intel.com> + andriy.shevchenko@linux.intel.com <andriy.shevchenko@linux.intel.com> + Williams + Dan J <dan.j.williams@intel.com> + " linux-arm-kernel@lists.infradead.org <linux-arm-kernel@lists.infradead.org>\0" "\00:1\0" "b\0" "On Thu, 2021-12-02 at 02:31 +0000, Billy Tsai wrote:\n" @@ -14,69 +42,69 @@ "> \n" "> On 2021/12/2, 9:55 AM, \"Zev Weiss\" <zweiss@equinix.com> wrote:\n" "> \n" - "> ??? On Wed, Dec 01, 2021 at 02:38:04AM PST, Billy Tsai wrote:\n" - "> ??? >?? >Hi,\n" - "> ??? >?? >\n" - "> ??? >?? >On 2021/11/23, 10:10 PM, \"openbmc on behalf of Iwona Winiarska\"\n" - "> <openbmc-bounces+billy_tsai=aspeedtech.com@lists.ozlabs.org?on behalf of\n" - "> iwona.winiarska at intel.com> wrote:\n" - "> ??? >?? >\n" - "> ??? >?? >??? Add device tree bindings for the peci-aspeed controller driver.\n" - "> ??? >?? >\n" - "> ??? >?? >??? >?? +? aspeed,clock-divider:\n" - "> ??? >?? >??? >?? +??? description:\n" - "> ??? >?? >??? >?? +????? This value determines PECI controller internal clock\n" + "> \302\240\302\240\302\240 On Wed, Dec 01, 2021 at 02:38:04AM PST, Billy Tsai wrote:\n" + "> \302\240\302\240\302\240 >\302\240\302\240 >Hi,\n" + "> \302\240\302\240\302\240 >\302\240\302\240 >\n" + "> \302\240\302\240\302\240 >\302\240\302\240 >On 2021/11/23, 10:10 PM, \"openbmc on behalf of Iwona Winiarska\"\n" + "> <openbmc-bounces+billy_tsai=aspeedtech.com@lists.ozlabs.org\302\240on behalf of\n" + "> iwona.winiarska@intel.com> wrote:\n" + "> \302\240\302\240\302\240 >\302\240\302\240 >\n" + "> \302\240\302\240\302\240 >\302\240\302\240 >\302\240\302\240\302\240 Add device tree bindings for the peci-aspeed controller driver.\n" + "> \302\240\302\240\302\240 >\302\240\302\240 >\n" + "> \302\240\302\240\302\240 >\302\240\302\240 >\302\240\302\240\302\240 >\302\240\302\240 +\302\240 aspeed,clock-divider:\n" + "> \302\240\302\240\302\240 >\302\240\302\240 >\302\240\302\240\302\240 >\302\240\302\240 +\302\240\302\240\302\240 description:\n" + "> \302\240\302\240\302\240 >\302\240\302\240 >\302\240\302\240\302\240 >\302\240\302\240 +\302\240\302\240\302\240\302\240\302\240 This value determines PECI controller internal clock\n" "> dividing\n" - "> ??? >?? >??? >?? +????? rate. The divider will be calculated as 2 raised to\n" + "> \302\240\302\240\302\240 >\302\240\302\240 >\302\240\302\240\302\240 >\302\240\302\240 +\302\240\302\240\302\240\302\240\302\240 rate. The divider will be calculated as 2 raised to\n" "> the power of\n" - "> ??? >?? >??? >?? +????? the given value.\n" - "> ??? >?? >??? >?? +??? $ref: /schemas/types.yaml#/definitions/uint32\n" - "> ??? >?? >??? >?? +??? minimum: 0\n" - "> ??? >?? >??? >?? +??? maximum: 7\n" - "> ??? >?? >??? >?? +??? default: 0\n" - "> ??? >?? >??? >?? +\n" - "> ??? >?? >??? >?? +? aspeed,msg-timing:\n" - "> ??? >?? >??? >?? +??? description:\n" - "> ??? >?? >??? >?? +????? Message timing negotiation period. This value will\n" + "> \302\240\302\240\302\240 >\302\240\302\240 >\302\240\302\240\302\240 >\302\240\302\240 +\302\240\302\240\302\240\302\240\302\240 the given value.\n" + "> \302\240\302\240\302\240 >\302\240\302\240 >\302\240\302\240\302\240 >\302\240\302\240 +\302\240\302\240\302\240 $ref: /schemas/types.yaml#/definitions/uint32\n" + "> \302\240\302\240\302\240 >\302\240\302\240 >\302\240\302\240\302\240 >\302\240\302\240 +\302\240\302\240\302\240 minimum: 0\n" + "> \302\240\302\240\302\240 >\302\240\302\240 >\302\240\302\240\302\240 >\302\240\302\240 +\302\240\302\240\302\240 maximum: 7\n" + "> \302\240\302\240\302\240 >\302\240\302\240 >\302\240\302\240\302\240 >\302\240\302\240 +\302\240\302\240\302\240 default: 0\n" + "> \302\240\302\240\302\240 >\302\240\302\240 >\302\240\302\240\302\240 >\302\240\302\240 +\n" + "> \302\240\302\240\302\240 >\302\240\302\240 >\302\240\302\240\302\240 >\302\240\302\240 +\302\240 aspeed,msg-timing:\n" + "> \302\240\302\240\302\240 >\302\240\302\240 >\302\240\302\240\302\240 >\302\240\302\240 +\302\240\302\240\302\240 description:\n" + "> \302\240\302\240\302\240 >\302\240\302\240 >\302\240\302\240\302\240 >\302\240\302\240 +\302\240\302\240\302\240\302\240\302\240 Message timing negotiation period. This value will\n" "> determine the period\n" - "> ??? >?? >??? >?? +????? of message timing negotiation to be issued by PECI\n" + "> \302\240\302\240\302\240 >\302\240\302\240 >\302\240\302\240\302\240 >\302\240\302\240 +\302\240\302\240\302\240\302\240\302\240 of message timing negotiation to be issued by PECI\n" "> controller. The unit\n" - "> ??? >?? >??? >?? +????? of the programmed value is four times of PECI clock\n" + "> \302\240\302\240\302\240 >\302\240\302\240 >\302\240\302\240\302\240 >\302\240\302\240 +\302\240\302\240\302\240\302\240\302\240 of the programmed value is four times of PECI clock\n" "> period.\n" - "> ??? >?? >??? >?? +??? $ref: /schemas/types.yaml#/definitions/uint32\n" - "> ??? >?? >??? >?? +??? minimum: 0\n" - "> ??? >?? >??? >?? +??? maximum: 255\n" - "> ??? >?? >??? >?? +??? default: 1\n" - "> ??? >?? >??? >?? +\n" - "> ??? >?? >??? >?? +? aspeed,addr-timing:\n" - "> ??? >?? >??? >?? +??? description:\n" - "> ??? >?? >??? >?? +????? Address timing negotiation period. This value will\n" + "> \302\240\302\240\302\240 >\302\240\302\240 >\302\240\302\240\302\240 >\302\240\302\240 +\302\240\302\240\302\240 $ref: /schemas/types.yaml#/definitions/uint32\n" + "> \302\240\302\240\302\240 >\302\240\302\240 >\302\240\302\240\302\240 >\302\240\302\240 +\302\240\302\240\302\240 minimum: 0\n" + "> \302\240\302\240\302\240 >\302\240\302\240 >\302\240\302\240\302\240 >\302\240\302\240 +\302\240\302\240\302\240 maximum: 255\n" + "> \302\240\302\240\302\240 >\302\240\302\240 >\302\240\302\240\302\240 >\302\240\302\240 +\302\240\302\240\302\240 default: 1\n" + "> \302\240\302\240\302\240 >\302\240\302\240 >\302\240\302\240\302\240 >\302\240\302\240 +\n" + "> \302\240\302\240\302\240 >\302\240\302\240 >\302\240\302\240\302\240 >\302\240\302\240 +\302\240 aspeed,addr-timing:\n" + "> \302\240\302\240\302\240 >\302\240\302\240 >\302\240\302\240\302\240 >\302\240\302\240 +\302\240\302\240\302\240 description:\n" + "> \302\240\302\240\302\240 >\302\240\302\240 >\302\240\302\240\302\240 >\302\240\302\240 +\302\240\302\240\302\240\302\240\302\240 Address timing negotiation period. This value will\n" "> determine the period\n" - "> ??? >?? >??? >?? +????? of address timing negotiation to be issued by PECI\n" + "> \302\240\302\240\302\240 >\302\240\302\240 >\302\240\302\240\302\240 >\302\240\302\240 +\302\240\302\240\302\240\302\240\302\240 of address timing negotiation to be issued by PECI\n" "> controller. The unit\n" - "> ??? >?? >??? >?? +????? of the programmed value is four times of PECI clock\n" + "> \302\240\302\240\302\240 >\302\240\302\240 >\302\240\302\240\302\240 >\302\240\302\240 +\302\240\302\240\302\240\302\240\302\240 of the programmed value is four times of PECI clock\n" "> period.\n" - "> ??? >?? >??? >?? +??? $ref: /schemas/types.yaml#/definitions/uint32\n" - "> ??? >?? >??? >?? +??? minimum: 0\n" - "> ??? >?? >??? >?? +??? maximum: 255\n" - "> ??? >?? >??? >?? +??? default: 1\n" - "> ??? >?? >I suggest deleting these three properties and replacing them with the\n" + "> \302\240\302\240\302\240 >\302\240\302\240 >\302\240\302\240\302\240 >\302\240\302\240 +\302\240\302\240\302\240 $ref: /schemas/types.yaml#/definitions/uint32\n" + "> \302\240\302\240\302\240 >\302\240\302\240 >\302\240\302\240\302\240 >\302\240\302\240 +\302\240\302\240\302\240 minimum: 0\n" + "> \302\240\302\240\302\240 >\302\240\302\240 >\302\240\302\240\302\240 >\302\240\302\240 +\302\240\302\240\302\240 maximum: 255\n" + "> \302\240\302\240\302\240 >\302\240\302\240 >\302\240\302\240\302\240 >\302\240\302\240 +\302\240\302\240\302\240 default: 1\n" + "> \302\240\302\240\302\240 >\302\240\302\240 >I suggest deleting these three properties and replacing them with the\n" "> following\n" - "> ??? >?? >\n" - "> ??? >?? >aspeed,peci-bit-time:\n" - "> ??? >?? >??????? description:\n" - "> ??? >?? >????????? The bit time driven by PECI controller. The unit of the\n" + "> \302\240\302\240\302\240 >\302\240\302\240 >\n" + "> \302\240\302\240\302\240 >\302\240\302\240 >aspeed,peci-bit-time:\n" + "> \302\240\302\240\302\240 >\302\240\302\240 >\302\240\302\240\302\240\302\240\302\240\302\240\302\240 description:\n" + "> \302\240\302\240\302\240 >\302\240\302\240 >\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240 The bit time driven by PECI controller. The unit of the\n" "> value is Hz.\n" - "> ??? >?? >??? minimum: 2000\n" - "> ??? >?? >??? maximum: 1000000\n" - "> ??? >?? >\n" - "> ??? >?? >And the driver should use this property to caculate the appropriate\n" + "> \302\240\302\240\302\240 >\302\240\302\240 >\302\240\302\240\302\240 minimum: 2000\n" + "> \302\240\302\240\302\240 >\302\240\302\240 >\302\240\302\240\302\240 maximum: 1000000\n" + "> \302\240\302\240\302\240 >\302\240\302\240 >\n" + "> \302\240\302\240\302\240 >\302\240\302\240 >And the driver should use this property to caculate the appropriate\n" "> clock-divider,\n" - "> ??? >?? >msg-timing and addr-timing, instead of exposing hardware registers to\n" + "> \302\240\302\240\302\240 >\302\240\302\240 >msg-timing and addr-timing, instead of exposing hardware registers to\n" "> dts.\n" - "> ??? >?? >\n" + "> \302\240\302\240\302\240 >\302\240\302\240 >\n" "> \n" - "> ??? >?? Or perhaps just 'bus-frequency' a la i2c-aspeed, gpio-aspeed-sgpio,\n" + "> \302\240\302\240\302\240 >\302\240\302\240 Or perhaps just 'bus-frequency' a la i2c-aspeed, gpio-aspeed-sgpio,\n" "> etc?\n" "> \n" "> It's a good ideal for the consistency.\n" @@ -98,4 +126,4 @@ "> \n" > -f1133f4dbe24cfa3a6bff1634a3d663f881ccea57787fb488fc12da1227d5917 +258b2bcf59976650e6b95961525616438e9c69d5025c1dc108199e99e5f84a51
diff --git a/a/1.txt b/N2/1.txt index aed08f7..41b8222 100644 --- a/a/1.txt +++ b/N2/1.txt @@ -3,69 +3,69 @@ On Thu, 2021-12-02 at 02:31 +0000, Billy Tsai wrote: > > On 2021/12/2, 9:55 AM, "Zev Weiss" <zweiss@equinix.com> wrote: > -> ??? On Wed, Dec 01, 2021 at 02:38:04AM PST, Billy Tsai wrote: -> ??? >?? >Hi, -> ??? >?? > -> ??? >?? >On 2021/11/23, 10:10 PM, "openbmc on behalf of Iwona Winiarska" -> <openbmc-bounces+billy_tsai=aspeedtech.com@lists.ozlabs.org?on behalf of -> iwona.winiarska at intel.com> wrote: -> ??? >?? > -> ??? >?? >??? Add device tree bindings for the peci-aspeed controller driver. -> ??? >?? > -> ??? >?? >??? >?? +? aspeed,clock-divider: -> ??? >?? >??? >?? +??? description: -> ??? >?? >??? >?? +????? This value determines PECI controller internal clock +> On Wed, Dec 01, 2021 at 02:38:04AM PST, Billy Tsai wrote: +> > >Hi, +> > > +> > >On 2021/11/23, 10:10 PM, "openbmc on behalf of Iwona Winiarska" +> <openbmc-bounces+billy_tsai=aspeedtech.com@lists.ozlabs.org on behalf of +> iwona.winiarska@intel.com> wrote: +> > > +> > > Add device tree bindings for the peci-aspeed controller driver. +> > > +> > > > + aspeed,clock-divider: +> > > > + description: +> > > > + This value determines PECI controller internal clock > dividing -> ??? >?? >??? >?? +????? rate. The divider will be calculated as 2 raised to +> > > > + rate. The divider will be calculated as 2 raised to > the power of -> ??? >?? >??? >?? +????? the given value. -> ??? >?? >??? >?? +??? $ref: /schemas/types.yaml#/definitions/uint32 -> ??? >?? >??? >?? +??? minimum: 0 -> ??? >?? >??? >?? +??? maximum: 7 -> ??? >?? >??? >?? +??? default: 0 -> ??? >?? >??? >?? + -> ??? >?? >??? >?? +? aspeed,msg-timing: -> ??? >?? >??? >?? +??? description: -> ??? >?? >??? >?? +????? Message timing negotiation period. This value will +> > > > + the given value. +> > > > + $ref: /schemas/types.yaml#/definitions/uint32 +> > > > + minimum: 0 +> > > > + maximum: 7 +> > > > + default: 0 +> > > > + +> > > > + aspeed,msg-timing: +> > > > + description: +> > > > + Message timing negotiation period. This value will > determine the period -> ??? >?? >??? >?? +????? of message timing negotiation to be issued by PECI +> > > > + of message timing negotiation to be issued by PECI > controller. The unit -> ??? >?? >??? >?? +????? of the programmed value is four times of PECI clock +> > > > + of the programmed value is four times of PECI clock > period. -> ??? >?? >??? >?? +??? $ref: /schemas/types.yaml#/definitions/uint32 -> ??? >?? >??? >?? +??? minimum: 0 -> ??? >?? >??? >?? +??? maximum: 255 -> ??? >?? >??? >?? +??? default: 1 -> ??? >?? >??? >?? + -> ??? >?? >??? >?? +? aspeed,addr-timing: -> ??? >?? >??? >?? +??? description: -> ??? >?? >??? >?? +????? Address timing negotiation period. This value will +> > > > + $ref: /schemas/types.yaml#/definitions/uint32 +> > > > + minimum: 0 +> > > > + maximum: 255 +> > > > + default: 1 +> > > > + +> > > > + aspeed,addr-timing: +> > > > + description: +> > > > + Address timing negotiation period. This value will > determine the period -> ??? >?? >??? >?? +????? of address timing negotiation to be issued by PECI +> > > > + of address timing negotiation to be issued by PECI > controller. The unit -> ??? >?? >??? >?? +????? of the programmed value is four times of PECI clock +> > > > + of the programmed value is four times of PECI clock > period. -> ??? >?? >??? >?? +??? $ref: /schemas/types.yaml#/definitions/uint32 -> ??? >?? >??? >?? +??? minimum: 0 -> ??? >?? >??? >?? +??? maximum: 255 -> ??? >?? >??? >?? +??? default: 1 -> ??? >?? >I suggest deleting these three properties and replacing them with the +> > > > + $ref: /schemas/types.yaml#/definitions/uint32 +> > > > + minimum: 0 +> > > > + maximum: 255 +> > > > + default: 1 +> > >I suggest deleting these three properties and replacing them with the > following -> ??? >?? > -> ??? >?? >aspeed,peci-bit-time: -> ??? >?? >??????? description: -> ??? >?? >????????? The bit time driven by PECI controller. The unit of the +> > > +> > >aspeed,peci-bit-time: +> > > description: +> > > The bit time driven by PECI controller. The unit of the > value is Hz. -> ??? >?? >??? minimum: 2000 -> ??? >?? >??? maximum: 1000000 -> ??? >?? > -> ??? >?? >And the driver should use this property to caculate the appropriate +> > > minimum: 2000 +> > > maximum: 1000000 +> > > +> > >And the driver should use this property to caculate the appropriate > clock-divider, -> ??? >?? >msg-timing and addr-timing, instead of exposing hardware registers to +> > >msg-timing and addr-timing, instead of exposing hardware registers to > dts. -> ??? >?? > +> > > > -> ??? >?? Or perhaps just 'bus-frequency' a la i2c-aspeed, gpio-aspeed-sgpio, +> > Or perhaps just 'bus-frequency' a la i2c-aspeed, gpio-aspeed-sgpio, > etc? > > It's a good ideal for the consistency. diff --git a/a/content_digest b/N2/content_digest index 2dcd0e0..2b8d48e 100644 --- a/a/content_digest +++ b/N2/content_digest @@ -4,9 +4,37 @@ "ref\020211202015455.GB25091@packtop\0" "ref\04B35121C-3BF3-4EF2-BBE6-AA76FA1920E3@aspeedtech.com\0" "From\0Winiarska, Iwona <iwona.winiarska@intel.com>\0" - "Subject\0[PATCH v4 02/13] dt-bindings: Add bindings for peci-aspeed\0" + "Subject\0Re: [PATCH v4 02/13] dt-bindings: Add bindings for peci-aspeed\0" "Date\0Tue, 7 Dec 2021 18:15:11 +0000\0" - "To\0linux-aspeed@lists.ozlabs.org\0" + "To\0billy_tsai@aspeedtech.com <billy_tsai@aspeedtech.com>" + " zweiss@equinix.com <zweiss@equinix.com>\0" + "Cc\0linux-aspeed@lists.ozlabs.org <linux-aspeed@lists.ozlabs.org>" + linux-doc@vger.kernel.org <linux-doc@vger.kernel.org> + Hansen + Dave <dave.hansen@intel.com> + robh@kernel.org <robh@kernel.org> + jae.hyun.yoo@linux.intel.com <jae.hyun.yoo@linux.intel.com> + corbet@lwn.net <corbet@lwn.net> + openbmc@lists.ozlabs.org <openbmc@lists.ozlabs.org> + pierre-louis.bossart@linux.intel.com <pierre-louis.bossart@linux.intel.com> + linux@roeck-us.net <linux@roeck-us.net> + devicetree@vger.kernel.org <devicetree@vger.kernel.org> + jdelvare@suse.com <jdelvare@suse.com> + arnd@arndb.de <arnd@arndb.de> + robh+dt@kernel.org <robh+dt@kernel.org> + bp@alien8.de <bp@alien8.de> + Williams + Dan J <dan.j.williams@intel.com> + andriy.shevchenko@linux.intel.com <andriy.shevchenko@linux.intel.com> + linux-arm-kernel@lists.infradead.org <linux-arm-kernel@lists.infradead.org> + linux-hwmon@vger.kernel.org <linux-hwmon@vger.kernel.org> + Luck + Tony <tony.luck@intel.com> + andrew@aj.id.au <andrew@aj.id.au> + gregkh@linuxfoundation.org <gregkh@linuxfoundation.org> + rdunlap@infradead.org <rdunlap@infradead.org> + linux-kernel@vger.kernel.org <linux-kernel@vger.kernel.org> + " olof@lixom.net <olof@lixom.net>\0" "\00:1\0" "b\0" "On Thu, 2021-12-02 at 02:31 +0000, Billy Tsai wrote:\n" @@ -14,69 +42,69 @@ "> \n" "> On 2021/12/2, 9:55 AM, \"Zev Weiss\" <zweiss@equinix.com> wrote:\n" "> \n" - "> ??? On Wed, Dec 01, 2021 at 02:38:04AM PST, Billy Tsai wrote:\n" - "> ??? >?? >Hi,\n" - "> ??? >?? >\n" - "> ??? >?? >On 2021/11/23, 10:10 PM, \"openbmc on behalf of Iwona Winiarska\"\n" - "> <openbmc-bounces+billy_tsai=aspeedtech.com@lists.ozlabs.org?on behalf of\n" - "> iwona.winiarska at intel.com> wrote:\n" - "> ??? >?? >\n" - "> ??? >?? >??? Add device tree bindings for the peci-aspeed controller driver.\n" - "> ??? >?? >\n" - "> ??? >?? >??? >?? +? aspeed,clock-divider:\n" - "> ??? >?? >??? >?? +??? description:\n" - "> ??? >?? >??? >?? +????? This value determines PECI controller internal clock\n" + "> \302\240\302\240\302\240 On Wed, Dec 01, 2021 at 02:38:04AM PST, Billy Tsai wrote:\n" + "> \302\240\302\240\302\240 >\302\240\302\240 >Hi,\n" + "> \302\240\302\240\302\240 >\302\240\302\240 >\n" + "> \302\240\302\240\302\240 >\302\240\302\240 >On 2021/11/23, 10:10 PM, \"openbmc on behalf of Iwona Winiarska\"\n" + "> <openbmc-bounces+billy_tsai=aspeedtech.com@lists.ozlabs.org\302\240on behalf of\n" + "> iwona.winiarska@intel.com> wrote:\n" + "> \302\240\302\240\302\240 >\302\240\302\240 >\n" + "> \302\240\302\240\302\240 >\302\240\302\240 >\302\240\302\240\302\240 Add device tree bindings for the peci-aspeed controller driver.\n" + "> \302\240\302\240\302\240 >\302\240\302\240 >\n" + "> \302\240\302\240\302\240 >\302\240\302\240 >\302\240\302\240\302\240 >\302\240\302\240 +\302\240 aspeed,clock-divider:\n" + "> \302\240\302\240\302\240 >\302\240\302\240 >\302\240\302\240\302\240 >\302\240\302\240 +\302\240\302\240\302\240 description:\n" + "> \302\240\302\240\302\240 >\302\240\302\240 >\302\240\302\240\302\240 >\302\240\302\240 +\302\240\302\240\302\240\302\240\302\240 This value determines PECI controller internal clock\n" "> dividing\n" - "> ??? >?? >??? >?? +????? rate. The divider will be calculated as 2 raised to\n" + "> \302\240\302\240\302\240 >\302\240\302\240 >\302\240\302\240\302\240 >\302\240\302\240 +\302\240\302\240\302\240\302\240\302\240 rate. The divider will be calculated as 2 raised to\n" "> the power of\n" - "> ??? >?? >??? >?? +????? the given value.\n" - "> ??? >?? >??? >?? +??? $ref: /schemas/types.yaml#/definitions/uint32\n" - "> ??? >?? >??? >?? +??? minimum: 0\n" - "> ??? >?? >??? >?? +??? maximum: 7\n" - "> ??? >?? >??? >?? +??? default: 0\n" - "> ??? >?? >??? >?? +\n" - "> ??? >?? >??? >?? +? aspeed,msg-timing:\n" - "> ??? >?? >??? >?? +??? description:\n" - "> ??? >?? >??? >?? +????? Message timing negotiation period. This value will\n" + "> \302\240\302\240\302\240 >\302\240\302\240 >\302\240\302\240\302\240 >\302\240\302\240 +\302\240\302\240\302\240\302\240\302\240 the given value.\n" + "> \302\240\302\240\302\240 >\302\240\302\240 >\302\240\302\240\302\240 >\302\240\302\240 +\302\240\302\240\302\240 $ref: /schemas/types.yaml#/definitions/uint32\n" + "> \302\240\302\240\302\240 >\302\240\302\240 >\302\240\302\240\302\240 >\302\240\302\240 +\302\240\302\240\302\240 minimum: 0\n" + "> \302\240\302\240\302\240 >\302\240\302\240 >\302\240\302\240\302\240 >\302\240\302\240 +\302\240\302\240\302\240 maximum: 7\n" + "> \302\240\302\240\302\240 >\302\240\302\240 >\302\240\302\240\302\240 >\302\240\302\240 +\302\240\302\240\302\240 default: 0\n" + "> \302\240\302\240\302\240 >\302\240\302\240 >\302\240\302\240\302\240 >\302\240\302\240 +\n" + "> \302\240\302\240\302\240 >\302\240\302\240 >\302\240\302\240\302\240 >\302\240\302\240 +\302\240 aspeed,msg-timing:\n" + "> \302\240\302\240\302\240 >\302\240\302\240 >\302\240\302\240\302\240 >\302\240\302\240 +\302\240\302\240\302\240 description:\n" + "> \302\240\302\240\302\240 >\302\240\302\240 >\302\240\302\240\302\240 >\302\240\302\240 +\302\240\302\240\302\240\302\240\302\240 Message timing negotiation period. This value will\n" "> determine the period\n" - "> ??? >?? >??? >?? +????? of message timing negotiation to be issued by PECI\n" + "> \302\240\302\240\302\240 >\302\240\302\240 >\302\240\302\240\302\240 >\302\240\302\240 +\302\240\302\240\302\240\302\240\302\240 of message timing negotiation to be issued by PECI\n" "> controller. The unit\n" - "> ??? >?? >??? >?? +????? of the programmed value is four times of PECI clock\n" + "> \302\240\302\240\302\240 >\302\240\302\240 >\302\240\302\240\302\240 >\302\240\302\240 +\302\240\302\240\302\240\302\240\302\240 of the programmed value is four times of PECI clock\n" "> period.\n" - "> ??? >?? >??? >?? +??? $ref: /schemas/types.yaml#/definitions/uint32\n" - "> ??? >?? >??? >?? +??? minimum: 0\n" - "> ??? >?? >??? >?? +??? maximum: 255\n" - "> ??? >?? >??? >?? +??? default: 1\n" - "> ??? >?? >??? >?? +\n" - "> ??? >?? >??? >?? +? aspeed,addr-timing:\n" - "> ??? >?? >??? >?? +??? description:\n" - "> ??? >?? >??? >?? +????? Address timing negotiation period. This value will\n" + "> \302\240\302\240\302\240 >\302\240\302\240 >\302\240\302\240\302\240 >\302\240\302\240 +\302\240\302\240\302\240 $ref: /schemas/types.yaml#/definitions/uint32\n" + "> \302\240\302\240\302\240 >\302\240\302\240 >\302\240\302\240\302\240 >\302\240\302\240 +\302\240\302\240\302\240 minimum: 0\n" + "> \302\240\302\240\302\240 >\302\240\302\240 >\302\240\302\240\302\240 >\302\240\302\240 +\302\240\302\240\302\240 maximum: 255\n" + "> \302\240\302\240\302\240 >\302\240\302\240 >\302\240\302\240\302\240 >\302\240\302\240 +\302\240\302\240\302\240 default: 1\n" + "> \302\240\302\240\302\240 >\302\240\302\240 >\302\240\302\240\302\240 >\302\240\302\240 +\n" + "> \302\240\302\240\302\240 >\302\240\302\240 >\302\240\302\240\302\240 >\302\240\302\240 +\302\240 aspeed,addr-timing:\n" + "> \302\240\302\240\302\240 >\302\240\302\240 >\302\240\302\240\302\240 >\302\240\302\240 +\302\240\302\240\302\240 description:\n" + "> \302\240\302\240\302\240 >\302\240\302\240 >\302\240\302\240\302\240 >\302\240\302\240 +\302\240\302\240\302\240\302\240\302\240 Address timing negotiation period. This value will\n" "> determine the period\n" - "> ??? >?? >??? >?? +????? of address timing negotiation to be issued by PECI\n" + "> \302\240\302\240\302\240 >\302\240\302\240 >\302\240\302\240\302\240 >\302\240\302\240 +\302\240\302\240\302\240\302\240\302\240 of address timing negotiation to be issued by PECI\n" "> controller. The unit\n" - "> ??? >?? >??? >?? +????? of the programmed value is four times of PECI clock\n" + "> \302\240\302\240\302\240 >\302\240\302\240 >\302\240\302\240\302\240 >\302\240\302\240 +\302\240\302\240\302\240\302\240\302\240 of the programmed value is four times of PECI clock\n" "> period.\n" - "> ??? >?? >??? >?? +??? $ref: /schemas/types.yaml#/definitions/uint32\n" - "> ??? >?? >??? >?? +??? minimum: 0\n" - "> ??? >?? >??? >?? +??? maximum: 255\n" - "> ??? >?? >??? >?? +??? default: 1\n" - "> ??? >?? >I suggest deleting these three properties and replacing them with the\n" + "> \302\240\302\240\302\240 >\302\240\302\240 >\302\240\302\240\302\240 >\302\240\302\240 +\302\240\302\240\302\240 $ref: /schemas/types.yaml#/definitions/uint32\n" + "> \302\240\302\240\302\240 >\302\240\302\240 >\302\240\302\240\302\240 >\302\240\302\240 +\302\240\302\240\302\240 minimum: 0\n" + "> \302\240\302\240\302\240 >\302\240\302\240 >\302\240\302\240\302\240 >\302\240\302\240 +\302\240\302\240\302\240 maximum: 255\n" + "> \302\240\302\240\302\240 >\302\240\302\240 >\302\240\302\240\302\240 >\302\240\302\240 +\302\240\302\240\302\240 default: 1\n" + "> \302\240\302\240\302\240 >\302\240\302\240 >I suggest deleting these three properties and replacing them with the\n" "> following\n" - "> ??? >?? >\n" - "> ??? >?? >aspeed,peci-bit-time:\n" - "> ??? >?? >??????? description:\n" - "> ??? >?? >????????? The bit time driven by PECI controller. The unit of the\n" + "> \302\240\302\240\302\240 >\302\240\302\240 >\n" + "> \302\240\302\240\302\240 >\302\240\302\240 >aspeed,peci-bit-time:\n" + "> \302\240\302\240\302\240 >\302\240\302\240 >\302\240\302\240\302\240\302\240\302\240\302\240\302\240 description:\n" + "> \302\240\302\240\302\240 >\302\240\302\240 >\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240 The bit time driven by PECI controller. The unit of the\n" "> value is Hz.\n" - "> ??? >?? >??? minimum: 2000\n" - "> ??? >?? >??? maximum: 1000000\n" - "> ??? >?? >\n" - "> ??? >?? >And the driver should use this property to caculate the appropriate\n" + "> \302\240\302\240\302\240 >\302\240\302\240 >\302\240\302\240\302\240 minimum: 2000\n" + "> \302\240\302\240\302\240 >\302\240\302\240 >\302\240\302\240\302\240 maximum: 1000000\n" + "> \302\240\302\240\302\240 >\302\240\302\240 >\n" + "> \302\240\302\240\302\240 >\302\240\302\240 >And the driver should use this property to caculate the appropriate\n" "> clock-divider,\n" - "> ??? >?? >msg-timing and addr-timing, instead of exposing hardware registers to\n" + "> \302\240\302\240\302\240 >\302\240\302\240 >msg-timing and addr-timing, instead of exposing hardware registers to\n" "> dts.\n" - "> ??? >?? >\n" + "> \302\240\302\240\302\240 >\302\240\302\240 >\n" "> \n" - "> ??? >?? Or perhaps just 'bus-frequency' a la i2c-aspeed, gpio-aspeed-sgpio,\n" + "> \302\240\302\240\302\240 >\302\240\302\240 Or perhaps just 'bus-frequency' a la i2c-aspeed, gpio-aspeed-sgpio,\n" "> etc?\n" "> \n" "> It's a good ideal for the consistency.\n" @@ -98,4 +126,4 @@ "> \n" > -f1133f4dbe24cfa3a6bff1634a3d663f881ccea57787fb488fc12da1227d5917 +2a87cd87deeb0b8508896a16b54fed51d4770d7b652efaa09a0cd01228811683
diff --git a/a/1.txt b/N3/1.txt index aed08f7..63ce3fd 100644 --- a/a/1.txt +++ b/N3/1.txt @@ -3,69 +3,69 @@ On Thu, 2021-12-02 at 02:31 +0000, Billy Tsai wrote: > > On 2021/12/2, 9:55 AM, "Zev Weiss" <zweiss@equinix.com> wrote: > -> ??? On Wed, Dec 01, 2021 at 02:38:04AM PST, Billy Tsai wrote: -> ??? >?? >Hi, -> ??? >?? > -> ??? >?? >On 2021/11/23, 10:10 PM, "openbmc on behalf of Iwona Winiarska" -> <openbmc-bounces+billy_tsai=aspeedtech.com@lists.ozlabs.org?on behalf of -> iwona.winiarska at intel.com> wrote: -> ??? >?? > -> ??? >?? >??? Add device tree bindings for the peci-aspeed controller driver. -> ??? >?? > -> ??? >?? >??? >?? +? aspeed,clock-divider: -> ??? >?? >??? >?? +??? description: -> ??? >?? >??? >?? +????? This value determines PECI controller internal clock +> On Wed, Dec 01, 2021 at 02:38:04AM PST, Billy Tsai wrote: +> > >Hi, +> > > +> > >On 2021/11/23, 10:10 PM, "openbmc on behalf of Iwona Winiarska" +> <openbmc-bounces+billy_tsai=aspeedtech.com@lists.ozlabs.org on behalf of +> iwona.winiarska@intel.com> wrote: +> > > +> > > Add device tree bindings for the peci-aspeed controller driver. +> > > +> > > > + aspeed,clock-divider: +> > > > + description: +> > > > + This value determines PECI controller internal clock > dividing -> ??? >?? >??? >?? +????? rate. The divider will be calculated as 2 raised to +> > > > + rate. The divider will be calculated as 2 raised to > the power of -> ??? >?? >??? >?? +????? the given value. -> ??? >?? >??? >?? +??? $ref: /schemas/types.yaml#/definitions/uint32 -> ??? >?? >??? >?? +??? minimum: 0 -> ??? >?? >??? >?? +??? maximum: 7 -> ??? >?? >??? >?? +??? default: 0 -> ??? >?? >??? >?? + -> ??? >?? >??? >?? +? aspeed,msg-timing: -> ??? >?? >??? >?? +??? description: -> ??? >?? >??? >?? +????? Message timing negotiation period. This value will +> > > > + the given value. +> > > > + $ref: /schemas/types.yaml#/definitions/uint32 +> > > > + minimum: 0 +> > > > + maximum: 7 +> > > > + default: 0 +> > > > + +> > > > + aspeed,msg-timing: +> > > > + description: +> > > > + Message timing negotiation period. This value will > determine the period -> ??? >?? >??? >?? +????? of message timing negotiation to be issued by PECI +> > > > + of message timing negotiation to be issued by PECI > controller. The unit -> ??? >?? >??? >?? +????? of the programmed value is four times of PECI clock +> > > > + of the programmed value is four times of PECI clock > period. -> ??? >?? >??? >?? +??? $ref: /schemas/types.yaml#/definitions/uint32 -> ??? >?? >??? >?? +??? minimum: 0 -> ??? >?? >??? >?? +??? maximum: 255 -> ??? >?? >??? >?? +??? default: 1 -> ??? >?? >??? >?? + -> ??? >?? >??? >?? +? aspeed,addr-timing: -> ??? >?? >??? >?? +??? description: -> ??? >?? >??? >?? +????? Address timing negotiation period. This value will +> > > > + $ref: /schemas/types.yaml#/definitions/uint32 +> > > > + minimum: 0 +> > > > + maximum: 255 +> > > > + default: 1 +> > > > + +> > > > + aspeed,addr-timing: +> > > > + description: +> > > > + Address timing negotiation period. This value will > determine the period -> ??? >?? >??? >?? +????? of address timing negotiation to be issued by PECI +> > > > + of address timing negotiation to be issued by PECI > controller. The unit -> ??? >?? >??? >?? +????? of the programmed value is four times of PECI clock +> > > > + of the programmed value is four times of PECI clock > period. -> ??? >?? >??? >?? +??? $ref: /schemas/types.yaml#/definitions/uint32 -> ??? >?? >??? >?? +??? minimum: 0 -> ??? >?? >??? >?? +??? maximum: 255 -> ??? >?? >??? >?? +??? default: 1 -> ??? >?? >I suggest deleting these three properties and replacing them with the +> > > > + $ref: /schemas/types.yaml#/definitions/uint32 +> > > > + minimum: 0 +> > > > + maximum: 255 +> > > > + default: 1 +> > >I suggest deleting these three properties and replacing them with the > following -> ??? >?? > -> ??? >?? >aspeed,peci-bit-time: -> ??? >?? >??????? description: -> ??? >?? >????????? The bit time driven by PECI controller. The unit of the +> > > +> > >aspeed,peci-bit-time: +> > > description: +> > > The bit time driven by PECI controller. The unit of the > value is Hz. -> ??? >?? >??? minimum: 2000 -> ??? >?? >??? maximum: 1000000 -> ??? >?? > -> ??? >?? >And the driver should use this property to caculate the appropriate +> > > minimum: 2000 +> > > maximum: 1000000 +> > > +> > >And the driver should use this property to caculate the appropriate > clock-divider, -> ??? >?? >msg-timing and addr-timing, instead of exposing hardware registers to +> > >msg-timing and addr-timing, instead of exposing hardware registers to > dts. -> ??? >?? > +> > > > -> ??? >?? Or perhaps just 'bus-frequency' a la i2c-aspeed, gpio-aspeed-sgpio, +> > Or perhaps just 'bus-frequency' a la i2c-aspeed, gpio-aspeed-sgpio, > etc? > > It's a good ideal for the consistency. @@ -85,4 +85,9 @@ Thanks > Best Regards, > Billy Tsai > -> +> + +_______________________________________________ +linux-arm-kernel mailing list +linux-arm-kernel@lists.infradead.org +http://lists.infradead.org/mailman/listinfo/linux-arm-kernel diff --git a/a/content_digest b/N3/content_digest index 2dcd0e0..f8c1b9d 100644 --- a/a/content_digest +++ b/N3/content_digest @@ -4,9 +4,37 @@ "ref\020211202015455.GB25091@packtop\0" "ref\04B35121C-3BF3-4EF2-BBE6-AA76FA1920E3@aspeedtech.com\0" "From\0Winiarska, Iwona <iwona.winiarska@intel.com>\0" - "Subject\0[PATCH v4 02/13] dt-bindings: Add bindings for peci-aspeed\0" + "Subject\0Re: [PATCH v4 02/13] dt-bindings: Add bindings for peci-aspeed\0" "Date\0Tue, 7 Dec 2021 18:15:11 +0000\0" - "To\0linux-aspeed@lists.ozlabs.org\0" + "To\0billy_tsai@aspeedtech.com <billy_tsai@aspeedtech.com>" + " zweiss@equinix.com <zweiss@equinix.com>\0" + "Cc\0corbet@lwn.net <corbet@lwn.net>" + jae.hyun.yoo@linux.intel.com <jae.hyun.yoo@linux.intel.com> + robh@kernel.org <robh@kernel.org> + linux-hwmon@vger.kernel.org <linux-hwmon@vger.kernel.org> + Hansen + Dave <dave.hansen@intel.com> + Luck + Tony <tony.luck@intel.com> + andrew@aj.id.au <andrew@aj.id.au> + jdelvare@suse.com <jdelvare@suse.com> + linux-kernel@vger.kernel.org <linux-kernel@vger.kernel.org> + olof@lixom.net <olof@lixom.net> + rdunlap@infradead.org <rdunlap@infradead.org> + devicetree@vger.kernel.org <devicetree@vger.kernel.org> + linux-aspeed@lists.ozlabs.org <linux-aspeed@lists.ozlabs.org> + linux@roeck-us.net <linux@roeck-us.net> + linux-doc@vger.kernel.org <linux-doc@vger.kernel.org> + arnd@arndb.de <arnd@arndb.de> + robh+dt@kernel.org <robh+dt@kernel.org> + openbmc@lists.ozlabs.org <openbmc@lists.ozlabs.org> + bp@alien8.de <bp@alien8.de> + gregkh@linuxfoundation.org <gregkh@linuxfoundation.org> + pierre-louis.bossart@linux.intel.com <pierre-louis.bossart@linux.intel.com> + andriy.shevchenko@linux.intel.com <andriy.shevchenko@linux.intel.com> + Williams + Dan J <dan.j.williams@intel.com> + " linux-arm-kernel@lists.infradead.org <linux-arm-kernel@lists.infradead.org>\0" "\00:1\0" "b\0" "On Thu, 2021-12-02 at 02:31 +0000, Billy Tsai wrote:\n" @@ -14,69 +42,69 @@ "> \n" "> On 2021/12/2, 9:55 AM, \"Zev Weiss\" <zweiss@equinix.com> wrote:\n" "> \n" - "> ??? On Wed, Dec 01, 2021 at 02:38:04AM PST, Billy Tsai wrote:\n" - "> ??? >?? >Hi,\n" - "> ??? >?? >\n" - "> ??? >?? >On 2021/11/23, 10:10 PM, \"openbmc on behalf of Iwona Winiarska\"\n" - "> <openbmc-bounces+billy_tsai=aspeedtech.com@lists.ozlabs.org?on behalf of\n" - "> iwona.winiarska at intel.com> wrote:\n" - "> ??? >?? >\n" - "> ??? >?? >??? Add device tree bindings for the peci-aspeed controller driver.\n" - "> ??? >?? >\n" - "> ??? >?? >??? >?? +? aspeed,clock-divider:\n" - "> ??? >?? >??? >?? +??? description:\n" - "> ??? >?? >??? >?? +????? This value determines PECI controller internal clock\n" + "> \302\240\302\240\302\240 On Wed, Dec 01, 2021 at 02:38:04AM PST, Billy Tsai wrote:\n" + "> \302\240\302\240\302\240 >\302\240\302\240 >Hi,\n" + "> \302\240\302\240\302\240 >\302\240\302\240 >\n" + "> \302\240\302\240\302\240 >\302\240\302\240 >On 2021/11/23, 10:10 PM, \"openbmc on behalf of Iwona Winiarska\"\n" + "> <openbmc-bounces+billy_tsai=aspeedtech.com@lists.ozlabs.org\302\240on behalf of\n" + "> iwona.winiarska@intel.com> wrote:\n" + "> \302\240\302\240\302\240 >\302\240\302\240 >\n" + "> \302\240\302\240\302\240 >\302\240\302\240 >\302\240\302\240\302\240 Add device tree bindings for the peci-aspeed controller driver.\n" + "> \302\240\302\240\302\240 >\302\240\302\240 >\n" + "> \302\240\302\240\302\240 >\302\240\302\240 >\302\240\302\240\302\240 >\302\240\302\240 +\302\240 aspeed,clock-divider:\n" + "> \302\240\302\240\302\240 >\302\240\302\240 >\302\240\302\240\302\240 >\302\240\302\240 +\302\240\302\240\302\240 description:\n" + "> \302\240\302\240\302\240 >\302\240\302\240 >\302\240\302\240\302\240 >\302\240\302\240 +\302\240\302\240\302\240\302\240\302\240 This value determines PECI controller internal clock\n" "> dividing\n" - "> ??? >?? >??? >?? +????? rate. The divider will be calculated as 2 raised to\n" + "> \302\240\302\240\302\240 >\302\240\302\240 >\302\240\302\240\302\240 >\302\240\302\240 +\302\240\302\240\302\240\302\240\302\240 rate. The divider will be calculated as 2 raised to\n" "> the power of\n" - "> ??? >?? >??? >?? +????? the given value.\n" - "> ??? >?? >??? >?? +??? $ref: /schemas/types.yaml#/definitions/uint32\n" - "> ??? >?? >??? >?? +??? minimum: 0\n" - "> ??? >?? >??? >?? +??? maximum: 7\n" - "> ??? >?? >??? >?? +??? default: 0\n" - "> ??? >?? >??? >?? +\n" - "> ??? >?? >??? >?? +? aspeed,msg-timing:\n" - "> ??? >?? >??? >?? +??? description:\n" - "> ??? >?? >??? >?? +????? Message timing negotiation period. This value will\n" + "> \302\240\302\240\302\240 >\302\240\302\240 >\302\240\302\240\302\240 >\302\240\302\240 +\302\240\302\240\302\240\302\240\302\240 the given value.\n" + "> \302\240\302\240\302\240 >\302\240\302\240 >\302\240\302\240\302\240 >\302\240\302\240 +\302\240\302\240\302\240 $ref: /schemas/types.yaml#/definitions/uint32\n" + "> \302\240\302\240\302\240 >\302\240\302\240 >\302\240\302\240\302\240 >\302\240\302\240 +\302\240\302\240\302\240 minimum: 0\n" + "> \302\240\302\240\302\240 >\302\240\302\240 >\302\240\302\240\302\240 >\302\240\302\240 +\302\240\302\240\302\240 maximum: 7\n" + "> \302\240\302\240\302\240 >\302\240\302\240 >\302\240\302\240\302\240 >\302\240\302\240 +\302\240\302\240\302\240 default: 0\n" + "> \302\240\302\240\302\240 >\302\240\302\240 >\302\240\302\240\302\240 >\302\240\302\240 +\n" + "> \302\240\302\240\302\240 >\302\240\302\240 >\302\240\302\240\302\240 >\302\240\302\240 +\302\240 aspeed,msg-timing:\n" + "> \302\240\302\240\302\240 >\302\240\302\240 >\302\240\302\240\302\240 >\302\240\302\240 +\302\240\302\240\302\240 description:\n" + "> \302\240\302\240\302\240 >\302\240\302\240 >\302\240\302\240\302\240 >\302\240\302\240 +\302\240\302\240\302\240\302\240\302\240 Message timing negotiation period. This value will\n" "> determine the period\n" - "> ??? >?? >??? >?? +????? of message timing negotiation to be issued by PECI\n" + "> \302\240\302\240\302\240 >\302\240\302\240 >\302\240\302\240\302\240 >\302\240\302\240 +\302\240\302\240\302\240\302\240\302\240 of message timing negotiation to be issued by PECI\n" "> controller. The unit\n" - "> ??? >?? >??? >?? +????? of the programmed value is four times of PECI clock\n" + "> \302\240\302\240\302\240 >\302\240\302\240 >\302\240\302\240\302\240 >\302\240\302\240 +\302\240\302\240\302\240\302\240\302\240 of the programmed value is four times of PECI clock\n" "> period.\n" - "> ??? >?? >??? >?? +??? $ref: /schemas/types.yaml#/definitions/uint32\n" - "> ??? >?? >??? >?? +??? minimum: 0\n" - "> ??? >?? >??? >?? +??? maximum: 255\n" - "> ??? >?? >??? >?? +??? default: 1\n" - "> ??? >?? >??? >?? +\n" - "> ??? >?? >??? >?? +? aspeed,addr-timing:\n" - "> ??? >?? >??? >?? +??? description:\n" - "> ??? >?? >??? >?? +????? Address timing negotiation period. This value will\n" + "> \302\240\302\240\302\240 >\302\240\302\240 >\302\240\302\240\302\240 >\302\240\302\240 +\302\240\302\240\302\240 $ref: /schemas/types.yaml#/definitions/uint32\n" + "> \302\240\302\240\302\240 >\302\240\302\240 >\302\240\302\240\302\240 >\302\240\302\240 +\302\240\302\240\302\240 minimum: 0\n" + "> \302\240\302\240\302\240 >\302\240\302\240 >\302\240\302\240\302\240 >\302\240\302\240 +\302\240\302\240\302\240 maximum: 255\n" + "> \302\240\302\240\302\240 >\302\240\302\240 >\302\240\302\240\302\240 >\302\240\302\240 +\302\240\302\240\302\240 default: 1\n" + "> \302\240\302\240\302\240 >\302\240\302\240 >\302\240\302\240\302\240 >\302\240\302\240 +\n" + "> \302\240\302\240\302\240 >\302\240\302\240 >\302\240\302\240\302\240 >\302\240\302\240 +\302\240 aspeed,addr-timing:\n" + "> \302\240\302\240\302\240 >\302\240\302\240 >\302\240\302\240\302\240 >\302\240\302\240 +\302\240\302\240\302\240 description:\n" + "> \302\240\302\240\302\240 >\302\240\302\240 >\302\240\302\240\302\240 >\302\240\302\240 +\302\240\302\240\302\240\302\240\302\240 Address timing negotiation period. This value will\n" "> determine the period\n" - "> ??? >?? >??? >?? +????? of address timing negotiation to be issued by PECI\n" + "> \302\240\302\240\302\240 >\302\240\302\240 >\302\240\302\240\302\240 >\302\240\302\240 +\302\240\302\240\302\240\302\240\302\240 of address timing negotiation to be issued by PECI\n" "> controller. The unit\n" - "> ??? >?? >??? >?? +????? of the programmed value is four times of PECI clock\n" + "> \302\240\302\240\302\240 >\302\240\302\240 >\302\240\302\240\302\240 >\302\240\302\240 +\302\240\302\240\302\240\302\240\302\240 of the programmed value is four times of PECI clock\n" "> period.\n" - "> ??? >?? >??? >?? +??? $ref: /schemas/types.yaml#/definitions/uint32\n" - "> ??? >?? >??? >?? +??? minimum: 0\n" - "> ??? >?? >??? >?? +??? maximum: 255\n" - "> ??? >?? >??? >?? +??? default: 1\n" - "> ??? >?? >I suggest deleting these three properties and replacing them with the\n" + "> \302\240\302\240\302\240 >\302\240\302\240 >\302\240\302\240\302\240 >\302\240\302\240 +\302\240\302\240\302\240 $ref: /schemas/types.yaml#/definitions/uint32\n" + "> \302\240\302\240\302\240 >\302\240\302\240 >\302\240\302\240\302\240 >\302\240\302\240 +\302\240\302\240\302\240 minimum: 0\n" + "> \302\240\302\240\302\240 >\302\240\302\240 >\302\240\302\240\302\240 >\302\240\302\240 +\302\240\302\240\302\240 maximum: 255\n" + "> \302\240\302\240\302\240 >\302\240\302\240 >\302\240\302\240\302\240 >\302\240\302\240 +\302\240\302\240\302\240 default: 1\n" + "> \302\240\302\240\302\240 >\302\240\302\240 >I suggest deleting these three properties and replacing them with the\n" "> following\n" - "> ??? >?? >\n" - "> ??? >?? >aspeed,peci-bit-time:\n" - "> ??? >?? >??????? description:\n" - "> ??? >?? >????????? The bit time driven by PECI controller. The unit of the\n" + "> \302\240\302\240\302\240 >\302\240\302\240 >\n" + "> \302\240\302\240\302\240 >\302\240\302\240 >aspeed,peci-bit-time:\n" + "> \302\240\302\240\302\240 >\302\240\302\240 >\302\240\302\240\302\240\302\240\302\240\302\240\302\240 description:\n" + "> \302\240\302\240\302\240 >\302\240\302\240 >\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240 The bit time driven by PECI controller. The unit of the\n" "> value is Hz.\n" - "> ??? >?? >??? minimum: 2000\n" - "> ??? >?? >??? maximum: 1000000\n" - "> ??? >?? >\n" - "> ??? >?? >And the driver should use this property to caculate the appropriate\n" + "> \302\240\302\240\302\240 >\302\240\302\240 >\302\240\302\240\302\240 minimum: 2000\n" + "> \302\240\302\240\302\240 >\302\240\302\240 >\302\240\302\240\302\240 maximum: 1000000\n" + "> \302\240\302\240\302\240 >\302\240\302\240 >\n" + "> \302\240\302\240\302\240 >\302\240\302\240 >And the driver should use this property to caculate the appropriate\n" "> clock-divider,\n" - "> ??? >?? >msg-timing and addr-timing, instead of exposing hardware registers to\n" + "> \302\240\302\240\302\240 >\302\240\302\240 >msg-timing and addr-timing, instead of exposing hardware registers to\n" "> dts.\n" - "> ??? >?? >\n" + "> \302\240\302\240\302\240 >\302\240\302\240 >\n" "> \n" - "> ??? >?? Or perhaps just 'bus-frequency' a la i2c-aspeed, gpio-aspeed-sgpio,\n" + "> \302\240\302\240\302\240 >\302\240\302\240 Or perhaps just 'bus-frequency' a la i2c-aspeed, gpio-aspeed-sgpio,\n" "> etc?\n" "> \n" "> It's a good ideal for the consistency.\n" @@ -96,6 +124,11 @@ "> Best Regards,\n" "> Billy Tsai\n" "> \n" - > + "> \n" + "\n" + "_______________________________________________\n" + "linux-arm-kernel mailing list\n" + "linux-arm-kernel@lists.infradead.org\n" + http://lists.infradead.org/mailman/listinfo/linux-arm-kernel -f1133f4dbe24cfa3a6bff1634a3d663f881ccea57787fb488fc12da1227d5917 +ba8682619fce6e6d313235d4348c918987921574e0cf21e3848fcd0033817234
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.