From: "Cédric Le Goater" <clg@redhat.com>
To: Matthew Rosato <mjrosato@linux.ibm.com>,
Farhan Ali <alifm@linux.ibm.com>,
qemu-devel@nongnu.org, qemu-s390x@nongnu.org,
farman@linux.ibm.com
Cc: cohuck@redhat.com, alex@shazbot.org, armbru@redhat.com
Subject: Re: [PATCH v5 2/3] s390x/pci: Add PCI error handling for vfio pci devices
Date: Thu, 17 Sep 2026 08:51:00 +0200 [thread overview]
Message-ID: <0a85a818-7a1a-44d2-b502-21dfba688e08@redhat.com> (raw)
In-Reply-To: <2ff23698-675f-4e4f-9257-51a31445ef30@linux.ibm.com>
On 9/17/26 03:21, Matthew Rosato wrote:
>
>>> + }
>>> +
>>> + fd = event_notifier_get_fd(&vfio_pci->err_notifier);
>>> + qemu_set_fd_handler(fd, s390_pci_err_handler, NULL, vfio_pci);
>
> @Eric - Since this version of the series is now all living in s390x
> code, I expect it will eventually go via an s390x PR -- but I'd like to
> make sure we at minimum get an ACK from Alex and/or Cédric for this
> patch due to the change above.
>
> I already see Cédric giving review comments (thank you!) but wanted to
> make the requirement explicit.
Sure.
Nothing major on my side. The 'pci_aer=true' is implicit and the Error
handling a bit weird.
Thanks,
C.
next prev parent reply other threads:[~2026-09-17 6:51 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-14 17:44 [PATCH v5 0/3] Error recovery for zPCI passthrough devices Farhan Ali
2026-09-14 17:44 ` [PATCH v5 1/3] linux-headers: Update Linux header to 7.3-rc3 Farhan Ali
2026-09-15 22:32 ` Farhan Ali
2026-09-14 17:44 ` [PATCH v5 2/3] s390x/pci: Add PCI error handling for vfio pci devices Farhan Ali
2026-09-16 8:13 ` Cédric Le Goater
2026-09-16 17:52 ` Farhan Ali
2026-09-17 1:21 ` Matthew Rosato
2026-09-17 6:51 ` Cédric Le Goater [this message]
2026-09-14 17:44 ` [PATCH v5 3/3] s390x/pci: Reset a device in error state Farhan Ali
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0a85a818-7a1a-44d2-b502-21dfba688e08@redhat.com \
--to=clg@redhat.com \
--cc=alex@shazbot.org \
--cc=alifm@linux.ibm.com \
--cc=armbru@redhat.com \
--cc=cohuck@redhat.com \
--cc=farman@linux.ibm.com \
--cc=mjrosato@linux.ibm.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-s390x@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.