From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.sourceforge.net (lists.sourceforge.net [216.105.38.7]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 836EAD29FB0 for ; Wed, 6 Nov 2024 07:41:16 +0000 (UTC) Received: from [127.0.0.1] (helo=sfs-ml-1.v29.lw.sourceforge.com) by sfs-ml-1.v29.lw.sourceforge.com with esmtp (Exim 4.95) (envelope-from ) id 1t8afB-0006Bm-I6; Wed, 06 Nov 2024 07:41:14 +0000 Received: from [172.30.29.66] (helo=mx.sourceforge.net) by sfs-ml-1.v29.lw.sourceforge.com with esmtps (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1t8afA-0006Bg-7a for linux-f2fs-devel@lists.sourceforge.net; Wed, 06 Nov 2024 07:41:12 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sourceforge.net; s=x; h=Content-Transfer-Encoding:Content-Type:In-Reply-To: From:References:To:Subject:Cc:MIME-Version:Date:Message-ID:Sender:Reply-To: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=VzlRAzolCVeyu9V6QpkLePAt1y/rEqcTj0QyOUeRZeo=; b=BXzlqVp8l1cWvOXh2h5CiP9KRu 16a24tX7DUwcXbx07FqtYvJ7OYAUEhBPJbSztwqhfpJF/L1f90N+xKKP8iXq47CNNSHaF/AaUL06O Fm4D91E4PSeGfC8akEazBhOS1FTo0ZtSqU7MqBxf017GWg1/V6NGuOhkc2JPXd8I09Ig=; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sf.net; s=x ; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From:References:To: Subject:Cc:MIME-Version:Date:Message-ID:Sender:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=VzlRAzolCVeyu9V6QpkLePAt1y/rEqcTj0QyOUeRZeo=; b=jQniHhbpYjurXZWEyf6hq/0Beb cY3VZ7nSxEd19Qg/tY0jTvpzHSdcme0t59AuIyLMvRq0ld0wjjJMFz93y0u08H464LXKAG8et9HaP 2O3erWrE1pAeLcH+GAJyaFsl05r1/zCF5+VEVC94LbvBJohqIoyi6x7ImtG2Y4m0eCIY=; Received: from nyc.source.kernel.org ([147.75.193.91]) by sfi-mx-2.v28.lw.sourceforge.com with esmtps (TLS1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.95) id 1t8af6-0007uj-4A for linux-f2fs-devel@lists.sourceforge.net; Wed, 06 Nov 2024 07:41:12 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by nyc.source.kernel.org (Postfix) with ESMTP id 14206A4295A; Wed, 6 Nov 2024 07:39:01 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id BC95FC4CED3; Wed, 6 Nov 2024 07:40:53 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1730878855; bh=8wA53S4ezlIPTVZA/MykpScLT344CmnrMjVY2QQPs+k=; h=Date:Cc:Subject:To:References:From:In-Reply-To:From; b=SNhMFzvIsfvyyCKV08GxdIG6SyWcfw5/kaol0V28q0uGXbbN+A2kZm6iXXBIznX5+ Ztx4UjQNf6yKeewYOdi77XHO1W+FvqX22YeH2blsW1uTnoiNhqrktAvb/pA1d4B4my yfVKhu6rQjoWx7G8FpT1Yi8ZjmpRDoAcPM5bMMXC7tM0cet4dx+xU19BDKTJGW1YiQ FHqISBwzS67zch7DQiNtExR8bJALHdAdwifxRcVk2s8fq1XlbaGf0aCgOx5coHiU37 JoX+MefZ6hRjlv+euOcGJ7XfLQ1LJWwfpIKUCzvWOZPfw7KgmMHFRcOnfMqwnXXbzd RVKKr/aIPNbOg== Message-ID: <0a8f96da-302d-4d6c-9ab6-0b66a05cbcfd@kernel.org> Date: Wed, 6 Nov 2024 15:40:50 +0800 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird To: Zhiguo Niu References: <1730685372-2995-1-git-send-email-zhiguo.niu@unisoc.com> <22873055-370b-4240-83ff-96bcfa91413a@kernel.org> <9199e9fc-7b5b-4069-b79b-65ba5ae1b0f6@kernel.org> Content-Language: en-US In-Reply-To: X-Headers-End: 1t8af6-0007uj-4A Subject: Re: [f2fs-dev] [PATCH V2] f2fs: fix to adjust appropriate length for fiemap X-BeenThere: linux-f2fs-devel@lists.sourceforge.net X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Chao Yu via Linux-f2fs-devel Reply-To: Chao Yu Cc: ke.wang@unisoc.com, linux-kernel@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net, Zhiguo Niu , jaegeuk@kernel.org, Hao_hao.Wang@unisoc.com Content-Transfer-Encoding: base64 Content-Type: text/plain; charset="utf-8"; Format="flowed" Errors-To: linux-f2fs-devel-bounces@lists.sourceforge.net T24gMjAyNC8xMS82IDE0OjA4LCBaaGlndW8gTml1IHdyb3RlOgo+IENoYW8gWXUgPGNoYW9Aa2Vy bmVsLm9yZz4g5LqOMjAyNOW5tDEx5pyINuaXpeWRqOS4iSAxMDo0MOWGmemBk++8mgo+Pgo+PiBP biAyMDI0LzExLzYgMTA6MjYsIFpoaWd1byBOaXUgd3JvdGU6Cj4+PiBDaGFvIFl1IDxjaGFvQGtl cm5lbC5vcmc+IOS6jjIwMjTlubQxMeaciDbml6XlkajkuIkgMTA6MTblhpnpgZPvvJoKPj4+Pgo+ Pj4+IE9uIDIwMjQvMTEvNSAxOTowMiwgWmhpZ3VvIE5pdSB3cm90ZToKPj4+Pj4gQ2hhbyBZdSA8 Y2hhb0BrZXJuZWwub3JnPiDkuo4yMDI05bm0MTHmnIg15pel5ZGo5LqMIDE4OjM55YaZ6YGT77ya Cj4+Pj4+Pgo+Pj4+Pj4gT24gMjAyNC8xMS81IDE1OjI4LCBaaGlndW8gTml1IHdyb3RlOgo+Pj4+ Pj4+IENoYW8gWXUgPGNoYW9Aa2VybmVsLm9yZz4g5LqOMjAyNOW5tDEx5pyINeaXpeWRqOS6jCAx NTowNOWGmemBk++8mgo+Pj4+Pj4+Pgo+Pj4+Pj4+PiBPbiAyMDI0LzExLzQgOTo1NiwgWmhpZ3Vv IE5pdSB3cm90ZToKPj4+Pj4+Pj4+IElmIHVzZXIgZ2l2ZSBhIGZpbGUgc2l6ZSBhcyAibGVuZ3Ro IiBwYXJhbWV0ZXIgZm9yIGZpZW1hcAo+Pj4+Pj4+Pj4gb3BlcmF0aW9ucywgYnV0IGlmIHRoaXMg c2l6ZSBpcyBub24tYmxvY2sgc2l6ZSBhbGlnbmVkLAo+Pj4+Pj4+Pj4gaXQgd2lsbCBzaG93IDIg c2VnbWVudHMgZmllbWFwIHJlc3VsdHMgZXZlbiB0aGlzIHdob2xlIGZpbGUKPj4+Pj4+Pj4+IGlz IGNvbnRpZ3VvdXMgb24gZGlzaywgc3VjaCBhcyB0aGUgZm9sbG93aW5nIHJlc3VsdHM6Cj4+Pj4+ Pj4+Pgo+Pj4+Pj4+Pj4gICAgICAgLi9mMmZzX2lvIGZpZW1hcCAwIDE5MDM0IHlsb2cvYW5hbHl6 ZXIucHkKPj4+Pj4+Pj4+IEZpZW1hcDogb2Zmc2V0ID0gMCBsZW4gPSAxOTAzNAo+Pj4+Pj4+Pj4g ICAgICAgICAgICAgIGxvZ2ljYWwgYWRkci4gICAgcGh5c2ljYWwgYWRkci4gICBsZW5ndGggICAg ICAgICAgIGZsYWdzCj4+Pj4+Pj4+PiAwICAgICAgIDAwMDAwMDAwMDAwMDAwMDAgMDAwMDAwMDAy MGJhYTAwMCAwMDAwMDAwMDAwMDA0MDAwIDAwMDAxMDAwCj4+Pj4+Pj4+PiAxICAgICAgIDAwMDAw MDAwMDAwMDQwMDAgMDAwMDAwMDAyMGJhZTAwMCAwMDAwMDAwMDAwMDAxMDAwIDAwMDAxMDAxCj4+ Pj4+Pj4+Pgo+Pj4+Pj4+Pj4gYWZ0ZXIgdGhpcyBwYXRjaDoKPj4+Pj4+Pj4+IC4vZjJmc19pbyBm aWVtYXAgMCAxOTAzNCB5bG9nL2FuYWx5emVyLnB5Cj4+Pj4+Pj4+PiBGaWVtYXA6IG9mZnNldCA9 IDAgbGVuID0gMTkwMzQKPj4+Pj4+Pj4+ICAgICAgICAgIGxvZ2ljYWwgYWRkci4gICAgcGh5c2lj YWwgYWRkci4gICBsZW5ndGggICAgICAgICAgIGZsYWdzCj4+Pj4+Pj4+PiAwICAgIDAwMDAwMDAw MDAwMDAwMDAgMDAwMDAwMDAzMTVmMzAwMCAwMDAwMDAwMDAwMDA1MDAwIDAwMDAxMDAxCj4+Pj4+ Pj4+Pgo+Pj4+Pj4+Pj4gU2lnbmVkLW9mZi1ieTogWmhpZ3VvIE5pdSA8emhpZ3VvLm5pdUB1bmlz b2MuY29tPgo+Pj4+Pj4+Pj4gLS0tCj4+Pj4+Pj4+PiBWMjogY29ycmVjdCBjb21taXQgbXNnIGFj Y29yZGluZyB0byBDaGFvJ3MgcXVlc3Rpb25zCj4+Pj4+Pj4+PiBmMmZzX2lvIGhhcyBiZWVuIG1v ZGlmaWVkIGZvciB0ZXN0aW5nLCB0aGUgbGVuZ3RoIGZvciBmaWVtYXAgaXMKPj4+Pj4+Pj4+IHJl YWwgZmlsZSBzaXplLCBub3QgYmxvY2sgbnVtYmVyCj4+Pj4+Pj4+PiAtLS0KPj4+Pj4+Pj4+ICAg ICAgIGZzL2YyZnMvZGF0YS5jIHwgNCArKy0tCj4+Pj4+Pj4+PiAgICAgICAxIGZpbGUgY2hhbmdl ZCwgMiBpbnNlcnRpb25zKCspLCAyIGRlbGV0aW9ucygtKQo+Pj4+Pj4+Pj4KPj4+Pj4+Pj4+IGRp ZmYgLS1naXQgYS9mcy9mMmZzL2RhdGEuYyBiL2ZzL2YyZnMvZGF0YS5jCj4+Pj4+Pj4+PiBpbmRl eCAzMDZiODZiMC4uOWZjMjI5ZCAxMDA2NDQKPj4+Pj4+Pj4+IC0tLSBhL2ZzL2YyZnMvZGF0YS5j Cj4+Pj4+Pj4+PiArKysgYi9mcy9mMmZzL2RhdGEuYwo+Pj4+Pj4+Pj4gQEAgLTE5NjYsOCArMTk2 Niw4IEBAIGludCBmMmZzX2ZpZW1hcChzdHJ1Y3QgaW5vZGUgKmlub2RlLCBzdHJ1Y3QgZmllbWFw X2V4dGVudF9pbmZvICpmaWVpbmZvLAo+Pj4+Pj4+Pj4gICAgICAgICAgICAgICAgICAgICAgICAg ICBnb3RvIG91dDsKPj4+Pj4+Pj4+ICAgICAgICAgICB9Cj4+Pj4+Pj4+Pgo+Pj4+Pj4+Pj4gLSAg ICAgaWYgKGJ5dGVzX3RvX2Jsa3MoaW5vZGUsIGxlbikgPT0gMCkKPj4+Pj4+Pj4+IC0gICAgICAg ICAgICAgbGVuID0gYmxrc190b19ieXRlcyhpbm9kZSwgMSk7Cj4+Pj4+Pj4+PiArICAgICBpZiAo bGVuICYgKGJsa3NfdG9fYnl0ZXMoaW5vZGUsIDEpIC0gMSkpCj4+Pj4+Pj4+PiArICAgICAgICAg ICAgIGxlbiA9IHJvdW5kX3VwKGxlbiwgYmxrc190b19ieXRlcyhpbm9kZSwgMSkpOwo+Pj4+Pj4+ Pgo+Pj4+Pj4+PiBIb3cgZG8geW91IHRoaW5rIG9mIGdldHRpbmcgcmlkIG9mIGFib3ZlIGFsaWdu bWVudCBmb3IgbGVuPwo+Pj4+Pj4+Pgo+Pj4+Pj4+Pj4KPj4+Pj4+Pj4+ICAgICAgICAgICBzdGFy dF9ibGsgPSBieXRlc190b19ibGtzKGlub2RlLCBzdGFydCk7Cj4+Pj4+Pj4+PiAgICAgICAgICAg bGFzdF9ibGsgPSBieXRlc190b19ibGtzKGlub2RlLCBzdGFydCArIGxlbiAtIDEpOwo+Pj4+Pj4+ Pgo+Pj4+Pj4+PiBBbmQgcm91bmQgdXAgZW5kIHBvc2l0aW9uIHcvOgo+Pj4+Pj4+Pgo+Pj4+Pj4+ PiBsYXN0X2JsayA9IGJ5dGVzX3RvX2Jsa3MoaW5vZGUsIHJvdW5kX3VwKHN0YXJ0ICsgbGVuIC0g MSwgRjJGU19CTEtTSVpFKSk7Cj4+Pj4+Pj4gSGkgQ2hhbywKPj4+Pj4+PiBJIHRoaW5rIHRoaXMg d2lsbCBjaGFuZ2UgdGhlIGN1cnJlbnQgY29kZSBsb2dpYwo+Pj4+Pj4+IC0tLS0tLS0tLS0tLS0K Pj4+Pj4+PiBpZiAoc3RhcnRfYmxrID4gbGFzdF9ibGspCj4+Pj4+Pj4gICAgICAgICBnb3RvIG91 dDsKPj4+Pj4+PiAtLS0tLS0tLS0tLS0tCj4+Pj4+Pj4gZm9yIGV4YW1wbGUsIGEgZmlsZSB3aXRo IHNpemUgMTkwMDYsIGJ1dCB0aGUgbGVuZ3RoIGZyb20gdGhlIHVzZXIgaXMgMTYzODQuCj4+Pj4+ Pj4gYmVmb3JlIHRoaXMgbW9kaWZpY2F0aW9uLCAgbGFzdF9ibGsgPSAgYnl0ZXNfdG9fYmxrcyhp bm9kZSwgc3RhcnQgKwo+Pj4+Pj4+IGxlbiAtIDEpID0gKGlub2RlLCAxNjM4MykgPSAzCj4+Pj4+ Pj4gYWZ0ZXIgdGhlIGZpcnN0IGYyZnNfbWFwX2Jsb2NrcygpLiBzdGFydF9ibGsgY2hhbmdlIHRv IGJlIDQsCj4+Pj4+Pj4gYWZ0ZXIgdGhlIHNlY29uZCBmMmZzX21hcF9ibG9ja3MoKSwgZmllbWFw X2ZpbGxfbmV4X2V4dGVuIHdpbGwgYmUKPj4+Pj4+PiBjYWxsZWQgdG8gZmlsbCB1c2VyIHBhcmFt ZXRlciBhbmQgdGhlbgo+Pj4+Pj4+IHdpbGwgZ290byBvdXQgYmVjYXVzZSBzdGFydF9ibGsgPiBs YXN0X2JsaywgdGhlbiBmaWVtYXAgZmxvdyBmaW5pc2hlcy4KPj4+Pj4+PiBidXQgYWZ0ZXIgdGhp cyBtb2RpZmljYXRpb24sIGxhc3RfYmxrIHdpbGwgYmUgNAo+Pj4+Pj4+IHdpbGwgZG8gZjJmc19t YXBfYmxvY2tzKCkgdW50aWwgcmVhY2ggdGhlIG1heF9maWxlX2Jsb2Nrcyhpbm9kZSkKPj4+Pj4+ Cj4+Pj4+PiBZZXMsIHlvdSdyZSByaWdodCwgaG93ZXZlciwgdy8gdGhpcyBwYXRjaCwgaXQgbWF5 IGNoYW5nZSBsYXN0X2JsaywgZS5nLgo+Pj4+Pj4KPj4+Pj4+IHhmc19pbyBmaWxlIC1jICJmaWVt YXAgLXYgMCAxOTAwNiIgdnMgeGZzX2lvIGZpbGUgLWMgImZpZW1hcCAtdiAyIDE5MDA2Igo+Pj4+ Pj4gc3RhcnRfYmxrIGFuZCBsYXN0X2JsayB3aWxsIGJlOiAwLCA0IGFuZCAwLCA1Lgo+Pj4+PiBI aSBDaGFvLAo+Pj4+PiB5ZXMsIGJ1dCB3L28gdGhpcyBwYXRjaCAsIHRoZSBvcmlnaW5hbCBjb2Rl IHN0aWxsIGhhcyB0aGUgc2FtZSBzaXR1YXRpb24/Pwo+Pj4+PiBmb3IgZXhhbXBsZQo+Pj4+PiB4 ZnNfaW8gZmlsZSAtYyAiZmllbWFwIC12IDAgMTYzODQiIHZzIHhmc19pbyBmaWxlIC1jICJmaWVt YXAgLXYgMiAxNjM4NCIKPj4+Pj4gc3RhcnRfYmxrIGFuZCBsYXN0X2JsayB3aWxsIGJlOiAwLCAz IGFuZCAwLCA0Lgo+Pj4+Cj4+Pj4gRm9yIHRoZSBjYXNlICJmaWVtYXAgLXYgMiAxOTAwNiIsIG9m ZnNldCBpcyAyLCBhbmQgbGVuZ3RoIGlzIDE5MDA2LCBzbyBsYXN0X29mZnNldAo+Pj4+IGlzIDE5 MDA4LCBhbmQgbGFzdF9ibGsgc2hvdWxkIGJlIDQgcmF0aGVyIHRoYW4gNSwgcmlnaHQ/Cj4+PiBo aSBDaGFvLAo+Pj4gaXQgaXMgcmlnaHQgdy9vIG15IHBhdGNoLgo+Pj4+Cj4+Pj4gQW5kIGZvciB5 b3UgY2FzZSwgaXQgY2FsY3VsYXRlcyBsYXN0X2JsayBjb3JyZWN0bHkuCj4+PiBTbyB5b3Ugc3Vn Z2VzdCB0aGF0ICJTaG91bGQgd2Ugcm91bmRfdXAgbGVuIGFmdGVyIHN0YXJ0X2JsayAmIGxhc3Rf YmxrCj4+PiBjYWxjdWxhdGlvbj8iCj4+Cj4+IFpoaWd1bywKPj4KPj4gWWVzLCBJIHRoaW5rIGFs aWdubWVudCBvZiBsZW4gc2hvdWxkIG5vdCBhZmZlY3QgY2FsY3VsYXRpb24gb2YgbGFzdF9ibGsu Cj4+Cj4+IEkgbWVhbiB0aGlzLAo+Pgo+PiAtLS0KPj4gICAgZnMvZjJmcy9kYXRhLmMgICAgICAg ICAgfCA2ICsrKy0tLQo+PiAgICBpbmNsdWRlL2xpbnV4L2YyZnNfZnMuaCB8IDMgKystCj4+ICAg IDIgZmlsZXMgY2hhbmdlZCwgNSBpbnNlcnRpb25zKCspLCA0IGRlbGV0aW9ucygtKQo+Pgo+PiBk aWZmIC0tZ2l0IGEvZnMvZjJmcy9kYXRhLmMgYi9mcy9mMmZzL2RhdGEuYwo+PiBpbmRleCA3ZDFi Yjk1MThhNDAuLmNiYmI5NTZmNDIwZCAxMDA2NDQKPj4gLS0tIGEvZnMvZjJmcy9kYXRhLmMKPj4g KysrIGIvZnMvZjJmcy9kYXRhLmMKPj4gQEAgLTE5NjcsMTIgKzE5NjcsMTIgQEAgaW50IGYyZnNf ZmllbWFwKHN0cnVjdCBpbm9kZSAqaW5vZGUsIHN0cnVjdCBmaWVtYXBfZXh0ZW50X2luZm8gKmZp ZWluZm8sCj4+ICAgICAgICAgICAgICAgICAgICAgICAgICBnb3RvIG91dDsKPj4gICAgICAgICAg fQo+Pgo+PiAtICAgICAgIGlmIChieXRlc190b19ibGtzKGlub2RlLCBsZW4pID09IDApCj4+IC0g ICAgICAgICAgICAgICBsZW4gPSBibGtzX3RvX2J5dGVzKGlub2RlLCAxKTsKPj4gLQo+PiAgICAg ICAgICBzdGFydF9ibGsgPSBieXRlc190b19ibGtzKGlub2RlLCBzdGFydCk7Cj4+ICAgICAgICAg IGxhc3RfYmxrID0gYnl0ZXNfdG9fYmxrcyhpbm9kZSwgc3RhcnQgKyBsZW4gLSAxKTsKPj4KPj4g KyAgICAgICBpZiAobGVuICYgRjJGU19CTEtTSVpFX01BU0spCj4+ICsgICAgICAgICAgICAgICBs ZW4gPSByb3VuZF91cChsZW4sIEYyRlNfQkxLU0laRSk7Cj4+ICsKPiBIaSBDaGFvLAo+IHRoaXMg dmVyaW9uIHZlcmlmeSBwYXNzIHdpdGggbXkgdGVzdCBjYXNlLgo+IAo+IGJ1dCB0aGVyZSBpcyBz dGlsbCBhbm90aGVyIGlzc3VlIGluIG9yZ2luYWwgY29kZToKPiB5bG9nL2FuYWx5emVyLnB5ICBz aXplID0gMTkwMzQKPiBpZiBJIGlucHV0IHRoZSBmb2xsb3dpbmcgY21kKHN0YXJ0L2xlbmd0aCBh cmUgYm90aCByZWFsIHNpemUsIG5vdCBibG9jayBudW1iZXIpCj4gL2YyZnNfaW8gZmllbWFwIDIg MTYzODQgeWxvZy9hbmFseXplci5weQo+IGFuZCB0aGUgcmVzdWx0cyBzaG93czoKPiBGaWVtYXA6 IG9mZnNldCA9IDIgbGVuID0gMTYzODQKPiAgICAgIGxvZ2ljYWwgYWRkci4gICAgcGh5c2ljYWwg YWRkci4gICBsZW5ndGggICAgICAgICAgIGZsYWdzCj4gMCAgICAwMDAwMDAwMDAwMDAwMDAwIDAw MDAwMDBlMmViY2EwMDAgMDAwMDAwMDAwMDAwNDAwMCAwMDAwMTAwMAo+IDEgICAgMDAwMDAwMDAw MDAwNDAwMCAwMDAwMDAwZTJlYmNlMDAwIDAwMDAwMDAwMDAwMDEwMDAgMDAwMDEwMDEKPiBzbyBz dGFydF9ibGsvbGFzdF9ibGsgc2hvdWxkIGJlIGNhbGN1bGF0ZSBpdCBpbiB0aGUgZm9sbG93aW5n IHdheT8KCklJVUMsIHRoZSByb290IGNhdXNlIGlzIGYyZnNfbWFwX2Jsb2NrcygpIHdpbGwgdHJ1 bmNhdGUgc2l6ZSBvZgpyZXR1cm5lZCBleHRlbnQgdG8gRjJGU19CWVRFU19UT19CTEsobGVuKSwg c28gd2hlbmV2ZXIgcGFyYW1ldGVyCkBsZW4gZG9lc24ndCBjb3ZlciBsYXN0IGV4dGVudCwgaXQg dHJpZ2dlcnMgdGhpcyBidWcuCgpuZXh0OgoJbWVtc2V0KCZtYXAsIDAsIHNpemVvZihtYXApKTsK CW1hcC5tX2xibGsgPSBzdGFydF9ibGs7CgltYXAubV9sZW4gPSBGMkZTX0JZVEVTX1RPX0JMSyhs ZW4pOyAgLS0tIGxpbWl0IG1heCBzaXplIG9mIGV4dGVudCBpdCBmb3VuZHMKCW1hcC5tX25leHRf cGdvZnMgPSAmbmV4dF9wZ29mczsKCW1hcC5tX3NlZ190eXBlID0gTk9fQ0hFQ0tfVFlQRTsKLi4u CglyZXQgPSBmMmZzX21hcF9ibG9ja3MoaW5vZGUsICZtYXAsIEYyRlNfR0VUX0JMT0NLX0ZJRU1B UCk7Cgp4ZnNfaW8gZmlsZSAtYyAiZmllbWFwIC12IDIgMTYzODQiCmZpbGU6CiAgRVhUOiBGSUxF LU9GRlNFVCAgICAgIEJMT0NLLVJBTkdFICAgICAgVE9UQUwgRkxBR1MKICAgIDA6IFswLi4zMV06 ICAgICAgICAgMTM5MjcyLi4xMzkzMDMgICAgICAzMiAweDEwMDAKICAgIDE6IFszMi4uMzldOiAg ICAgICAgMTM5MzA0Li4xMzkzMTEgICAgICAgOCAweDEwMDEKeGZzX2lvIGZpbGUgLWMgImZpZW1h cCAtdiAwIDE2Mzg0IgpmaWxlOgogIEVYVDogRklMRS1PRkZTRVQgICAgICBCTE9DSy1SQU5HRSAg ICAgIFRPVEFMIEZMQUdTCiAgICAwOiBbMC4uMzFdOiAgICAgICAgIDEzOTI3Mi4uMTM5MzAzICAg ICAgMzIgMHgxMDAwCnhmc19pbyBmaWxlIC1jICJmaWVtYXAgLXYgMCAxNjM4NSIKZmlsZToKICBF WFQ6IEZJTEUtT0ZGU0VUICAgICAgQkxPQ0stUkFOR0UgICAgICBUT1RBTCBGTEFHUwogICAgMDog WzAuLjM5XTogICAgICAgICAxMzkyNzIuLjEzOTMxMSAgICAgIDQwIDB4MTAwMQoKVGhvdWdodHM/ CgpUaGFua3MsCgo+IGJlZm9yZToKPiBzdGFydF9ibGsgPSBieXRlc190b19ibGtzKGlub2RlLCBz dGFydCk7Cj4gbGFzdF9ibGsgPSBieXRlc190b19ibGtzKGlub2RlLCBzdGFydCArIGxlbiAtIDEp Owo+IGFmdGVyOgo+IAo+IHN0YXJ0X2JsayA9IGJ5dGVzX3RvX2Jsa3MoaW5vZGUsIHN0YXJ0KTsK PiBsYXN0X2JsayA9IHN0YXJ0X2JsayArIGJ5dGVzX3RvX2Jsa3MoaW5vZGUsIGxlbiAtIDEpOwo+ IHRoYW5rcyEKPj4gICAgbmV4dDoKPj4gICAgICAgICAgbWVtc2V0KCZtYXAsIDAsIHNpemVvZiht YXApKTsKPj4gICAgICAgICAgbWFwLm1fbGJsayA9IHN0YXJ0X2JsazsKPj4gZGlmZiAtLWdpdCBh L2luY2x1ZGUvbGludXgvZjJmc19mcy5oIGIvaW5jbHVkZS9saW51eC9mMmZzX2ZzLmgKPj4gaW5k ZXggYjBiODIxZWRmZDk3Li45NTRlOGU4MzQ0YjcgMTAwNjQ0Cj4+IC0tLSBhL2luY2x1ZGUvbGlu dXgvZjJmc19mcy5oCj4+ICsrKyBiL2luY2x1ZGUvbGludXgvZjJmc19mcy5oCj4+IEBAIC0yNCwx MCArMjQsMTEgQEAKPj4gICAgI2RlZmluZSBORVdfQUREUiAgICAgICAgICAgICAgKChibG9ja190 KS0xKSAgIC8qIHVzZWQgYXMgYmxvY2tfdCBhZGRyZXNzZXMgKi8KPj4gICAgI2RlZmluZSBDT01Q UkVTU19BRERSICAgICAgICAgKChibG9ja190KS0yKSAgIC8qIHVzZWQgYXMgY29tcHJlc3NlZCBk YXRhIGZsYWcgKi8KPj4KPj4gKyNkZWZpbmUgRjJGU19CTEtTSVpFX01BU0sgICAgICAgICAgICAg IChGMkZTX0JMS1NJWkUgLSAxKQo+PiAgICAjZGVmaW5lIEYyRlNfQllURVNfVE9fQkxLKGJ5dGVz KSAgICAgICgoYnl0ZXMpID4+IEYyRlNfQkxLU0laRV9CSVRTKQo+PiAgICAjZGVmaW5lIEYyRlNf QkxLX1RPX0JZVEVTKGJsaykgICAgICAgICAgICAgICAgKChibGspIDw8IEYyRlNfQkxLU0laRV9C SVRTKQo+PiAgICAjZGVmaW5lIEYyRlNfQkxLX0VORF9CWVRFUyhibGspICAgICAgICAgICAgICAg KEYyRlNfQkxLX1RPX0JZVEVTKGJsayArIDEpIC0gMSkKPj4gLSNkZWZpbmUgRjJGU19CTEtfQUxJ R04oeCkgICAgICAgICAgICAgICAgICAgICAgKEYyRlNfQllURVNfVE9fQkxLKCh4KSArIEYyRlNf QkxLU0laRSAtIDEpKQo+PiArI2RlZmluZSBGMkZTX0JMS19BTElHTih4KSAgICAgICAgICAgICAg KEYyRlNfQllURVNfVE9fQkxLKCh4KSArIEYyRlNfQkxLU0laRSAtIDEpKQo+Pgo+PiAgICAvKiAw LCAxKG5vZGUgbmlkKSwgMihtZXRhIG5pZCkgYXJlIHJlc2VydmVkIG5vZGUgaWQgKi8KPj4gICAg I2RlZmluZSBGMkZTX1JFU0VSVkVEX05PREVfTlVNICAgICAgICAgICAgICAgIDMKPj4gLS0KPj4g Mi40MC4xCj4+Cj4+Cj4+Cj4+PiBUaGFua3MKPj4+Pgo+Pj4+IFRoYW5rcywKPj4+Pgo+Pj4+PiBi dXQgb3ZlcmFsbCBsYXN0X2JsayB3aWxsIGNoYW5nZSBsb29wIGNvdW50cyBidXQgaGFzIG5vdCBh ZmZlY3Qgb24gdGhlIHJlc3VsdHMuCj4+Pj4+Pgo+Pj4+Pj4gU2hvdWxkIHdlIHJvdW5kX3VwIGxl biBhZnRlciBzdGFydF9ibGsgJiBsYXN0X2JsayBjYWxjdWxhdGlvbj8KPj4+Pj4gSSB0aGlua3Mg aXQgaXMgb2sgLGJ1dCBqdXN0IGEgbGl0dGxlIGJpdCByZWR1bmRhbnQgd2l0aCB0aGUgZm9sbG93 aW5nCj4+Pj4+IGhhbmRsaW5nIGFib3V0IGxlbi4KPj4+Pj4KPj4+Pj4gaWYgKGJ5dGVzX3RvX2Js a3MoaW5vZGUsIGxlbikgPT0gMCkKPj4+Pj4gICAgICAgbGVuID0gYmxrc190b19ieXRlcyhpbm9k ZSwgMSk7Cj4+Pj4+Cj4+Pj4+IEJhc2VkIG9uIHRoZSBhYm92ZSBzaXR1YXRpb24sCj4+Pj4+IGRv IHlvdSBoYXZlIGFueSBvdGhlciBnb29kIHN1Z2dlc3Rpb25zPyBeXgo+Pj4+PiB0aGFua3MhCj4+ Pj4+Cj4+Pj4+Pgo+Pj4+Pj4gVGhhbmtzLAo+Pj4+Pj4KPj4+Pj4+PiB0aGFua3PvvIEKPj4+Pj4+ Pj4KPj4+Pj4+Pj4gVGhhbmtzLAo+Pj4+Pj4+Pgo+Pj4+Pj4KPj4+Pgo+PgoKCgpfX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpMaW51eC1mMmZzLWRldmVsIG1h aWxpbmcgbGlzdApMaW51eC1mMmZzLWRldmVsQGxpc3RzLnNvdXJjZWZvcmdlLm5ldApodHRwczov L2xpc3RzLnNvdXJjZWZvcmdlLm5ldC9saXN0cy9saXN0aW5mby9saW51eC1mMmZzLWRldmVsCg== From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1E6171CC8A3 for ; Wed, 6 Nov 2024 07:40:55 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1730878856; cv=none; b=Ibn/R9JQ8sYrYYqKYtQAMNA7E4th2rKbNhaPSzdWZB4oh8JMpiF5crx4nFN6/q2RcCIMS3g4qzMnTRyqDnt1BZLJlJSm34U7scwKrVZsrBJ+jFJ53V7AEGChf/ysIq344xG8P/i3Tpje170fwTymXo59MNHnQ1ikhp83hgz8zdY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1730878856; c=relaxed/simple; bh=8wA53S4ezlIPTVZA/MykpScLT344CmnrMjVY2QQPs+k=; h=Message-ID:Date:MIME-Version:Cc:Subject:To:References:From: In-Reply-To:Content-Type; b=B0rEa7cEXcV2whwGvJcsgZWmdt8X095qZ5grFf8pKcmqIDOiFui6GiHFe3hBKf4vzewjk1x9udrsVGb4TEffSMOVQhsqCZe6eUDXQOvlZ/hYzOQQdCbWOhfzRF/DzB23ZaqalA/FYiRYBLMjzJ3yC0gTatOpCBhudgK9Lf3BJTQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=SNhMFzvI; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="SNhMFzvI" Received: by smtp.kernel.org (Postfix) with ESMTPSA id BC95FC4CED3; Wed, 6 Nov 2024 07:40:53 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1730878855; bh=8wA53S4ezlIPTVZA/MykpScLT344CmnrMjVY2QQPs+k=; h=Date:Cc:Subject:To:References:From:In-Reply-To:From; b=SNhMFzvIsfvyyCKV08GxdIG6SyWcfw5/kaol0V28q0uGXbbN+A2kZm6iXXBIznX5+ Ztx4UjQNf6yKeewYOdi77XHO1W+FvqX22YeH2blsW1uTnoiNhqrktAvb/pA1d4B4my yfVKhu6rQjoWx7G8FpT1Yi8ZjmpRDoAcPM5bMMXC7tM0cet4dx+xU19BDKTJGW1YiQ FHqISBwzS67zch7DQiNtExR8bJALHdAdwifxRcVk2s8fq1XlbaGf0aCgOx5coHiU37 JoX+MefZ6hRjlv+euOcGJ7XfLQ1LJWwfpIKUCzvWOZPfw7KgmMHFRcOnfMqwnXXbzd RVKKr/aIPNbOg== Message-ID: <0a8f96da-302d-4d6c-9ab6-0b66a05cbcfd@kernel.org> Date: Wed, 6 Nov 2024 15:40:50 +0800 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Cc: Chao Yu , Zhiguo Niu , jaegeuk@kernel.org, linux-f2fs-devel@lists.sourceforge.net, linux-kernel@vger.kernel.org, ke.wang@unisoc.com, Hao_hao.Wang@unisoc.com Subject: Re: [PATCH V2] f2fs: fix to adjust appropriate length for fiemap To: Zhiguo Niu References: <1730685372-2995-1-git-send-email-zhiguo.niu@unisoc.com> <22873055-370b-4240-83ff-96bcfa91413a@kernel.org> <9199e9fc-7b5b-4069-b79b-65ba5ae1b0f6@kernel.org> Content-Language: en-US From: Chao Yu In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit On 2024/11/6 14:08, Zhiguo Niu wrote: > Chao Yu 于2024年11月6日周三 10:40写道： >> >> On 2024/11/6 10:26, Zhiguo Niu wrote: >>> Chao Yu 于2024年11月6日周三 10:16写道： >>>> >>>> On 2024/11/5 19:02, Zhiguo Niu wrote: >>>>> Chao Yu 于2024年11月5日周二 18:39写道： >>>>>> >>>>>> On 2024/11/5 15:28, Zhiguo Niu wrote: >>>>>>> Chao Yu 于2024年11月5日周二 15:04写道： >>>>>>>> >>>>>>>> On 2024/11/4 9:56, Zhiguo Niu wrote: >>>>>>>>> If user give a file size as "length" parameter for fiemap >>>>>>>>> operations, but if this size is non-block size aligned, >>>>>>>>> it will show 2 segments fiemap results even this whole file >>>>>>>>> is contiguous on disk, such as the following results: >>>>>>>>> >>>>>>>>> ./f2fs_io fiemap 0 19034 ylog/analyzer.py >>>>>>>>> Fiemap: offset = 0 len = 19034 >>>>>>>>> logical addr. physical addr. length flags >>>>>>>>> 0 0000000000000000 0000000020baa000 0000000000004000 00001000 >>>>>>>>> 1 0000000000004000 0000000020bae000 0000000000001000 00001001 >>>>>>>>> >>>>>>>>> after this patch: >>>>>>>>> ./f2fs_io fiemap 0 19034 ylog/analyzer.py >>>>>>>>> Fiemap: offset = 0 len = 19034 >>>>>>>>> logical addr. physical addr. length flags >>>>>>>>> 0 0000000000000000 00000000315f3000 0000000000005000 00001001 >>>>>>>>> >>>>>>>>> Signed-off-by: Zhiguo Niu >>>>>>>>> --- >>>>>>>>> V2: correct commit msg according to Chao's questions >>>>>>>>> f2fs_io has been modified for testing, the length for fiemap is >>>>>>>>> real file size, not block number >>>>>>>>> --- >>>>>>>>> fs/f2fs/data.c | 4 ++-- >>>>>>>>> 1 file changed, 2 insertions(+), 2 deletions(-) >>>>>>>>> >>>>>>>>> diff --git a/fs/f2fs/data.c b/fs/f2fs/data.c >>>>>>>>> index 306b86b0..9fc229d 100644 >>>>>>>>> --- a/fs/f2fs/data.c >>>>>>>>> +++ b/fs/f2fs/data.c >>>>>>>>> @@ -1966,8 +1966,8 @@ int f2fs_fiemap(struct inode *inode, struct fiemap_extent_info *fieinfo, >>>>>>>>> goto out; >>>>>>>>> } >>>>>>>>> >>>>>>>>> - if (bytes_to_blks(inode, len) == 0) >>>>>>>>> - len = blks_to_bytes(inode, 1); >>>>>>>>> + if (len & (blks_to_bytes(inode, 1) - 1)) >>>>>>>>> + len = round_up(len, blks_to_bytes(inode, 1)); >>>>>>>> >>>>>>>> How do you think of getting rid of above alignment for len? >>>>>>>> >>>>>>>>> >>>>>>>>> start_blk = bytes_to_blks(inode, start); >>>>>>>>> last_blk = bytes_to_blks(inode, start + len - 1); >>>>>>>> >>>>>>>> And round up end position w/: >>>>>>>> >>>>>>>> last_blk = bytes_to_blks(inode, round_up(start + len - 1, F2FS_BLKSIZE)); >>>>>>> Hi Chao, >>>>>>> I think this will change the current code logic >>>>>>> ------------- >>>>>>> if (start_blk > last_blk) >>>>>>> goto out; >>>>>>> ------------- >>>>>>> for example, a file with size 19006, but the length from the user is 16384. >>>>>>> before this modification, last_blk = bytes_to_blks(inode, start + >>>>>>> len - 1) = (inode, 16383) = 3 >>>>>>> after the first f2fs_map_blocks(). start_blk change to be 4, >>>>>>> after the second f2fs_map_blocks(), fiemap_fill_nex_exten will be >>>>>>> called to fill user parameter and then >>>>>>> will goto out because start_blk > last_blk, then fiemap flow finishes. >>>>>>> but after this modification, last_blk will be 4 >>>>>>> will do f2fs_map_blocks() until reach the max_file_blocks(inode) >>>>>> >>>>>> Yes, you're right, however, w/ this patch, it may change last_blk, e.g. >>>>>> >>>>>> xfs_io file -c "fiemap -v 0 19006" vs xfs_io file -c "fiemap -v 2 19006" >>>>>> start_blk and last_blk will be: 0, 4 and 0, 5. >>>>> Hi Chao, >>>>> yes, but w/o this patch , the original code still has the same situation?? >>>>> for example >>>>> xfs_io file -c "fiemap -v 0 16384" vs xfs_io file -c "fiemap -v 2 16384" >>>>> start_blk and last_blk will be: 0, 3 and 0, 4. >>>> >>>> For the case "fiemap -v 2 19006", offset is 2, and length is 19006, so last_offset >>>> is 19008, and last_blk should be 4 rather than 5, right? >>> hi Chao, >>> it is right w/o my patch. >>>> >>>> And for you case, it calculates last_blk correctly. >>> So you suggest that "Should we round_up len after start_blk & last_blk >>> calculation?" >> >> Zhiguo, >> >> Yes, I think alignment of len should not affect calculation of last_blk. >> >> I mean this, >> >> --- >> fs/f2fs/data.c | 6 +++--- >> include/linux/f2fs_fs.h | 3 ++- >> 2 files changed, 5 insertions(+), 4 deletions(-) >> >> diff --git a/fs/f2fs/data.c b/fs/f2fs/data.c >> index 7d1bb9518a40..cbbb956f420d 100644 >> --- a/fs/f2fs/data.c >> +++ b/fs/f2fs/data.c >> @@ -1967,12 +1967,12 @@ int f2fs_fiemap(struct inode *inode, struct fiemap_extent_info *fieinfo, >> goto out; >> } >> >> - if (bytes_to_blks(inode, len) == 0) >> - len = blks_to_bytes(inode, 1); >> - >> start_blk = bytes_to_blks(inode, start); >> last_blk = bytes_to_blks(inode, start + len - 1); >> >> + if (len & F2FS_BLKSIZE_MASK) >> + len = round_up(len, F2FS_BLKSIZE); >> + > Hi Chao, > this verion verify pass with my test case. > > but there is still another issue in orginal code: > ylog/analyzer.py size = 19034 > if I input the following cmd(start/length are both real size, not block number) > /f2fs_io fiemap 2 16384 ylog/analyzer.py > and the results shows: > Fiemap: offset = 2 len = 16384 > logical addr. physical addr. length flags > 0 0000000000000000 0000000e2ebca000 0000000000004000 00001000 > 1 0000000000004000 0000000e2ebce000 0000000000001000 00001001 > so start_blk/last_blk should be calculate it in the following way? IIUC, the root cause is f2fs_map_blocks() will truncate size of returned extent to F2FS_BYTES_TO_BLK(len), so whenever parameter @len doesn't cover last extent, it triggers this bug. next: memset(&map, 0, sizeof(map)); map.m_lblk = start_blk; map.m_len = F2FS_BYTES_TO_BLK(len); --- limit max size of extent it founds map.m_next_pgofs = &next_pgofs; map.m_seg_type = NO_CHECK_TYPE; ... ret = f2fs_map_blocks(inode, &map, F2FS_GET_BLOCK_FIEMAP); xfs_io file -c "fiemap -v 2 16384" file: EXT: FILE-OFFSET BLOCK-RANGE TOTAL FLAGS 0: [0..31]: 139272..139303 32 0x1000 1: [32..39]: 139304..139311 8 0x1001 xfs_io file -c "fiemap -v 0 16384" file: EXT: FILE-OFFSET BLOCK-RANGE TOTAL FLAGS 0: [0..31]: 139272..139303 32 0x1000 xfs_io file -c "fiemap -v 0 16385" file: EXT: FILE-OFFSET BLOCK-RANGE TOTAL FLAGS 0: [0..39]: 139272..139311 40 0x1001 Thoughts? Thanks, > before: > start_blk = bytes_to_blks(inode, start); > last_blk = bytes_to_blks(inode, start + len - 1); > after: > > start_blk = bytes_to_blks(inode, start); > last_blk = start_blk + bytes_to_blks(inode, len - 1); > thanks! >> next: >> memset(&map, 0, sizeof(map)); >> map.m_lblk = start_blk; >> diff --git a/include/linux/f2fs_fs.h b/include/linux/f2fs_fs.h >> index b0b821edfd97..954e8e8344b7 100644 >> --- a/include/linux/f2fs_fs.h >> +++ b/include/linux/f2fs_fs.h >> @@ -24,10 +24,11 @@ >> #define NEW_ADDR ((block_t)-1) /* used as block_t addresses */ >> #define COMPRESS_ADDR ((block_t)-2) /* used as compressed data flag */ >> >> +#define F2FS_BLKSIZE_MASK (F2FS_BLKSIZE - 1) >> #define F2FS_BYTES_TO_BLK(bytes) ((bytes) >> F2FS_BLKSIZE_BITS) >> #define F2FS_BLK_TO_BYTES(blk) ((blk) << F2FS_BLKSIZE_BITS) >> #define F2FS_BLK_END_BYTES(blk) (F2FS_BLK_TO_BYTES(blk + 1) - 1) >> -#define F2FS_BLK_ALIGN(x) (F2FS_BYTES_TO_BLK((x) + F2FS_BLKSIZE - 1)) >> +#define F2FS_BLK_ALIGN(x) (F2FS_BYTES_TO_BLK((x) + F2FS_BLKSIZE - 1)) >> >> /* 0, 1(node nid), 2(meta nid) are reserved node id */ >> #define F2FS_RESERVED_NODE_NUM 3 >> -- >> 2.40.1 >> >> >> >>> Thanks >>>> >>>> Thanks, >>>> >>>>> but overall last_blk will change loop counts but has not affect on the results. >>>>>> >>>>>> Should we round_up len after start_blk & last_blk calculation? >>>>> I thinks it is ok ,but just a little bit redundant with the following >>>>> handling about len. >>>>> >>>>> if (bytes_to_blks(inode, len) == 0) >>>>> len = blks_to_bytes(inode, 1); >>>>> >>>>> Based on the above situation, >>>>> do you have any other good suggestions? ^^ >>>>> thanks! >>>>> >>>>>> >>>>>> Thanks, >>>>>> >>>>>>> thanks！ >>>>>>>> >>>>>>>> Thanks, >>>>>>>> >>>>>> >>>> >>