From: David Ahern <dsahern@gmail.com>
To: Jiri Pirko <jiri@resnulli.us>, netdev@vger.kernel.org
Cc: davem@davemloft.net, jakub.kicinski@netronome.com,
stephen@networkplumber.org, roopa@cumulusnetworks.com,
dcbw@redhat.com, nikolay@cumulusnetworks.com, mkubecek@suse.cz,
andrew@lunn.ch, parav@mellanox.com, saeedm@mellanox.com,
f.fainelli@gmail.com, sd@queasysnail.net, sbrivio@redhat.com,
pabeni@redhat.com, mlxsw@mellanox.com
Subject: Re: [patch iproute2-next v4 1/3] lib/ll_map: cache alternative names
Date: Wed, 23 Oct 2019 09:11:38 -0600 [thread overview]
Message-ID: <0aa53f9c-b038-ff66-6e0e-65fe3bd3ee64@gmail.com> (raw)
In-Reply-To: <20191019173749.19068-2-jiri@resnulli.us>
On 10/19/19 11:37 AM, Jiri Pirko wrote:
> +static void ll_altname_entries_destroy(struct ll_cache *parent_im)
> +{
> + struct ll_cache *im;
> +
> + list_for_each_entry(im, &parent_im->altnames_list, altnames_list)
> + ll_entry_destroy(im, false);
you are walking a list and removing elements from it, so that should be
list_for_each_entry_safe, no?
next prev parent reply other threads:[~2019-10-23 15:11 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-19 17:37 [patch iproute2-next v4 0/3] ip: add support for alternative names Jiri Pirko
2019-10-19 17:37 ` [patch iproute2-next v4 1/3] lib/ll_map: cache " Jiri Pirko
2019-10-23 15:11 ` David Ahern [this message]
2019-10-23 16:08 ` Jiri Pirko
2019-10-19 17:37 ` [patch iproute2-next v4 2/3] ip: add support for alternative name addition/deletion/list Jiri Pirko
2019-10-19 17:37 ` [patch iproute2-next v4 3/3] ip: allow to use alternative names as handle Jiri Pirko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0aa53f9c-b038-ff66-6e0e-65fe3bd3ee64@gmail.com \
--to=dsahern@gmail.com \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=dcbw@redhat.com \
--cc=f.fainelli@gmail.com \
--cc=jakub.kicinski@netronome.com \
--cc=jiri@resnulli.us \
--cc=mkubecek@suse.cz \
--cc=mlxsw@mellanox.com \
--cc=netdev@vger.kernel.org \
--cc=nikolay@cumulusnetworks.com \
--cc=pabeni@redhat.com \
--cc=parav@mellanox.com \
--cc=roopa@cumulusnetworks.com \
--cc=saeedm@mellanox.com \
--cc=sbrivio@redhat.com \
--cc=sd@queasysnail.net \
--cc=stephen@networkplumber.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.